current community

your communities

more stack exchange communities

Stack Exchange
tour help
careers 2.0
Take the 2-minute tour ×
Stack Overflow is a question and answer site for professional and enthusiast programmers. It's 100% free, no registration required.
up vote 0 down vote favorite

I have browsed through questions similar to mine already on here, but have not found anything that will work for me.

Essentially what I have to do is read a file full of strings line by line, print them line by line and then word by word. I would like to accomplish this using .split to create an array of each individual string.

For instance, my file reads:
The fat cat was black
The cow jumped over the moon
I came to say hello world

etc.

I have figured out how to read the file and print the file line by line, but I cannot figure out how to print it word by word. Each of these 3 are in their own functions, so I'm not sure if that plays any role in where something is placed.

This is what I have so far in my method:

static public void printWords( String [ ] arr, int count )
{
    String [] s2 = arr[0].split( " " ); 

    for( int i = 0; i < count; i++)
    {
        System.out.println(  s2 [i] );
    }

    System.out.println();  
}

However, this is giving me an error. I switched around a couple things, but each time it prints either just the lines or stops at a certain point. The only thing I have in main is my method call pertaining to this, which is not the problem. If anyone has any insight it would be greatly appreciated. Thank you!

EDIT:

"Count" in my code is the number of lines in the file I am reading. So for this, it is 3.

I have tweaked the code to get what I need, however it only prints the first sentence. 

String [] s2 = arr[0].split( " " );
    for (int j = 0 ; j < count ; j++)
    {

        for( int i = 3; i < s2.length; i++)
        {

        System.out.print(  s2 [i] + " " );
        }
    System.out.println();

    }

}

For example, this only prints
The fat cat was black

And then ends. I am trying to construct another loop around it (as demonstrated by my code) but it ends up just printing "The fat cat was black" 3 times rather than moving to the next line of the file.

share|improve this question
1  
What error do you get? Your error also seems to come from count. Try s2.length instead of count –  Quillion Oct 17 '13 at 16:05
    
When you're iterating over s2, why use the count as the for loop condition? Why not s2.length? –  R.J Oct 17 '13 at 16:06
    
Please state your output and/or errors so we can better help you. –  SamCyanide Oct 17 '13 at 16:06
    
If this is Java 5 or higher, don't read line-by-line; use a Scanner. (java-util-scanner) –  damryfbfnetsi Oct 17 '13 at 16:06
    
I get an exception in main, and I forgot to mention this is a homework problem so I am unable to change the method call/definition. This is why I assumed I should use count since it is called. –  S12 Oct 17 '13 at 16:17
show 3 more comments

2 Answers

up vote 0 down vote

Try something like this:

static public void printWords(String [ ] arr)
{

  for(String s : arr) {
      String[] s2 = s.split(" ");
      for(String results : s2) {
          System.out.println(results);
      }
  }

}

With this you don't need the count variable either.

share|improve this answer
    
I forgot to state that this was a homework problem, and unfortunately I cannot change the method call so I'm forced to deal with the count variable. –  S12 Oct 17 '13 at 16:14
    
@S12 Ah, ok. Does it say what count is supposed to be used for? Using an external variable for iterating over an array is always more dangerous than using the internal array size. Looks like your professor is carrying over a habit from C/C++ of passing array size in, unless count means something different. –  trevor-e Oct 17 '13 at 16:16
    
It is used to count the actual number of lines in the file, because it was originally initialized to max and count is used to get rid of empty space in the array. –  S12 Oct 17 '13 at 16:21
    
S2 is a set of words from the first value in your array arr. Count is the number of lines in your text. There is no reason for those numbers to match, is there? What is in arr? –  Andrew Oct 17 '13 at 16:47
    
If you want to avoid blank lines due to leading or trailing spaces, you might want to call trim() on the arr before splitting it. –  Andrew Apr 6 at 14:00
add comment
up vote 0 down vote

it could be an error with your for loop stopping at count instead of (array.length || count)

share|improve this answer
add comment

Your Answer

 
discard

By posting your answer, you agree to the privacy policy and terms of service.

Not the answer you're looking for? Browse other questions tagged or ask your own question.