current community

your communities

more stack exchange communities

Stack Exchange
tour help
Take the 2-minute tour ×
Code Review Stack Exchange is a question and answer site for peer programmer code reviews. It's 100% free, no registration required.
up vote 0 down vote favorite

We know when we call HttpContext.Current.Response.Redirect("http://tvrowdy.in"); It throw an exception. Can we do it this way(working fine). Need suggestions and improvements.

public static void ReferToPage(string strPageName)
{
    try
    {
        HttpContext.Current.Response.Redirect(strPageName, false);
    }
    catch
    {

    }
}
share|improve this question

closed as not a real question by svick, John Syrinek, Glenn Rogers, Jeff Vanzella, James Khoury Jun 11 '13 at 2:27

It's difficult to tell what is being asked here. This question is ambiguous, vague, incomplete, overly broad, or rhetorical and cannot be reasonably answered in its current form. For help clarifying this question so that it can be reopened, visit the help center.If this question can be reworded to fit the rules in the help center, please edit the question.
    
It's difficult to tell what is being asked here. This question is ambiguous, vague, incomplete, overly broad, or rhetorical and cannot be reasonably answered in its current form. For help clarifying this question so that it can be reopened, see the FAQ. codereview.stackexchange.com/faq#close –  John Syrinek Jun 7 '13 at 3:09
1  
The code that you show is pointless, because sending false as the second parameter keeps the Redirect method from throwing an exception. There will never be any exception to catch (unless you call it too late so that the redirection is not possible any more). –  Guffa Jun 7 '13 at 16:03

1 Answer 1

up vote 1 down vote

I'd recommend against using 'catch-all' blocks unless absolutely necessary.

Response.Redirect always throws a ThreadAbortedException by design (like it or not), unless you pass in the false for the second parameter.

If you specify true for the endResponse parameter, this method calls the End method for the original request, which throws a ThreadAbortException exception when it completes. This exception has a detrimental effect on Web application performance, which is why passing false for the endResponse parameter is recommended.

Any other exceptions it throws indicate a invalid parameter or bad program state. You probably don't want to just ignore these errors and move on as though nothing has happened. I recommend you just do this:

public static void ReferToPage(string strPageName)
{
    HttpContext.Current.Response.Redirect(strPageName, false);
}
share|improve this answer
1  
Would removing try catch block impact on performance? –  vikas Jun 7 '13 at 8:17
    
@vikas It won't impact performance at all. Catch-all blocks are just bad practice. –  p.s.w.g Jun 7 '13 at 13:30

Not the answer you're looking for? Browse other questions tagged or ask your own question.