echo javascript function with php variables as arguments

Question

In test.php:

<?php
$result = "test";
echo '<script type="text/javascript">parent.showThanksDiv(\"<?php echo $result;?>\");</script>';
?>

and in test.html

  <script type="text/javascript">
 function showThanksDiv(text){
      document.getElementById("myThanksDivtext").value = text;
    }
</script>

That's not working. It seams Im not passing php variables correctly. Any ideas?

Answer 1

Change the PHP to:

<?php
$result = "test";
echo '<script type="text/javascript">parent.showThanksDiv("' . $result . '");</script>';
?>

You don't need to wrap the PHP variable in <?php and ?> since you're still in PHP.

Answer 2

I guess you wanted to do something like that:

<?php
$result = "test";
echo '<script>parent.showThanksDiv("' . $result . '");</script>';
?>

Or to be more secure, I'd suggest to use json_encode():

echo '<script>parent.showThanksDiv(' . json_encode($result) . ');</script>';