current community

your communities

more stack exchange communities

Stack Exchange
tour help
careers 2.0
Take the 2-minute tour ×
Stack Overflow is a question and answer site for professional and enthusiast programmers. It's 100% free, no registration required.
up vote 0 down vote favorite

I am trying to replace the words in a sentence using preg_replace_callback.

"%1% and %2% went up the %3%"

should become

"Jack and Jill went up the hill"

I have given my code below. 

<?php
  $values = array("Jack", "Jill", "hill");
  $line = "%1% and %2% went up the %3%";
  $line = preg_replace_callback(
    '/%(.*?)%/',
    create_function(
        // single quotes are essential here,
        // or alternative escape all $ as \$
        '$matches',
        'return $values[$matches[1]-1];'
    ),
    $line
  );
  echo $line;
?>

What I am getting is

" and went up the "

If I give return $matches[1]-1; , I am getting

"0 and 1 went up the 2"

Is it a scope issue ? How to make this working ? Any help would be appreciated.

share|improve this question

1 Answer 1

up vote 2 down vote accepted

It is indeed a scoping issue - your anonymous function created by create_function does not have access to $values.

This should work (>= PHP 5.3.0)

<?php
  $values = array("Jack", "Jill", "hill");
  $line = "%1% and %2% went up the %3%";
  // Define our callback here and import $values into its scope ...
  $callback = 
    function ($matches) use ($values)
    {
      return $values[$matches[1]-1];
    };

  $line = preg_replace_callback(
    '/%(.*?)%/',
    $callback, // Use it here.
    $line
  );
  echo $line;
?>

By declaring the callback function with use ($values), $values will be imported into its scope and available when it's called. This is the concept of a 'closure' over $values if you'd like to Google it further :).

Hope this helps.

share|improve this answer

Your Answer

 
discard

By posting your answer, you agree to the privacy policy and terms of service.

Not the answer you're looking for? Browse other questions tagged or ask your own question.