Any way of compacting this code?

Question

This is some of the code I have:

[window setLevel:kCGScreenSaverWindowLevel];
[window setOpaque:NO];
[window setStyleMask:0];
[window setBackgroundColor:[NSColor colorWithCalibratedWhite:0.0 alpha:0.3]];
[window setAlphaValue:0];

[window setFrame:[window frameRectForContentRect:[[window screen] frame]] display:YES animate:YES];

[window makeKeyAndOrderFront:self];
[[window animator] setAlphaValue:1.0];

I was just wondering if there was any way to compact it, all of those commands to my window. Any ways to improve it too?

Hack Saw · Accepted Answer · 2011-01-27 17:57:47Z

up vote 4 down vote accepted

This is a highly readable style, and simple. You might be able to make a loop and run through the list in some fashion, but it's unlikely to actually lower complexity, just shift it around a bit.

answered Jan 27 '11 at 17:57

Hack Saw
24015

It's just that for example in AppleScript (One of the first things I learnt) you can just do a 'tell' block... like "Tell myWindow" and then list all of the commands. It saves typing out 'window' over and over again – magikseb Jan 27 '11 at 18:04

Yeah, that'd be nice. – Hack Saw Jan 27 '11 at 18:22

Stuart · Answer 2 · 2011-01-27 17:43:53Z

up vote 2 down vote

Off the top of my head: can any of it be done in interface builder?

answered Jan 27 '11 at 17:43

Stuart
1813

Nope, I don't think so. – magikseb Jan 27 '11 at 18:02

5

I'm pretty sure a number of these properties can be set in IB. I think the meat of the question is do you actually need to create this window programatically, or could you load it from a NIB? – Hack Saw Jan 27 '11 at 18:24

Thomas · Answer 3 · 2012-02-12 19:43:58Z

If you are calling this code more than once, I would do this:

In the implementation file:

#import "ThisClass.h"

@interface ThisClass() {}
    - (void)doWindowStuff;

@end

@implementation ThisClass

- (void)doWindowStuff
{
    window.level = kCGScreenSaverWindowLevel;
    [window setOpaque:NO];
    window.styleMask = 0;
    window.backgroundColor = [NSColor colorWithCalibratedWhite:0.0 alpha:0.3];
    window.alphaValue = 0;

    [window setFrame:[window frameRectForContentRect:window.screen.frame] display:YES animate:YES];

    [window makeKeyAndOrderFront:self];
    [window.animator setAlphaValue:1.0];
}

- (void)someOtherMethods
{
    // other code
    [self doWindowStuff];
}

Note: (from experience) beware interface builder... setting some things in IB can make code harder to troubleshoot and/or read.

user859 · Answer 4 · 2011-01-27 18:15:41Z

up vote 0 down vote

Most Objective-C methods return the target object rather than void, so this might work:

[[[window setLevel:kCGScreenSaverWindowLevel] setOpaque:NO] setStyleMask:0];

and so on...

answered Jan 27 '11 at 18:15

user859

I tried that out but I get an error: "Void value not ignored as it ought to be. – magikseb Jan 27 '11 at 18:38

1

Probably doable - but it's horrible style IMO – Abizern May 28 '11 at 16:15

1

This is untrue. Setters always return void. – Adam Ko Aug 25 '11 at 6:01

Robert Höglund · Answer 5 · 2011-01-28 13:01:31Z

Depending on how you feel about the use of Objective-C 2.0 properties you can you can:

window.level = kCGScreenSaverWindowLevel;
[window setOpaque:NO];
window.styleMask = 0;
window.backgroundColor = [NSColor colorWithCalibratedWhite:0.0 alpha:0.3];
window.alphaValue = 0;

[window setFrame:[window frameRectForContentRect:window.screen.frame] display:YES animate:YES];

[window makeKeyAndOrderFront:self];
[window.animator setAlphaValue:1.0];

I had programmed in C# for many years before taking up Objective-C and I still find the bracket notation hard to read at times. For my own readability I would would also introduce a variable for the new frame.

NSRect newFrame = [window frameRectForContentRect:window.screen.frame];
[window setFrame:newFrame display:YES animate:YES];

asked	2 years ago
viewed	573 times
active	1 year ago

Any way of compacting this code?

5 Answers

Your Answer

Not the answer you're looking for? Browse other questions tagged objective-c or ask your own question.

Any way of compacting this code?

5 Answers

Your Answer

Sign up or login

Post as a guest

Not the answer you're looking for? Browse other questions tagged objective-c or ask your own question.

Related