current community

your communities

more stack exchange communities

Stack Exchange
tour help
careers 2.0
Take the 2-minute tour ×
Stack Overflow is a question and answer site for professional and enthusiast programmers. It's 100% free, no registration required.
up vote -3 down vote favorite

I have 3 options and I want to automatically select the option given by a js function.

<script type="text/javascript">
function makeOption(id){
   $("#category-list").val(id);
}
</script>

...

<select name="category" id="category-list">
   <option value="1">FIRST</option>
   <option value="2">SECOND</option>
   <option value="3">THIRD</option>
</select>

<script>makeOption('<?php echo $_GET["id"];?>')</script>

I don't know why it's not working.

share|improve this question
    
What does "not working" mean? What does your generated HTML look like? –  j08691 Aug 13 '12 at 17:05
    
Where does function makeOption(id){ appear in your page? –  j08691 Aug 13 '12 at 17:15

2 Answers 2

up vote 2 down vote accepted

Change this:

<script>makeOption('<?php echo $_GET['id'];?>')</script>

to:

<script type='text/javascript'>makeOption('<?php echo $_GET["id"];?>')</script>;

Try putting the codes inside the $(document).ready() handler:

<script type="text/javascript">
    $(document).ready(function(){
       function makeOption(id){
           $("#category-list").val(id);
       }
       makeOption('<?php echo $_GET["id"];?>')
    })
</script>
share|improve this answer
1  
I don' think this matters here since the PHP will be processed by the server first and then the resultant code sent to the browser without any quote issues. –  j08691 Aug 13 '12 at 17:04
    
I want to automatically select the option based on the $_GET['id'] variable. Accidentally I mistyped the code, because I rewrited here, when I made the question. I alerted id with js, and the id it's good. –  Reteras Remus Aug 13 '12 at 17:12
    
@ReterasRemus Try the updated answer. –  undefined Aug 13 '12 at 17:17
    
It's working Raminson, but I can't use $(document).ready(function(){}); I must use a function to make this change. –  Reteras Remus Aug 13 '12 at 17:28
    
@ReterasRemus Why? You can define the function outside of the document ready and call it inside the ready handler, try this: $(document).ready(function(){ makeOption('<?php echo $_GET["id"];?>') }) –  undefined Aug 13 '12 at 17:33
up vote 0 down vote

Rather than setting the value of the select, set one of the options to be selected.

Replace this

function makeOption(id) {
    $("#category-list").val(id);
}

with this

function makeOption(id) {
    $($("#category-list option")[id]).attr('selected', 'selected');
}
share|improve this answer
    
i50.tinypic.com/35dahj5.png –  Reteras Remus Aug 13 '12 at 17:20
    
Small oversight on my part. I've fixed it. –  Jim Aug 13 '12 at 17:26
    
The original version returned a DOM element rather than a jQuery object. Selecting it again with jQuery allows you to use jQuery's attr method –  Jim Aug 13 '12 at 17:27

Your Answer

 
discard

By posting your answer, you agree to the privacy policy and terms of service.

Not the answer you're looking for? Browse other questions tagged or ask your own question.