current community

your communities

more stack exchange communities

Stack Exchange
tour help
careers 2.0
Take the 2-minute tour ×
Stack Overflow is a question and answer site for professional and enthusiast programmers. It's 100% free, no registration required.
up vote 0 down vote favorite

Can anyone help me find the errors in this piece of code. When I try running it it says there is an unexpected ';' on line 10 but I'm not sure where this would be. Thanks ` 

$lines = array (
    0=>'Once upon a time',
    1=>'There lived a small green frog that lived',
    2=>'on a lilypad in a pond. ',
    3=>'One day a princess came along and kissed it.'
);

$max = count($lines) ;
$out = null ;
while ($i = 0; $i<$max;  $i++) {
    $opentag = '' ;
    $closetag = '' ;

    if ($i = 0) {
        $opentag = '<h1>' ;
        $closetag = '</h1>' ;
    }
    if ($i = 1 )     {
        $opentag = '<p>' ;
    }
    if ($i = ($max-1) )     {
        $closetag = '</p>' ;
    }

    $out = $opentag . $lines[$i] $closetag  ;

}
echo $out ;

?>`
share|improve this question

closed as off-topic by nickb, andrewsi, brasofilo, legoscia, Michael Berkowski Mar 13 at 0:59

This question appears to be off-topic. The users who voted to close gave this specific reason:

  • "This question was caused by a problem that can no longer be reproduced or a simple typographical error. While similar questions may be on-topic here, this one was resolved in a manner unlikely to help future readers. This can often be avoided by identifying and closely inspecting the shortest program necessary to reproduce the problem before posting." – brasofilo, legoscia, Michael Berkowski
If this question can be reworded to fit the rules in the help center, please edit the question.
1  
while loop??? –  Bhuvan Rikka 웃 Jan 29 '13 at 4:15

3 Answers 3

up vote 1 down vote

Seems that there are too many errors / mistakes in your code.

Firstly make it For loop instead while.

Than you missing . in below line,

$out = $opentag . $lines[$i] . $closetag;
                             ^

Also you are doing wrong in your all conditions for it should be like,

if ($i == 0) {

It should be == & not just =.

share|improve this answer
    
OP, make sure you correct all of the if statements to include double equal signs, not just the one mentioned. –  Jonathan Jan 29 '13 at 4:18
up vote 0 down vote

this is wrong :

while ($i = 0; $i<$max;  $i++) {

Please check the while syntax. I think you need to use for there.

for($i = 0; $i<$max;  $i++) {
share|improve this answer
up vote 2 down vote

There are multiple errors in the above code:

Firstly, you are using for conditions in a while loop, so you need to use:

for ($i = 0; $i<$max;  $i++) {
}

And nextly, on this line:

$out = $opentag . $lines[$i] $closetag  ;

You are missing a . between $lines[$i] and $closetag

You are also using incorrect operators in your if statements.

== Compare statements, return true if equal, return false if not equal.

= Set left side to equal right side

if($i = 1){}

The above will return true while setting $i to the value of 1.

share|improve this answer

Not the answer you're looking for? Browse other questions tagged or ask your own question.