Take the 2-minute tour ×
Programmers Stack Exchange is a question and answer site for professional programmers interested in conceptual questions about software development. It's 100% free, no registration required.

I have following requirement and I am trying to design class diagram. This is the first time I am creating class diagram so I would like to get some advice from experts.. :)

This is a simple login functionality implementation using mvc.

enter image description here

I have a login controller that take login and logout request from the view. It uses security module class to authenticate users, check if the user already logged in or not and holds the list of logged in users.

Would you consider this as a valid approach? and also if you can point out the room for improvement, I would really appreciate. Thanks.. :)

share|improve this question
    
It looks like a valid approach. The only thing I am missing are some methods in SecurityModule to manipulate the list of logged in users. –  Bart van Ingen Schenau yesterday
add comment

Your Answer

 
discard

By posting your answer, you agree to the privacy policy and terms of service.

Browse other questions tagged or ask your own question.