current community

your communities

more stack exchange communities

Stack Exchange
tour help
stack overflow careers
Take the 2-minute tour ×
Stack Overflow is a question and answer site for professional and enthusiast programmers. It's 100% free, no registration required.
up vote 3 down vote favorite
1

Hey Guys i have a little issue of JavaScript and i don't know how to solve this Query that why i put this Question in stackoverflow also helps are definitely appreciated

I am getting the error missing ) after argument list in my Firebug console.

emissing ) after argument

My Question is how to pass $char_data variable in JavaScript function as a argument

Define php variable 

<?php 
$chart_data = "['NBA',1],['NFL',2],['MLB',3],['NHL',4]"; 
$div = "graph";
?

Call Javascript function with define argument

<script>
dynamicChartArray('<?php echo $div;?>','<?php echo $chartdata;?>')
</script>

A function of javascrpit

<script>
function dynamicChartArray(div,chartdata){
var myData = new Array(chartdata);
var myChart = new JSChart(div, 'pie');
alert(chartdata+div);
}
<script>
share|improve this question
    
See my updates with screeshot –  Query Master Mar 19 '12 at 19:38
    
i was tried all of thing but the error missing ) after argument list in my Firebug console. –  Query Master Mar 19 '12 at 19:51
    
Guyz Help me out –  Query Master Mar 19 '12 at 19:52

7 Answers 7

up vote 2 down vote accepted

Rather than creating an array out of a string in javascript, why not just just get the PHP to output it as an array to start with?

Just add an extra set of [] which javascript reads as an array.

$chart_data = "[['NBA',1],['NFL',2],['MLB',3],['NHL',4]]";

then ditch the quotes on the output (which are responsible for causing the error messages)

 dynamicChartArray('<?php echo $div;?>', <?php echo $chartdata;?>);

and then myData can just equal chart data (since its already an array)

var myData = chartdata;
share|improve this answer
1  
The code works fine in my console? Would you be able to add the javascript code that is being output by PHP (and is causing the error) to your posts at all? It may simply be that one of your values has a problem, for example if one of the values in quotes was "O'Neil" it would need escaping in order to stop it breaking the javascript. –  Carl Mar 19 '12 at 20:28
    
Thanx for sharing your experience with me –  Query Master Mar 19 '12 at 20:32
up vote 1 down vote

change this:

dynamicChartArray('<?php echo $div;?>','<?php echo $chartdata;?>')

to this:

dynamicChartArray('<?php echo $div;?>', [<?php echo $chart_data;?>]);

and see if it works

share|improve this answer
    
yeah, i figured. sorry! –  Vlad Balmos Mar 19 '12 at 19:36
up vote 2 down vote

Instead of 

$chart_data = "['NBA',1],['NFL',2],['MLB',3],['NHL',4]";

Use

$chart_data = "[\"NBA\",1],[\"NFL\",2],[\"MLB\",3],[\"NHL\",4]";

Change your call to this:

dynamicChartArray('<?php echo $div;?>',[<?php echo $chartdata;?>])

And function to this:

function dynamicChartArray(div,chartdata){
var myData = chartdata;
var myChart = new JSChart(div, 'pie');
alert(chartdata+div);
}
share|improve this answer
    
how to change my char_data to like this actually this chart_data contain dynamic value –  Query Master Mar 19 '12 at 19:20
    
create string from your dynamic values –  Engineer Mar 19 '12 at 19:24
up vote 2 down vote 
'<?php echo $chartdata;?>'

This is going to echo '['NBA',1],['NFL',2],['MLB',3],['NHL',4]'. Note how there are single quotes inside the single quotes.

 new Array(chartdata)

This will just make an array, with one element, the string "['NBA',1],['NFL',2],['MLB',3],['NHL',4]".

Try doing dynamicChartArray('<?php echo $div;?>',[<?php echo $chartdata;?>])

This will make chartdata an array of arrays.

share|improve this answer
up vote 1 down vote

You dont need var myData = new Array(chartdata);.

chartdata is already an array.

share|improve this answer
    
@Samad, simply pass chartdata where it needs to be sent. –  Starx Mar 19 '12 at 19:27
    
@Samad, simple pass chartdata where it needs to be sent. –  Starx Mar 19 '12 at 19:28
up vote 1 down vote

Take a look at json_encode.

$chart_data = json_encode(array(array('NBA',1),array('NFL',2)));

which will produce a json string ready to echo into your script

string(21) "[["NBA",1],["NFL",2]]"
share|improve this answer
up vote 1 down vote

You should have a look at the output. I bet it is: 

dynamicChartArray('graph','['NBA',1],['NFL',2],['MLB',3],['NHL',4]')

and you can already see that you have problems with the quotes.

Instead of creating a string, I suggest to create an array and use json_encode:

$chart_data = array(
    array('NBA',1),
    array('NFL',2),
    array('MLB',3),
    array('NHL',4)
);

and

dynamicChartArray('<?php echo $div;?>', <?php echo json_encode($chartdata); ?>)

JSON happens to be valid JavaScript as well and it gives you more possibilities to process the data on the server side.

share|improve this answer

Your Answer

 
discard

By posting your answer, you agree to the privacy policy and terms of service.

Not the answer you're looking for? Browse other questions tagged or ask your own question.