current community

your communities

more stack exchange communities

Stack Exchange
tour help
careers 2.0
Take the 2-minute tour ×
Stack Overflow is a question and answer site for professional and enthusiast programmers. It's 100% free, no registration required.
up vote 8 down vote favorite
4
 
ArrayList<String> newArray = new ArrayList<String>();
    newArray = urlList.getUrl();
    for( int i = 0 ; i < newArray.size();i++)
    {
        System.out.println(newArray.get(i));
    }

    newArray.toArray(mStrings );// is this correct 
    mStrings = newArray.toArray();//  or this to convert ArrayList ot String array here

    for( int i = 0 ; i < mStrings.length;i++)
    {
        System.out.println(mStrings[i]);
    }



edit: when i try as below , i get null pointer exception

try
        {
                newArray.toArray(mStrings );
                for( int i = 0 ; i < mStrings.length;i++)
                {
                    System.out.println(mStrings[i]);
                }
        }catch( NullPointerException e )
        {
            System.out.println(e);
        }
share|improve this question
    
can you please include the full code block in the edited area so we can see the initialisation? –  laura Mar 5 '11 at 8:30
    
and also tell us which line the exception is thrown at –  laura Mar 5 '11 at 8:31

5 Answers 5

up vote 13 down vote accepted

Depends on what you want to do. Both are correct

toArray() Returns an array containing all of the elements in this list in proper sequence (from first to last element).

Refer here

toArray(T[] a) Returns an array containing all of the elements in this list in proper sequence (from first to last element); the runtime type of the returned array is that of the specified array. If the list fits in the specified array, it is returned therein. Otherwise, a new array is allocated with the runtime type of the specified array and the size of this list.

Refer here

In former, you want to get an array. In latter you have an array, you just wanted to fill it up.

In your case, first form is preferred as you just want to get an array without bothering size or details.

Basically this is what happens in 2nd case:

  1. List's size is measures.
  2. (a) If list size is less than that of the array provided, new Array of the type provided as argument is created.

    (b)Else, the list is dumped in the specified array.

The only benefit of doing so, is you avoid casting. The two form are the same. If you use Object array. i.e.

     myList.toArray() <==> toArray(new Object[0])

Now, If you pass an uninitialized array, you will get a NullPointerException. The best way to do it is:

 String[] y = x.toArray(new String[0]);

Please read the document

share|improve this answer
    
try { newArray.toArray(mStrings ); }catch( NullPointerException e ) { System.out.println(e); } i get nullpointer exception here –  pradeep Mar 5 '11 at 7:27
    
String[] y = x.toArray(new String[0]); this worked –  pradeep Mar 5 '11 at 8:31
up vote 16 down vote

Usually I write

String[] array = collection.toArray(new String[collection.size()]);

because this way

  1. I get an array of the type that I want.
  2. I don't have to declare the array before calling Collection.toArray(T[]).
share|improve this answer
    
Please explain #2. –  cdunn2001 Sep 29 '11 at 15:39
4  
Point 2 is in contrast to something like String[] array = new String[collection.size()]; array = collection.toArray(array);. Other answers suggest new String[0], which is okay, but creates an extra temporary object. –  rlibby Sep 29 '11 at 23:35
up vote 3 down vote

The first option is better as it allows you to pass in a typed array, which is then populated inside the method.

The second option returns an Object[] - so you would have to cast it to use String methods.

share|improve this answer
    
try { newArray.toArray(mStrings ); for( int i = 0 ; i < mStrings.length;i++) { System.out.println(mStrings[i]); } }catch( NullPointerException e ) { System.out.println(e); } i get nullPointer exception here –  pradeep Mar 5 '11 at 7:30
    
you could try asList() instead of toArray if you want an ArrayList - or declare newarray as new String[mstring.size()] –  laura Mar 5 '11 at 7:34
    
@rajivpradeep, Collection.toArray() throws a NullPointerException if you pass it a null reference. –  rlibby Mar 5 '11 at 7:45
up vote 2 down vote

In plain java i'm use something like

rolesList.toArray(new Integer[rolesList.size()]);

for converting list to array. Don't know in android.

share|improve this answer
up vote 1 down vote

How about this 

 List a = new ArrayList();
   a.add("wer");
   a.add("sff");
   String[] f= (String[]) a.toArray(new String[0]);
   System.out.println(f[0]);
share|improve this answer

Your Answer

 
discard

By posting your answer, you agree to the privacy policy and terms of service.

Not the answer you're looking for? Browse other questions tagged or ask your own question.