current community

your communities

more stack exchange communities

Stack Exchange
tour help
Take the 2-minute tour ×
Code Review Stack Exchange is a question and answer site for peer programmer code reviews. It's 100% free, no registration required.
up vote 2 down vote favorite

I currently use this code pattern fairly frequently

if(array_key_exists('possible_key', $array)) {
    $my_variable = $array['possible_key'];
} else {
    $my_variable = 'my default value';
}

Is there a better way to be writing this?

share|improve this question

5 Answers 5

up vote 3 down vote accepted

One quick change you can do is making use of ternary operator instead of writing if else block.

$my_variable = array_key_exists('possible_key', $array) 
               ? $array['possible_key'] 
               : 'my default value';
share|improve this answer
1  
Never thought of using multiple lines with the ternary operator before, though I can see how this would be a very long line otherwise (and it does seem more readable like this). Is it considered a best practice to do this? –  Ben Zittlau Oct 30 '12 at 17:33
    
Side note: What's the difference between array_key_exists('possible_key', $array) and isset($array['possible_key'])? –  Joseph Silber Oct 31 '12 at 1:44
1  
@JosephSilber $array['possible_key'] = null; isset($array['possible_key']); /* false */ array_key_exists('possible_key', $array); /* true */ –  Corbin Oct 31 '12 at 3:01
up vote 1 down vote 
class ArrayHelper {

    public static function KeyExists($source, $key) {
        return isset($source[$key]) || array_key_exists($key, $source);
    }

    public static function GetValueOrDefault($source, $key, $default) {
        return self::KeyExists($source, $key) ? $source[$key] : $default;
    }

}

This is from my library it's similar to the other solutions but it's using a little hack: the array_key_exists() is a slow function so i execute first an isset() 'function' and if it's says "yes, it exists" then i don't have to execute the array_key_exists() function. The reason why isset() is not enough is the isset() will return FALSE if the key exists but the value is NULL.

share|improve this answer
    
That's rather expensive don't you think? Calling up to 4 functions (ArrayHelper::GetValueOrDefault(), ArrayHelper::KeyExists(), isset(), array_key_exists) rather than a ternary calling 1 function (array_key_exists). –  jsanc623 Oct 30 '12 at 23:09
    
The isset in KeyExists is redundant. isset being true is sufficient for array_key_exists to be true. (Not the inverse though -- your method could consist of only the array_key_exists call and have the same functionality. If it consisted of only the isset call, it would not have the same functionality.) Basically your function now is (a and b) or a (where a = does the key exist and b = the value is not null). –  Corbin Oct 31 '12 at 3:11
    
Hrmm, apparently managed to not read your paragraph explaining why you used isset and array_key_exists earlier. I suppose my previous comment should be ignored. I do think you're way over thinking performance though. If an array_key_exists call is even close to being a bottleneck of an application, something is seriously wrong. –  Corbin Oct 31 '12 at 4:54
1  
@jsanc623: no it's not. Using your solution will request more memory for the PHP becouse of the ternary operator. When checking something with ternary operator in an array (isset() or anything else) the PHP will copy the full array before executing the checking. –  Peter Kiss Oct 31 '12 at 7:08
up vote 1 down vote

I would prefer to keep it simple and not to use if else. Just assign it the default value, and change only when the condition meets.

$my_variable = 'my default value';
if(array_key_exists('possible_key', $array)) $my_variable = $array['possible_key'];
share|improve this answer
up vote 0 down vote

Untested code here as I don't have access to my dev machine, but taking Sky's ternary suggestion above and simplifying it (one empty() call is faster than an array_key_exists (see http://stackoverflow.com/questions/6884609/array-key-existskey-array-vs-emptyarraykey)

$var = empty($array['possible_key']) ? 'default value' : $array['possible_key'];
share|improve this answer
1  
If $array['possible_key'] is set to '' or 0, this'll return 'default value'. –  Joseph Silber Oct 31 '12 at 1:45
1  
"one empty() call is faster than an array_key_exists" Correct functionality is a lot more important than performance (in this context, though also usually in general). But yes, if he's willing to ignore values containing 0, empty, '0', etc, this is shorter and a tiny bit faster. (isset would probably be a better fit here than empty by the way. isset has fewer false negatives in this context.) –  Corbin Oct 31 '12 at 3:05
    
Ah...true guys....woops –  jsanc623 Oct 31 '12 at 3:49
up vote -3 down vote

I prefer to use use isset and make little refactor and wrap that code to function/method

function defaultize( $array_var ,$defaul_val ){
 if(isset($array_var)) {
    $ret = $array_var;
 } else {
    $ret = 'my default value';
 }
 return $ret;
}

and then use in code

$my_variable = defaultize($array['possible_key'],'my default_value' );
$my_variable2 = defaultize($array['possible_key2'],'my default_value2' );
share|improve this answer
1  
defaultize($array['possible_key'],'my default_value' ); <-- if 'possible_key' dows not exists the PHP will throw an E_NOTICE warning and your function body is messed up. –  Peter Kiss Oct 30 '12 at 18:52
    
$array seem uninitialized inside the function. –  palacsint Oct 30 '12 at 18:52
    
Ups, sorry just fixed that –  Lacoz Oct 30 '12 at 19:23

Your Answer

 
discard

By posting your answer, you agree to the privacy policy and terms of service.

Not the answer you're looking for? Browse other questions tagged or ask your own question.