current community

your communities

more stack exchange communities

Stack Exchange
tour help
stack overflow careers
Take the 2-minute tour ×
Stack Overflow is a question and answer site for professional and enthusiast programmers. It's 100% free, no registration required.
up vote 3 down vote favorite
1

For the last 1 1/2 days I've been trying to store 16 row id's into a string and separate each id with a comma. The array I am getting is from MySQL. The error I am getting is "implode() function:passed invalid arguments"

$str=array();
$string="";
while($row = mysql_fetch_row($result)) 
{
    $user_id=$row;
    $str=$user_id;
    foreach($str as $p=>$v){
        comma($v);
    }
}

function comma($v){
    $string= implode(",",$v); echo $string;
}
share|improve this question
2  
Please, stop being a bad guy and do not store comma-separated values into a unique field. Use another table and store each value into its own row. (You are creating problems that wouldn't exist if your shema was well structured.) –  OcuS Jul 22 '12 at 11:36
    
implode takes an array as a second parameter –  Leon Jul 22 '12 at 11:39
    
@oCuS I don't know if he's trying to "store comma-separated values into a unique field", he just says he want to store it into a string. –  Leon Jul 22 '12 at 11:43
    
@Leon: "I've been trying to store 16 row id's into a string and separate each id with a comma". It says enough to me. That's a bad design. Period. –  OcuS Jul 22 '12 at 11:45
2  
Also, you shouldn't be using the mysql_* functions, since they're a) insecure, and b) being deprecated (see the red box). You should be using prepared statements with PDO or MySQLi instead. –  Ricardo Altamirano Jul 22 '12 at 11:53

1 Answer 1

up vote 5 down vote accepted

Try something like this:

$ids=array(); 
while($row = mysql_fetch_assoc($result))  
{
    $ids[]=$row["UserID"]; 
} 
echo implode(", ", $ids);

Replace "UserID" with the columnname of the id in your table.

So: first you build the array, next you implode the array into a string.

share|improve this answer
    
cheers man!!!! got it now –  dll_onFire Jul 22 '12 at 11:55

Your Answer

 
discard

By posting your answer, you agree to the privacy policy and terms of service.

Not the answer you're looking for? Browse other questions tagged or ask your own question.