current community

your communities

more stack exchange communities

Stack Exchange
tour help
careers 2.0
Take the 2-minute tour ×
Stack Overflow is a question and answer site for professional and enthusiast programmers. It's 100% free, no registration required.
up vote 0 down vote favorite

I'm kind of new to Javascript. Any help or suggestion regarding below problem is highly appreciated.

I wanted to create an array which inturns contains list of objects. Given below code summarizes my problem 

{
    var Instrument = {};
    var InstrumentArray = new Array;
    var array = new Array;
    array[0] ="XYZ0";
    array[1] ="XYZ1";
    .
    .
    .
    array[n] ="XYZn" ;
    data1['Name'] = "X";
    data1['TypeString'] = "WatchList";
    data1['FileTypeString'] = "XLS";
    for (var i = 0; i < array.length; i++) {

        Instrument['Symbol'] = array[i];
        InstrumentArray.push(Instrument);
    }
    for(var j =0; j< InstrumentArray.length;j++)
     {
         console.log(InstrumentArray[j]);
     }

   }

When I look into the output via console.log it displays me the correct number of values but the Symbol: value it displays is the last one that I have entered in this case "XYZn".

I know that the last value overrides the Symbol Object but is their any way I can get all the values stored.

Thanks in Advance

share|improve this question
    
where was data1 declared? –  ggreiner Feb 14 '12 at 23:15

2 Answers 2

up vote 4 down vote accepted

It's because each element in the array InstrumentArray is a reference to same object Instrument, and you keep changing the properties of that one object. There are many things to improve in your code, but the short answer is to create Instrument inside the loop.

share|improve this answer
    
so how should I tackle it, I mean I need to have something like this Object { Symbol="XYZ0"} Object { Symbol="XYZ1"} ...... –  pranay vadel Feb 14 '12 at 23:18
    
Specifically, move the line var Instrument = {}; so that it's the first line in the loop. Or simply do InstrumentArray.push({Symbol : array[i]}). In terms of general Javascript programming I would read a good guide such as eloquentjavascript.net –  Mr E Feb 14 '12 at 23:20
    
Thanks I got you –  pranay vadel Feb 14 '12 at 23:22
up vote 1 down vote

In your code:

var Instrument = {};
var InstrumentArray = new Array;

While the formal parameter list can be omitted when calling a constructor with new, it is not a good idea as it might be misinterpreted as an assignment of Array rather than a new instance of Array. In any case, an array literal is likely a better choice (unambiguous, less to type):

var InstrumentArray = [];

Same for:

 var array = ["XYZ0", "XYZ1", ... "XYZn"]

In the following:

data1['Name'] = "X";
data1['TypeString'] = "WatchList";
data1['FileTypeString'] = "XLS";

data1 has not been declared or initialised, presumably it is an object (don't mix single and double quotes unless they are nested, it makes the code confusing) so a literal is likely better (same reasons as above):

var data1 = {'Name': 'X', 'TypeString': 'WatchList', 'FileTypeString': 'XLS'};

which is also a lot less to type.

 for (var i = 0; i < array.length; i++) {
      Instrument['Symbol'] = array[i];
      InstrumentArray.push(Instrument);
 }

Others have told you what is going on here, likely not what you want. Note that where property names comply with the rues for valid identifiers, dot notation can be used (which is a little more convenient):

      Instrument.Symbol = array[i];

Also, since you are adding members to an empty array using a counter, you can also do:

      InstrumentArray[i] = Instrument;

but of course they won't fix your issue, they are just different (better?) ways of doing the same thing.

share|improve this answer
    
thanks for the input, this definitely helps in writing meaningful js –  pranay vadel Feb 16 '12 at 0:42

Your Answer

 
discard

By posting your answer, you agree to the privacy policy and terms of service.

Not the answer you're looking for? Browse other questions tagged or ask your own question.