current community

your communities

more stack exchange communities

Stack Exchange
tour help
careers 2.0
Take the 2-minute tour ×
Stack Overflow is a question and answer site for professional and enthusiast programmers. It's 100% free, no registration required.
up vote 6 down vote favorite

So basically , I'd like to pass a PHP get variable from a link to Javascript so I can open a new smaller window with the appropriate content from the value passed to the URL .. I tried to do that below and I couldn't ... I'd really appreciate your assistance. The code below generates image hyperlinks that each have their ids from the database , so when the image is clicked on , a new window should be open but the ID should be passed to the javascript window.open method ... I tried to do that with AJAX to load the content according to the get variable but I couldn't do it !!

<?php
require('../database/connect.php');
database_connect();
$query = "select * from Entertainers";
$result = $connection->query($query);
$row_count =$result->num_rows;

for($i = 1; $i <= $row_count; $i++)
  {
   $row = $result->fetch_assoc();


?>
<?php  echo "<a href='' onclick='window.open(profile.php?id=".$row['ID'].")'><img src ='../".$row['Picture']."' width='100' height='100' /> </a>"; } ?>
share|improve this question
    
why not while($row = $result->fetch_assoc()){} ?? –  NullPoiиteя Dec 22 '12 at 4:44
    
the last matching curly brace is at the end of the script ..I'd like the window open with the passed in variable. –  Guy Rwayitare Dec 22 '12 at 4:45
add comment

2 Answers

up vote 2 down vote accepted

Don't forget to quote the url in the Javascript open function. Also, did you consider using printf() for outputting?

$link =
'<a href="" onclick="window.open(\'profile.php?id=%d\')">'
. '<img src="../%s" width="100" height="100" /></a>' . PHP_EOL;

for($i = 1; $i <= $row_count; $i++) {
    $row = $result->fetch_assoc();
    printf($link,$row['ID'],$row['Picture']);
}

%d represents a decimal and %s represents a string in the above string (hence the $link). Another tip: if you have no particular reason to use the for loop, using a while loop instead will make your code cleaner and shorter.

while ($row = $result->fetch_assoc()) {
    printf($link,$row['ID'],$row['Picture']);
}
share|improve this answer
    
YOU ARE A GENIUS.. THAANK YOU !!!! you really saved me .. How can I accept your answer ... I'd like us to keep in touch .. I am from Los Angeles , CA –  Guy Rwayitare Dec 22 '12 at 5:28
    
How can I make that opened window a with of 200 and 100 ?? –  Guy Rwayitare Dec 22 '12 at 5:31
    
how can I make that window a width of 100 and height of 200 .. a separated opened window ?? I'd like to have that effect from the code that you already gave to me .. –  Guy Rwayitare Dec 22 '12 at 5:38
    
@GuyRwayitare No problem. Most of the time we spend for debugging is caused by annoying typos or little syntax problems like these. You can accept an answer by the checkmark under the downvote arrow, on the left to the answer. Check here to see the available function parameters for the window.open function, which includes the window size. –  inhan Dec 22 '12 at 5:38
    
@GuyRwayitare I'll be here ;) and thanks for the vote. –  inhan Dec 22 '12 at 5:45
show 4 more comments
up vote 0 down vote

When your script renders the HTML on the page the URL parameter to window.open is not being rendered as a string.

What your code currently renders on the page:

<a href='' onclick='window.open(profile.php?id={some_id})'><img src ='../".$row['Picture']."' width='100' height='100' /> </a>"; } ?>

The URL profile.php?id={some_id} is not a string when it is being parsed at the client.

Try this:

<?php  echo "<a href='' onclick=\"window.open('profile.php?id=" . $row['ID'] . "');\"><img src ='../".$row['Picture']."' width='100' height='100' /> </a>"; ?>
share|improve this answer
    
that didn'work at all –  Guy Rwayitare Dec 22 '12 at 5:25
    
@GuyRwayitare That's strange. All I did was add quotes around your URL in the JS call. Are you getting any error? inhan's solution above is cleaner but it is essentially the same. –  Tanzeel Kazi Dec 22 '12 at 5:35
    
no error , the page just doesn't open .. –  Guy Rwayitare Dec 22 '12 at 5:46
    
@GuyRwayitare I hope you have used the code line in the context of your original code and not dumped that line on a new page because I left an ending curly brace in there that will cause issues. I'll modify the answer. –  Tanzeel Kazi Dec 22 '12 at 5:51
add comment

Your Answer

 
discard

By posting your answer, you agree to the privacy policy and terms of service.

Not the answer you're looking for? Browse other questions tagged or ask your own question.