I am working on a personal project for managing one's Pinboard bookmarks. Since this is already quite a big project, I am not sure if my question fits the guidelines. My main concern is with the complexity of one of my controllers. I have the feeling I should cut it into smaller controllers or directives, but I am not sure how I could best achieve this.
My project is here and my main concern is the `main.js controller in App/scripts/controllers. Because the project already is quite big and depends on numerous other packages and resources, I do not know how to provide a runnable version easily. However, the project should install / run / test / build when cloned from GH.
/**
* @ngdoc function
* @name pinboredWebkitApp.controller:MainCtrl
* @description
* # MainCtrl
* Controller of the pinboredWebkitApp
*/
angular.module('pinboredWebkitApp')
.controller('MainCtrl', function ($scope, $location, $filter, $modal, $q, $splash, $timeout,
Pinboardservice, Usersessionservice, Appstatusservice, Utilservice, Modalservice,
fulltextFilter, tagsFilter) {
// if not authenticated, redirect to login page
if (Usersessionservice.isAuthenticated() === false) {
$location.path('/login');
return;
}
// if logged off, redirect to login page as well
$scope.$on('user:authenticated', function() { // args: event, data
if(Usersessionservice.authenticated === false) {
$location.path('/login');
return;
}
});
// page model
$scope.data = {
loadType : 'recent',
isLoading : true,
activePage : 3,
items: [],
filteredList : [],
selectedItems : []
};
$scope.paging = {
numPageButtons : 10,
current : 1,
total : 0
};
$scope.filter = {
textFilterDelay : 750,
textFilterTimeout : null,
text : '',
tags : []
};
$scope.multiAction = {
show : false,
selectedAction : '',
dangerousAction : false,
newTagName : '',
foldTagName : ''
};
$scope.config = {
tagFilterType : false,
tagFilterTypeText : 'inclusive / and',
searchAllWords : false,
searchAllWordsText : 'search all words',
maxItems : 200,
maxTagSearch : 4,
itemsPerPage : 25,
showSearch : false,
showTags : false,
showPager : false,
showSelection : false
};
// BATCH SELECTION ACTIONS
$scope.selectionAddTag = function(newTagName) {
var total = $scope.data.selectedItems.length;
var updated = 0;
console.log('bookmarks to add tags to: ' + total);
if($scope.data.selectedItems.length > 0) {
for(var i=0; i<$scope.data.selectedItems.length; i++) {
// following is inside anonymous function closure because of loop iterator scope problem
(function(i, newTagName){
// set initial status to checking
$scope.data.selectedItems[i].data.tags += ' ' + newTagName;
// update bookmark
Pinboardservice.updateBookmark($scope.data.selectedItems[i])
.then(function(result) {
// var updatedBmHash = $scope.data.selectedItems[i]['data']['hash'];
var updatedBmHash = $scope.data.selectedItems[i].data.hash;
updated++;
if(result.result_code === 'done') {
Appstatusservice.updateStatus('updated bookmark: ' + updatedBmHash + '.', updated, total);
} else {
Appstatusservice.updateStatus('Failed: ' + result.result_code + '.', updated, total, 'danger');
}
}, function(reason) {
Appstatusservice.updateStatus('Failed: ' + reason, updated, total, 'danger');
});
})(i, newTagName);
}
}
};
$scope.selectionDeleteAllTags = function() {
var total = $scope.data.selectedItems.length;
var updated = 0;
console.log('bookmarks to delete all tags from: ' + total);
// delete all tagsfunction.
var deleteTagsFromNextBookmark = function(i) {
if($scope.data.selectedItems.length > 0 && updated !== total) {
// remove all tags from bookmark
$scope.data.selectedItems[i].data.tags = '';
Pinboardservice.updateBookmark($scope.data.selectedItems[i])
.then(function(result) {
if(result.result_code === 'done') {
// var updatedBmHash = $scope.data.selectedItems[i]['data']['hash'];
var updatedBmHash = $scope.data.selectedItems[i].data.hash;
updated++;
Appstatusservice.updateStatus('updated bookmark: ' + updatedBmHash + '.', updated, total);
// recursively delete all tags on next bookmark
if($scope.data.selectedItems.length > 0 && updated !== total) {
deleteTagsFromNextBookmark(i+1);
}
} else {
Appstatusservice.updateStatus('Failed: ' + result.result_code + '.', updated, total, 'danger');
}
}, function(reason) {
Appstatusservice.updateStatus('Failed: ' + reason, updated, total, 'danger');
});
} else {
Appstatusservice.updateStatus('done deleting all tags from all selected bookmarks.');
}
};
deleteTagsFromNextBookmark(0);
};
$scope.multiDeleteAllItems = function() {
Modalservice.confirm('', 'Delete selected bookmarks ? <br/>This request can not be cancelled when started!')
.then(function() {
var total = $scope.data.selectedItems.length;
var deleted = 0;
console.log('bookmarks to delete: ' + total);
// RECURSIVE delete single bookmark function.
var deleteNextBookmark = function() {
if($scope.data.selectedItems.length > 0 && deleted !== total) {
Pinboardservice.deleteBookmark($scope.data.selectedItems[0].data.href)
.then(function(result) {
if(result.result_code === 'done') {
// var deletionBmHash = $scope.data.selectedItems[0]['data']['hash'];
var deletionBmHash = $scope.data.selectedItems[0].data.hash;
deleted++;
Appstatusservice.updateStatus('deleted bookmark, hash: ' + deletionBmHash + '.', deleted, total);
// remove from scope list
Utilservice.removeItemFromCollection('hash', deletionBmHash, $scope.data.selectedItems);
Utilservice.removeItemFromCollection('hash', deletionBmHash, $scope.data.items);
// recursively delete next bookmark
if($scope.data.selectedItems.length > 0 && deleted !== total) {
deleteNextBookmark();
}
}
}, function(reason) {
Appstatusservice.updateStatus('Failed: ' + reason, deleted, total, 'danger');
});
} else {
Appstatusservice.updateStatus('done deleting all selected bookmarks.');
}
};
// delete the first bookmark and start recursion
deleteNextBookmark();
}, function(){
console.log('modal cancelled.');
});
};
$scope.multiDeleteAllTags = function() {
Modalservice.confirm('', 'Delete all tags on selected bookmarks ? \nThis request can not be cancelled when started!')
.then(function(){
// code moved into function so other batch functions may use it
$scope.selectionDeleteAllTags();
}, function(){
console.log('modal cancelled.');
});
};
$scope.multiStaleCheck = function() {
var total = $scope.data.selectedItems.length;
var checked = 0;
console.log('bookmarks to stale check: ' + total);
if($scope.data.selectedItems.length > 0) {
for(var i=0; i<$scope.data.selectedItems.length; i++) {
// following is inside anonymous function closure because of loop iterator scope problem
(function(i){
// set initial status to checking
$scope.data.selectedItems[i].status.staleness = 'checking';
// perform the check url request
Pinboardservice.checkUrl($scope.data.selectedItems[i].data.href)
.then(function(result) {
var checkedBmHash = $scope.data.selectedItems[i].data.hash;
checked++;
if(result === 200) {
Appstatusservice.updateStatus('checked bookmark is healthy: ' + checkedBmHash + '.', checked, total);
$scope.data.selectedItems[i].status.staleness = 'healthy';
} else {
Appstatusservice.updateStatus('checked bookmark is stale: ' + checkedBmHash + '.', checked, total);
$scope.data.selectedItems[i].status.staleness = 'dead';
}
if(checked === total) {
Appstatusservice.updateStatus('done stale checking all selected bookmarks.');
}
}, function(reason) {
Appstatusservice.updateStatus('Failed: ' + reason, checked, total, 'danger');
$scope.data.selectedItems[i].status.staleness = 'unknown';
});
})(i);
}
}
};
$scope.multiFoldIntoTag = function() {
// first check for tag input
if(!Utilservice.isEmpty($scope.multiAction.foldTagName)) {
Modalservice.confirm('', 'Fold existing tags into <br/><span class="modal-tag-highlight">' + $scope.multiAction.foldTagName + '</span> ? <br/>This request can not be cancelled when started!')
.then(function() {
// first batch delete all tags from selected bookmarks
$scope.selectionDeleteAllTags();
// then add a new tag
$scope.selectionAddTag($scope.multiAction.foldTagName);
}, function() {
});
} else {
Modalservice.alert('', 'no new tag name was given!');
}
};
$scope.multiAddTag = function() {
// first check for tag input
if(!Utilservice.isEmpty($scope.multiAction.newTagName)) {
Modalservice.confirm('', 'Add tag <br/><span class="modal-tag-highlight">' + $scope.multiAction.newTagName + '</span><br/> to selected bookmarks ? <br/>This request can not be cancelled when started!')
.then(function() {
// code moved into function so other batch functions may use it
$scope.selectionAddTag($scope.multiAction.newTagName);
}, function() {
console.log('modal cancelled.');
});
} else {
Modalservice.alert('', 'no new tag name was given!');
}
};
$scope.changeMultiAction = function() {
if($scope.multiAction.selectedAction === '') {
$scope.multiAction.show = false;
} else {
$scope.multiAction.show = true;
switch($scope.multiAction.selectedAction) {
case 'deleteAllItems':
case 'deleteAllTags':
$scope.multiAction.dangerousAction = true;
break;
default:
$scope.multiAction.dangerousAction = false;
}
}
};
$scope.executeMultiAction = function() {
console.log('executing action: ' + $scope.multiAction.selectedAction);
if(!Utilservice.isEmpty($scope.multiAction.selectedAction)) {
// new method:
console.log('method call: ' + 'multi' + Utilservice.capitalize($scope.multiAction.selectedAction));
$scope['multi' + Utilservice.capitalize($scope.multiAction.selectedAction)]();
}
};
// BOOKMARK (RE)LOADING
$scope.reload = function() {
// set some stuff
$scope.data.isLoading = true;
$scope.data.items = [];
$scope.filteredList = [];
$scope.paging.current = 1;
$scope.paging.total = 0;
$scope.cancelCurrentOperations();
var loader = function(loadType, args) {
if(loadType === 'recent') {
// get recent bookmarks
return Pinboardservice.getRecentBookmarks(args);
}
if(loadType === 'all') {
// get all bookmarks
return Pinboardservice.getAllBookmarks(args);
}
};
loader($scope.data.loadType, $scope.config.maxItems).then(function(result) {
$scope.data.isLoading = false;
$scope.createBookmarks(result);
$scope.updateFiltersPaging();
Appstatusservice.updateStatus($scope.data.loadType +' bookmarks loaded.');
}, function(reason) {
console.error('Failed: ' + reason);
Appstatusservice.updateStatus($scope.data.loadType +' bookmarks failed to load.');
});
};
$scope.repopulateBookmarks = function() {
if($scope.data.items.length === 0) {
// console.log('checking if stored bookmark set exists...');
// check if they are cached in service.
var isEmpty = (Object.keys(Usersessionservice.storedBookmarks).length) === 0 ? true : false;
// console.log("are cached bookmarks empty? " + isEmpty);
if(!isEmpty) {
// console.log('cached bookmarks exist.');
if(Usersessionservice.storedBookmarks.length > 0) {
Appstatusservice.updateStatus('retrieving cached bookmarks...');
$scope.data.isLoading = false;
$scope.createBookmarks(Usersessionservice.storedBookmarks);
$scope.updateFiltersPaging();
Appstatusservice.updateStatus('cached bookmarks retrieved.');
}
} else {
// request recent bookmarks if there are none loaded yet.
$scope.reload();
}
}
};
$scope.createBookmarks = function(pinboardData) {
// console.info(pinboardData);
var bookmarks = [];
for(var i=0; i<pinboardData.length; i++) {
var bmdata = pinboardData[i];
var bookMark = {
status: {
selected : false,
showEdit : false,
hasChanged : false,
staleness : 'unknown'
},
data: bmdata
};
bookmarks.push(bookMark);
}
// console.info(bookmarks);
// cache bookmarks in usersession
Usersessionservice.storeBookmarks(pinboardData);
// and store in scope
$scope.data.items = bookmarks;
};
// PAGING AND FILTERS
$scope.checkMaxTags = function() {
if($scope.filter.tags.length > $scope.config.maxTagSearch) {
// remove tag, one too many
$scope.filter.tags.splice($scope.filter.tags.indexOf($scope.filter.tags[$scope.filter.tags.length-1]), 1);
}
};
$scope.onTagAdded = function (tag) {
$scope.checkMaxTags(tag);
$scope.updateFiltersPaging();
};
$scope.onTagRemoved = function () {
$scope.updateFiltersPaging();
};
$scope.updateFiltersPaging = function() {
// if the textFilterPromise exists, cancel it:
if($scope.filter.textFilterTimeout !== null) {
$timeout.cancel($scope.filter.textFilterTimeout);
}
// create new $timeout promise to apply filters and update the paging
$scope.filter.textFilterTimeout = $timeout(function() {
$scope.applyFilters();
$scope.updatePaging();
}, $scope.filter.textFilterDelay);
};
$scope.updatePaging = function() {
$scope.paging.total = Math.min($scope.data.items.length, $scope.data.filteredList.length);
console.log('paging total: ' + $scope.paging.total);
};
$scope.applyFilters = function() {
// console.log('applying filters to list...');
var word = $scope.filter.text;
var tags = $scope.filter.tags;
var logicType = ($scope.config.tagFilterType === true) ? 'AND' : 'OR';
$scope.data.filteredList = fulltextFilter($scope.data.items, word);
$scope.data.filteredList = tagsFilter($scope.data.filteredList, tags, logicType);
};
// INDIVIDUAL BOOKMARK OPERATIONS
$scope.deleteBookmark = function (bookmarkItem) {
var responseFailed = function(message) {
Appstatusservice.updateStatus('Failed to delete bookmark: ' + message + '.', 0, 0, 'danger');
};
Pinboardservice.deleteBookmark(bookmarkItem.data.href)
.then(function(result) {
if(result.result_code === 'done') {
console.log('delete request completed.');
Utilservice.removeItemFromCollection('hash', bookmarkItem.data.hash, $scope.data.items);
Appstatusservice.updateStatus('deleted bookmark, hash: ' + bookmarkItem.data.hash + '.');
} else {
responseFailed(result);
}
}, function(reason) {
responseFailed(reason);
});
};
$scope.staleCheckBookmark = function(bookmark) {
bookmark.status.staleness = 'checking';
Pinboardservice.checkUrl(bookmark.data.href)
.then(function(result) {
if(result === 200) {
console.info('bookmarkitem healthy! ' + result);
bookmark.status.staleness = 'healthy';
} else {
console.info('bookmarkitem STALE! ' + result);
bookmark.status.staleness = 'dead';
}
}, function(reason) {
console.info('bookmarkitem STALE! ' + reason);
bookmark.status.staleness = 'dead';
});
};
// EOF INDIVIDUAL BOOKMARK OPERATIONS
$scope.clearSelectedItems = function() {
if($scope.data.selectedItems.length > 0) {
for(var i=0; i<$scope.data.selectedItems; i++) {
$scope.data.selectedItems[i].status.selected = false;
}
}
$scope.data.selectedItems = [];
};
$scope.cancelCurrentOperations = function(exception) {
$scope.multiAction.selectedAction = '';
// first, de-highlight and fold all items
if($scope.data.items.length > 0) {
for(var i=0; i<$scope.data.items.length; i++) {
if($scope.data.items[i] !== exception) {
$scope.data.items[i].status.selected = false;
$scope.data.items[i].status.showEdit = false;
// $scope.data.items[i].status.hasChanged = false;
}
}
}
// then, clear currently selected items
$scope.data.selectedItems = [];
// hide multi action bar
$scope.multiAction.selectedAction = '';
$scope.multiAction.show = false;
};
// SETUP AND INITIALISATION
// update current page
Usersessionservice.setCurrentPage('overview');
// repopulate bookmark items.
$scope.repopulateBookmarks();
// for debugging reasons
window.$scope = $scope;
// list effects activate
// stroll.bind('#list .list-wrapper ul.list-group', { live: true } );
});
