current community

your communities

more stack exchange communities

Stack Exchange
tour help
careers 2.0
Take the 2-minute tour ×
Stack Overflow is a question and answer site for professional and enthusiast programmers. It's 100% free, no registration required.
up vote -4 down vote favorite

Can somebody please tell me what I did wrong in the code below?

Also, I would like to paginate the result.

$link = mysql_connect("localhost", "yvens47", "tij43gt") or die("unable to connect to database");
$data = mysql_select_db("phppractice", $link) or die("no such database");

$display = "SELECT * FROM phppractice(Name,Email,Phone)";

while($row = mysql_fetch_array($display)) {
    echo $row['name'];
}
share|improve this question

closed as not a real question by minitech♦, Michael Petrotta, tereško, Waleed Khan, Jack Dec 27 '12 at 21:44

It's difficult to tell what is being asked here. This question is ambiguous, vague, incomplete, overly broad, or rhetorical and cannot be reasonably answered in its current form. For help clarifying this question so that it can be reopened, visit the help center.If this question can be reworded to fit the rules in the help center, please edit the question.
1  
What’s the error? And what does pagination have to do with this? Also, one of the things you did wrong is mysql_; it’s deprecated in PHP 5.5. Try PDO or MySQLi instead. –  minitech♦ Dec 27 '12 at 19:09
1  
Don't use mysql_*. Deprecated. –  Anirudh Ramanathan Dec 27 '12 at 19:09
    
And that’s not even correct SQL. –  minitech♦ Dec 27 '12 at 19:12
    
Can you first tell us what you think you did wrong? –  dbf Dec 27 '12 at 19:14

5 Answers 5

up vote 2 down vote

You forgot to run your incorrect query

$sql = "SELECT Name,Email,Phone FROM phppractice";
$res = mysql_query($sql) or trigger_error(mysql_error());
while($row = mysql_fetch_array($res)) {
    echo $row['name'];
}
share|improve this answer
up vote 1 down vote

Well, for one, your syntax of $display is wrong. Second, you never execute the statement either.

share|improve this answer
up vote 1 down vote

This query is meaningless:

SELECT * FROM phppractice(Name,Email,Phone)

Are you trying to just select fileds named Name, Email, and Phone? If so, use this

SELECT Name, Email, Phone FROM phppractice

On top of this, you never actual call mysql_query(). So the qieru never gets executed.

Also, do not use mysql_* functions. They are deprecated (notice the big red warning on the PHP manual documentation?). I would suggest mysqli_* functions as an easy alternative.

Also, you should always provide error handling to your database queries. If you simply would have logged or echo the MySQL error, and actually made a query attempt, you would have known right away that you had invalid syntax.

share|improve this answer
up vote 1 down vote

The query itself is not valid. Perhaps:

SELECT `Name`, `Email`, `Phone` from phppractice;
share|improve this answer
up vote 0 down vote

WRONG

SELECT * FROM phppractice(Name,Email,Phone)

It should be

SELECT Name,Email,Phone FROM phppractice
share|improve this answer

Not the answer you're looking for? Browse other questions tagged or ask your own question.