function keeps returning undefinded variable instead of array from php explode

Question

up vote 0 down vote favorite

the rgborhex function is returing an undefined variable:

function rgborhex($unformatedColor){
if(strpos($unformatedColor, "-") == false) { //did not find a - in the color string; is not in rgb form; convert
    $rgbColor = hextorgb($unformatedColor);
    $rgbColor = explode("-", $rgbColor);
    return $rgbColor;
}
else { // found a - in the color string; is in rgb form; return
    $rgbColor = $unformatedColor;
    $rgbColor = explode("-", $rgbColor);
    return $rbgColor;
}
}

function hextorgb($hex) {
if(strlen($hex) == 3) {
    $hrcolor = hexdec(substr($hex, 0, 1));      //r
    $hrcolor .= "-" . hexdec(substr($hex, 1, 1));   //g
    $hrcolor .= "-" . hexdec(substr($hex, 2, 1));   //b
}
else if(strlen($hex) == 6) {
    $hrcolor = hexdec(substr($hex, 0, 2));      //r
    $hrcolor .= "-" . hexdec(substr($hex, 2, 2)); //g
    $hrcolor .= "-" . hexdec(substr($hex, 4, 2)); //b
}
return $hrcolor;

}

asked Feb 5 at 8:29

Josh Brown
395

57% accept rate

2

With your strpos you should check === false, not == false. – Psytronic Feb 5 at 8:32

jensgram · Answer 1 · 2010-02-05 08:37:28Z

-return $rbgColor;
+return $rgbColor;

Just a typo in your second return statement :)

Alternative - minor edits, easier to read IMO:

function rgborhex($unformatedColor) {
    if (strpos($unformatedColor, '-') === false) { //did not find a - in the color string; is not in rgb form; convert
        $unformatedColor = hextorgb($unformatedColor);
    }

    return explode('-', $unformatedColor);
}

Snake · Answer 2 · 2010-02-05 08:41:02Z

up vote 0 down vote

Please put error_reporting on E_ALL | E_STRICT. This makes PHP to return much more errors than one might expect.

answered Feb 5 at 8:41

Snake
1,659118

function keeps returning undefinded variable instead of array from php explode

2 Answers

Your Answer

Not the answer you're looking for? Browse other questions tagged php return-value or ask your own question.

Hello World!