Tagged Questions
59
votes
19answers
10k views
How important is it to reduce the number of lines in code?
I am a Software developer who works on J2SE (core java).
Often during our code reviews we are asked to reduce the number of lines in our code.
It's not about removing redundant code, it's about ...
2
votes
3answers
283 views
What feedback is or is not appropriate for a code review? [duplicate]
I am interested in hearing some guidelines as to what feedback is or is not appropriate for a code review. My team has a very unstructured review process and I am trying to suggest some ways to ...
9
votes
7answers
2k views
What is the difference between Static code analysis and code review?
I just wanted to know what the difference is between static code analysis and code review. How are each of these two done? More specifically, what are the tools available today for code review/static ...
0
votes
2answers
131 views
Code review practice in medium team [closed]
I'm looking for a way to organize code review process.
My inputs:
4-5 members in the team;
SVN/IntelliJ IDEA Community Edition.
Solution criteria:
Should support human review with ...
4
votes
2answers
252 views
code review with git-flow and github
With regular git and github I can do a code review by simply creating a pull request of the feature branch I'm working on to the master branch. How would I do code reviews with git-flow? With workflow ...
41
votes
14answers
2k views
What's the most effective way to perform code reviews?
I've never found the ideal way to perform code reviews and yet often my customers require them. Each customer seems to do them in a different way and I've never felt satisfied in any of them.
What ...
54
votes
16answers
2k views
Do We Have a Responsiblity to Improve Old Code?
I was looking over some old code that I wrote. It works, but it's not great code. I know more now than I did at the time, so I could improve it. It's not a current project, but it's current, ...
57
votes
14answers
3k views
How can I tactfully suggest improvements to others' badly designed code during review?
I'm a great believer in clean code and code craftsmanship, though I'm currently at a job where this isn't regarded as a top priority. I sometimes find myself in a situation where a peer's code is ...
-1
votes
3answers
141 views
Programming task to test for focus on maintainability [closed]
I am looking for a programming task, which shows whether the coder has maintainability in mind while programming. I imagine giving a task to fix a bug in a method. It should be clear to the programmer ...
2
votes
4answers
290 views
Can notes/to-dos in code comments sent to code-reviews result in an effective refactoring process?
I want to start/improve a culture of collective code ownership at my company but at a geographically distributed level... I'd say there is some current collective code-ownership mentality, but only at ...
7
votes
6answers
369 views
what is the best way to ensure accountability in code checkins?
Note: after writing this I realize that this question is perhaps philosophical, but I'm interested in how the industry handles this scenario regardless.
I have recently been working with a code base ...
8
votes
8answers
741 views
How to evaluate code quality when you're not familiar with the language?
As a hypothetical, if I were to interview someone for a new PHP developer position when my experience is in .NET, how can I determine if the code sample they've provided me is efficient and of good ...
7
votes
4answers
300 views
How can you get constructive criticism for your code?
My team rarely does code review, mainly because we don't have enough time and people lack the energy and will to do so. But I would really like to know what people think about my code when they read ...
3
votes
4answers
392 views
Reusable VS clean code - where's the balance?
Let's say I have a data model for a blog posts and have two use-cases of that model - getting all blogposts and getting only blogposts which were written by specific author.
There are basically two ...
30
votes
11answers
2k views
Is code reviewing good practice?
When the company I work in hired new managers, they offered us to overview someone's code on every meeting. We have meetings every two weeks, so each time one of developers was to show his/her code on ...
