PHP foreach and explode array code not functioning properly

Question

<?php
$string = file_get_contents("csv.csv");
$array = explode(",", $string);
$q = strtolower($_GET[q]);
foreach ($array as $value) {
    $result = explode(":", $value);
if (strpos($q, $result[0]) !== false) {
    $output = $result[1];
}
}

echo $output;
?>

Here is the content of the file csv.csv which I am turning into a string.

hello: how are you doing,
hi: what are you,
df:df

If $_GET[q] (and $q) is hello, the $output is how are you doing. However, if it is hi, I do not get the output what are you or if I do df I do not get df.

Any reason why this is occuring? Thank you in advance for your kind help.

Answer 1

You are exploding by commas, but the truth is you have each value separated by comma plus line break.

After exploding, your array is ["hello","\nhi...","\ndf:..."], that's why there's no match for the strpos comparison.

try

$array = explode(",\n", $string);

Edit: as @Michael Berkowski said, you could also trim the parameter

if (strpos($q, trim($result[0])) !== false)

The order of the parameters depends on what kind of partial match do you want to offer. With your current parameter order, the parameter "hi" would match "hi", "h" and "i" but not "high".

If you flip them as Michael suggest, the parameter "hi" would match "hi" and "high" but not "h" or "i".

Answer 2

Instead of manually parsing a CSV use str_getcsv

Using str_getcsv and replacing $_GET[q] with $_GET['q'] fixes the issue

    $csv = file_get_contents('csv.csv');
    $array = str_getcsv($csv);
    var_dump($array);
    $q = $_GET['q'];
    foreach ($array as $value) {
        $result = explode(":", $value);
        if (strpos($q, $result[0]) !== false) {
            $output = $result[1];
        }
    }

    echo $output;