current community

your communities

more stack exchange communities

Stack Exchange
tour help
careers 2.0
Take the 2-minute tour ×
Stack Overflow is a question and answer site for professional and enthusiast programmers. It's 100% free, no registration required.
up vote 0 down vote favorite

I am using StringBuilder to build a ver long query.

StringBuilder sb = new StringBuilder();
sb.append("select * from x where name = %s'");
String.format(sb.toString, "John");

What would be equivalent to something like this? Or is this actually the right way to do it?

share|improve this question

2 Answers 2

up vote 5 down vote accepted

It appears you are attempting to build a String for SQL. PreparedStatement should be used instead for this purpose.

PreparedStatement preparedStatement = 
        connection.prepareStatement("select * from x where name = ?");
preparedStatement.setString(1, "John");

Edit:

Given that you're using EntityManager, you can use its equivalent setParameter

Query q = 
 entityManager.createNativeQuery("select * from x where name = ?", MyClass.class);
q.setParameter(1, "John");
share|improve this answer
    
Same answer, But I was too quick –  Ruchira Gayan Ranaweera Jul 1 '13 at 17:13
    
@nelsonjuan What are trying to do here by appending ? –  Ruchira Gayan Ranaweera Jul 1 '13 at 17:18
    
@Ruchira I am actually using javax.persistence.EntityManager to take care of the database. I am preparing the String to em.createNativeQuery(sb.toString(), SomeClass.class).getResultList() –  nelson juan Jul 1 '13 at 17:30
    
@nelsonjuan You can set parameters for EntityManager's native queries using setParameter –  Reimeus Jul 1 '13 at 21:04
up vote 1 down vote

This may help you. where the con is connection

    PreparedStatement preStatement = con.prepareStatement("select * from x where name = ?");
    preStatement.setString(1, "John");
share|improve this answer

Your Answer

 
discard

By posting your answer, you agree to the privacy policy and terms of service.

Not the answer you're looking for? Browse other questions tagged or ask your own question.