Sending arrays of arrays as parameter and then again looping though each array

Question

i have a scenario where i am sending notification mail to all users.hence i need to get all info such as useremail,videocount,imagecount,videoids,imageids etc and send to usermailer to send mail.i want to simplify this process by sending all required parameters to the method and again looping through each array of arrays.

    for example:-

    ###########the below code is in a loop of users################

    User.signed_in_users.find_in_batches(:batch_size => 100 ) { |users| users.each { |user| 

    vcount=Video.where(:users_notified=>f).count
    icount=Image.where(:users_notified=>f).count
    acount=Audio.where(:users_notified=>f).count

    @count << vcount + icount + acount

    vcat=###ALL VIDEO CATEGORIES
    icat=###ALL IMAGE CATEGORIES
    acat=###ALL AUDIO CATEGORIES

    @cats << vcat + icat + acat...and many more


   ###########now sending all these parameter to mailer(array of arrays)
   ####how i can simplify this call 
UserMailer.notify_user(user.email,@video_cat,@video_count,@image_cat,@image_count,@audio_cat,@audio_count,@place_cat,@place_count,@Lpage_count,@Dpage_count).deliver


    } } ###loop ends

Is there any relation between all models and user. Like one to many ? — Nitin, Commented Sep 10, 2014 at 13:51
yes they have the usual has_many and belongs_to .. @NitinVerma — Milind, Commented Sep 10, 2014 at 13:52

Nitin · Accepted Answer · 2014-09-10 14:08:32Z

I don't know why you are trying to fetch same value multiple time. Your below code is running multiple time without any reason.

vcount=Video.where(:users_notified=>f).count
icount=Image.where(:users_notified=>f).count
acount=Audio.where(:users_notified=>f).count

@count << vcount + icount + acount

vcat=###ALL VIDEO CATEGORIES
icat=###ALL IMAGE CATEGORIES
acat=###ALL AUDIO CATEGORIES

@cats << vcat + icat + acat

Because you are iterating on user object. And there is no interaction of user in this bunch of code. So you can take it out of your each block:

vcount=Video.where(:users_notified=>f).count
icount=Image.where(:users_notified=>f).count
acount=Audio.where(:users_notified=>f).count

@count << vcount + icount + acount

vcat=###ALL VIDEO CATEGORIES
icat=###ALL IMAGE CATEGORIES
acat=###ALL AUDIO CATEGORIES

@cats << vcat + icat + acat

User.signed_in_users.find_in_batches(:batch_size => 100 ) { |users| users.each { |user| 

###########now sending all these parameter to mailer(array of arrays)
  UserMailer.notify_user(user.email,@count,@cats)

} } ###loop ends

sorry @Nitin Verma,,,,it might look confusing..for simplification,i have removed complex part of the code....i have updated my question — Milind, Commented Sep 10, 2014 at 14:22
Just to confirm. Is this block have any dependency on user object vcount=Video.where(:users_notified=>f).count icount=Image.where(:users_notified=>f).count acount=Audio.where(:users_notified=>f).count @count << vcount + icount + acount vcat=###ALL VIDEO CATEGORIES icat=###ALL IMAGE CATEGORIES acat=###ALL AUDIO CATEGORIES @cats << vcat + icat + acat — Nitin, Commented Sep 10, 2014 at 14:26

Collectives™ on Stack Overflow

Sending arrays of arrays as parameter and then again looping though each array

1 Answer 1

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Your Answer

Sign up or log in

Post as a guest

Related