Take the 2-minute tour ×
Code Review Stack Exchange is a question and answer site for peer programmer code reviews. It's 100% free, no registration required.

I'm currently developing a console application, where you can add a dataset, edit/delete a dataset and printing a pdf file, with dataset information. I programmed already on C, but not with the OOP thoughts. So I want to know if the following is OOP, since I'm planning to structure my program control this way.

I have 6 classes:

  • ApplicationXXX (includes main(), openMenuControl())
  • JDBConnector (includes the connection to the database)
  • InputReader (reads the input fields)
  • InputWriter (writes the input fields in the database)
  • DataEditor (able to edit a dataset or delete)
  • PDFCreator (creates the pdf).

public class ApplicationXXX {

    public static void openMenuControl() {
        System.out.println("Choose (1) for Add Dataset, Choose (2) for Edit Dataset, (3) create PDF-File")  

        // read input with scanner

        switch (input) {

        case 1: // println "You have choosen "Add Dataset" 
            InputReader read = new InputReader();
            read.readInput();

            InputWriter write = new InputWriter();
            write.writeDataset();
            break;
        case 2: // println "You have choosen "Edit Dataset"
            DataEditor edit = new DataEditor();
            edit.getDataset();
            edit.editDataset();
            break;
        case 3: // println "you have choosen "Create PDF-File"
            PDFCreater pdfcreate = new PDFCreator();

            pdfcreate.getDatset();
            pdfcreate.writeDataset();
            break;
        }
    }

    public static void main() {

        System.out.println("****** PROGRAM HEADER *****");
        while(true) {
            openMenuControl();
        }
    }
}

If would appreciate it, when some experience programmer can give me feedback.

share|improve this question

put on hold as off-topic by kraskevich, janos, tim, RubberDuck, rolfl Mar 11 at 10:14

This question appears to be off-topic. The users who voted to close gave this specific reason:

If this question can be reworded to fit the rules in the help center, please edit the question.

2  
I think you should add all the relevant code to this question(or, at least, a few other classes). What is posted now is not enough to get a good idea of the design of your system. Moreover, it looks like some pieces of code are skipped(and substituted with a comment), which makes reviewing your code even harder(due to lack of information). –  kraskevich Mar 11 at 8:38
1  
All classes are not completed yet, because I was unsure if im going the right way. But i'm doing it like i think and then after a few hours, im editing this thread, with the full code of classes. –  CallMeBronxy Mar 11 at 8:41
    
@CallMeBronxy If you want feedback on design before it's started, maybe some rough UML would be a good idea? :) –  Marcus Widegren Mar 11 at 9:51

Browse other questions tagged or ask your own question.