current community

your communities

more stack exchange communities

Stack Exchange
tour help
Take the 2-minute tour ×
Arduino Stack Exchange is a question and answer site for developers of open-source hardware and software that is compatible with Arduino. It's 100% free, no registration required.
up vote 2 down vote favorite

This is my code which I have written as a library 

#include "avr/interrupt.h"  
#include "Arduino.h"
#include "AllTimer.h"

AllTimer::AllTimer()
{}

void AllTimer::dofun(void)
{
     //TIFR1 |= _BV(OCF1A);

    TCCR1B = 0X00;
    //TIFR1 = 0X01;
    digitalWrite(13,!digitalRead(13));
    Serial.print("I printed");
    TCNT1 = 0X0000;
    TCCR1B |= (1<<CS12) && (1<<CS10);
    //sei();
}

 void AllTimer::setTimer(void)
 {
    TCNT1 = 0x0000;
    TCCR1A = 0x00;
    TCCR1B = 0x00;
    TCCR1B |= (1<<CS12) && (1<<CS10);
    TIMSK1 |= (1<<TOIE1);
    sei();
 }

ISR (TIMER1_OVF_vect)
{
     AllTimer::dofun();
}

Code in Arduino IDE:

 #include <AllTimer.h>

 AllTimer mytimer;

 void setup()
 {
     pinMode(13,OUTPUT);
     Serial.begin(9600);
 }

 void loop()
 {  
     mytimer.setTimer();
    //delay(200);   
  }

But I am not getting anything on the serial monitor. What is the error I have made?

share|improve this question
1  
Using Serial.print inside an ISR is asking for problems. Does the led blink? Also, there is no need to write TCCR1B and TCNT1 inside doFun. –  Gerben 13 hours ago

1 Answer 1

up vote 4 down vote accepted

The Arduino main() calls loop() continuously, in a tight loop. Thus your AllTimer::setTimer() is called continuously, and each time it resets the counter (TCNT1 = 0x0000;). Thus the counter can never overflow.

share|improve this answer
2  
So put mytimer.setTimer(); inside setup instead of loop. –  Gerben 13 hours ago
    
I never realized that. Thanks a lot! –  jeni Shah 12 hours ago

Your Answer

 
discard

By posting your answer, you agree to the privacy policy and terms of service.

Not the answer you're looking for? Browse other questions tagged or ask your own question.