current community

more stack exchange communities

Stack Exchange
tour help
careers 2.0
Take the 2-minute tour ×
Stack Overflow is a question and answer site for professional and enthusiast programmers. It's 100% free, no registration required.
up vote 0 down vote favorite

I want to fill an array using a while loop. With the following code I only get 1 row of data. But if I print $count it's final value is 432. Any ideas? I've bee trying for days but couldn't figure it out.

// Populate objects array

$count = 1;
while($o_result->nextHit()) {

    $t_object = new ca_objects($o_result->get('ca_objects.object_id'));
    $o_c_date = $t_object->getCreationTimestamp();
    $o_lm_date = $t_object->getLastChangeTimestamp();

    $a_objects = array ( array ( 
        'title' => $o_result->get('ca_objects.preferred_labels.name'),
        'type' => $o_result->get('ca_objects.type_id',array(
            'convertCodesToDisplayText' => true))
        )
    );

    $count++;
}

//print results    
foreach ($a_objects as $row) {
    echo $row['title']."<br/>";
    echo $row['type']."<br/>";
}
echo $count."<br/>\n"  ; //This prints 432
share|improve this question
1  
You are re-declaring your array on every loop. –  vascowhite Jun 1 '13 at 21:25
 
how are you able to code a while loop like this if you don't even know what arrays are ? –  Dany Khalife Jun 1 '13 at 21:26
 
Thanks for your answers, I'm learning. –  user2410995 Jun 1 '13 at 21:30
add comment

closed as too localized by vascowhite, PeeHaa, Jon, hjpotter92, likeitlikeit Jun 2 '13 at 1:39

This question is unlikely to help any future visitors; it is only relevant to a small geographic area, a specific moment in time, or an extraordinarily narrow situation that is not generally applicable to the worldwide audience of the internet. For help making this question more broadly applicable, visit the help center.If this question can be reworded to fit the rules in the help center, please edit the question.

1 Answer

up vote 1 down vote accepted

You are resetting the array $a_objects each iteration instead of appending to it.

Do this instead:

// outside the loop:
$a_objects = array();

// inside the loop:
$a_objects[] = array (
    'title' => $o_result->get('ca_objects.preferred_labels.name'),
    'type'  => $o_result->get(
                   'ca_objects.type_id',
                   array('convertCodesToDisplayText' => true)
               )
    )
);

I also put quotes around the title and type keys, which you should do as well -- PHP does attempt to guess what you mean if you don't use quotes, but that's a bad practice and you should stop using it.

share|improve this answer
 
Thank you very much, being new to php I tend to make rookie mistakes. I'll accept yout answer as soon as I can. –  user2410995 Jun 1 '13 at 21:28
 
@sscarano: Glad to help. Also make sure you read the tutorial -- reading it now will save you much trouble in the future. Same goes for the features of PHP as well. –  Jon Jun 1 '13 at 21:30
 
Thanks again. I'll read the tutorial, I'm following a book on php but sometimes I can't see simple mistakes. –  user2410995 Jun 1 '13 at 21:34
add comment