current community

your communities

more stack exchange communities

Stack Exchange
tour help
stack overflow careers
Take the 2-minute tour ×
Stack Overflow is a question and answer site for professional and enthusiast programmers. It's 100% free, no registration required.
up vote 1 down vote favorite

I am pulling data from a query that has the following output: 1 2 3 5

I am converting it into an array like so: $string = explode("\n", $result);

I know have an array displaying the following: Array ( [0] => 1 [1] => 2 [2] => 3 [3] => 5 )

now I am trying to put that array back into a single string having a | seperator

    $test = "";    
    foreach($string as $key)
    {
    $test .= $key." | ";
    }

however, I am getting the ouput of test:

     | 5 |

can somone explain why its not showing what I expect it to show and another way how to produce a single string with a | seperator?

thanks

share|improve this question
1  
Unnormalized database // SQL join smell. –  moonwave99 May 17 '13 at 15:18
    
implode() is what you want; it does exactly what you're asking for. If you're not seeing that then there's something else going on with your array that you haven't told us. –  Spudley May 17 '13 at 15:37

6 Answers 6

up vote 1 down vote accepted

The answer was explode("\r\n", $result) but thanks for showing me the implode function everyone

share|improve this answer
    
Ah, yes. This is common. –  bozdoz May 17 '13 at 15:53
up vote 7 down vote

$string = implode(" | ", $result);

share|improve this answer
    
nope, shows |5 when I echo the $string –  user1873432 May 17 '13 at 15:24
    
Then add a spaces to '|' –  Useless Intern May 17 '13 at 15:30
up vote 2 down vote

if $string is the array than you can use implode to convert it into string Try this

$new_string = implode("|", $string);
share|improve this answer
    
nope, shows |5 when I echo the $new_string using implode –  user1873432 May 17 '13 at 15:26
    
now I am trying to put that array back into a single string having a | seperator This is what you asked, you mentioned separator –  DepH May 17 '13 at 15:33
up vote 2 down vote

To do this, you need the joinfunction: http://es1.php.net/join

share|improve this answer
up vote 5 down vote

I would think implode would be what you're looking for.

Also, to comment on why your code is not working, I'm not sure. Check out this example on ideone.com: http://ideone.com/rH3qbr. I copied your code and it seems to be working, I think, as you would expect it to.

<?php
$result = '1 2 3 4 5';
$string = explode(" ", $result);
$test = "";
foreach($string as $key) {
    $test .= $key." | ";
}
echo $test; // outputs 1 | 2 | 3 | 4 | 5 | 
?>
share|improve this answer
    
nope, shows |5 when I echo the $string using implode –  user1873432 May 17 '13 at 15:24
    
bozdoz, instead of spaces, they are actually a new line "\n" please try that. –  user1873432 May 17 '13 at 15:31
    
The link has been updated, but it's the same result. @user1873432 –  bozdoz May 17 '13 at 15:52
up vote 7 down vote

Try this:

implode("|", $string)
share|improve this answer
    
nope, shows |5 when I echo the $string using implode –  user1873432 May 17 '13 at 15:25
    
The first element of your array must be an empty string, or a space or something. What does print_r($string) show? –  bobwienholt May 17 '13 at 15:28
    
Just add spaces to the " | " and use trim() to take the leading and trailing space off. –  Biotox May 17 '13 at 15:47

Your Answer

 
discard

By posting your answer, you agree to the privacy policy and terms of service.

Not the answer you're looking for? Browse other questions tagged or ask your own question.