Sign up ×
Code Review Stack Exchange is a question and answer site for peer programmer code reviews. It's 100% free, no registration required.

When I want to make some quick tests for my UITableViewControllers, I usually create an NSArray that holds some dummy data. I would like to know if I'm doing anything wrong here:

First in MasterViewController.h:

#import <UIKit/UIKit.h>

@class DetailViewController;

@interface MasterViewController : UITableViewController

@property (nonatomic, retain) NSArray *dataSourceArray;

@end

and then in MasterViewController.m:

#import "MasterViewController.h"

@implementation MasterViewController

@synthesize dataSourceArray = _dataSourceArray;

- (id)initWithNibName:(NSString *)nibNameOrNil bundle:(NSBundle *)nibBundleOrNil
{
    self = [super initWithNibName:nibNameOrNil bundle:nibBundleOrNil];
    if (self) {
        self.title = NSLocalizedString(@"Master", @"Master");
        _dataSourceArray = [[NSArray alloc] initWithObjects:@"obj 1", @"obj 2", @"obj 3", nil];
    }
    return self;
}

- (void)dealloc
{
    [_dataSourceArray release];
    [super dealloc];
}

So, the real question, as long as I'm not assigning _dataSourceArray to something else, I'm safe in terms of memory management here, right?

share|improve this question
    
I agree, the code looks good to me. – geminiCoder Aug 17 '12 at 13:28

1 Answer 1

up vote 1 down vote accepted

Yes. Everything seems correct here.

Like you mention yourself: make sure you use self.dataSourceArray to assign new values, and the synthesized setter will take care of memory management.

share|improve this answer

Your Answer

 
discard

By posting your answer, you agree to the privacy policy and terms of service.

Not the answer you're looking for? Browse other questions tagged or ask your own question.