|
I'm fetching a string that is JSONP, and looking to convert it to JSON. I'm using the following regular expression for matching (for removal) the padding on the JSON. In python, here's the line I'm using for converting the JSONP to JSON: Is there anything I should worry about using this regular expression? Any chance I could end up mangling the JSON? |
|||
|
|
|
The problem with the code is that it doesn't really express what you are trying to do: The code would seem to indicate that you are trying to find and replace many instances of some regular expressions inside the string. However, you are really trying to strip parts off of the beginning and end. I'm also not a huge fan of regular expressions because they are usually pretty dense and hard to read. Sometimes they are awesome, but this is not one of those times. Additionally, you aren't anchoring the regular expression to the beginning of the string which is what you'd need to strip off. The only case I could see that being a problem is perhaps if there were strings inside the json which matched the regular expression. Its best to be sure. Also, I think JSON-P allows functions like alpha["beta"] which will doesn't fit your regular expression. Also what about additional whitespace or comments? I would suggest doing something like: That way you are more clearly stripping everything outside of the first and last parenthesis. |
|||||||||
|
|
You can simply slice the jsonp text to remove the initial padding and ending bracket by doing something like this: This will easily remove the padding. As in most of the cases, you might be just calling some API, then this method might be the best as API would always return the same string. If your response jsonp string padding varies every time, then you'd better write some regex. |
|||||
|
