current community

your communities

more stack exchange communities

Stack Exchange
tour help
Take the 2-minute tour ×
Code Review Stack Exchange is a question and answer site for peer programmer code reviews. It's 100% free, no registration required.
up vote 2 down vote favorite

This code works just fine, but could obviously be more elegantly written.

The basic idea is to create an array of categories from a text input. The code splits up the text input by commas to create the array and trims away white space.

I considered using unshift to add the 'Inbox' default category to the beggining, but figure there must be an even better way. All in all, this is probably the 4th or 5th version of this code.

    var CategoriesForm = event.target.category.value;
    var CategoriesFormTrimmed = CategoriesForm.replace(" ", "");
    var categoriesDefault = ['Inbox']; //default category
    var categoriesJoined = [];
    if (CategoriesForm) {
      var splitUpCategories = CategoriesFormTrimmed.split(',');
      categoriesJoined = categoriesDefault.concat(splitUpCategories);
      console.log(categoriesJoined);
    } else {
      categoriesJoined = ['Inbox'];
    }

share|improve this question
    
Minor quibble: JavaScript conventionally uses camelCase for everything except constructor functions. So style-wise, your CategoriesForm should be categoriesForm, and the same for the -Trimmed var. Joseph's answer below sidesteps all those variables anyway, but just as a general note. –  Flambino Aug 27 at 8:50

1 Answer 1

up vote 4 down vote accepted

That same operation can be streamlined into:

var categoriesJoined = event.target.category.value
  .split(',')
  .map(function(category){ return category.trim(); })
  .filter(function(category){ return !!category; })
  .concat(['Inbox']);

or Inbox first:

var categoriesJoined = ['Inbox'].concat(event.target.category.value
  .split(',')
  .map(function(category){ return category.trim(); })
  .filter(function(category){ return !!category; }))
  • We split first by , giving us access to an array.
  • We clean up each item using map by returning a cleaned value using trim
  • Then filter out those who are totally whitespace (they end up as blanks when trimmed).
  • Add in "Inbox".
share|improve this answer
    
Awesome! This is super helpful. –  Taylor Ackley Aug 27 at 16:45

Your Answer

 
discard

By posting your answer, you agree to the privacy policy and terms of service.

Not the answer you're looking for? Browse other questions tagged or ask your own question.