Is anything what could I improve on my code?
import java.math.BigDecimal;
import java.util.ArrayList;
import java.util.HashMap;
import java.util.Iterator;
import java.util.List;
import java.util.Map;
public class Helper {
public static Map<User, BigDecimal> createPlayersScoreMap(List<User> users, List<Score> scores) {
List<User> players = getPlayers(users);
Map<User, BigDecimal> playersScoreMap = new HashMap<User, BigDecimal>();
for (User player: players) {
BigDecimal sumScore = new BigDecimal(0);
for (Score score: scores) {
if (player.equals(score.getPlayer())) {
sumScore = sumScore.add(score.getResult());
}
}
playersScoreMap.put(player, sumScore);
}
return playersScoreMap;
}
private static List<User> getPlayers(List<User> users) {
List<User> filteredUsers = new ArrayList<User>(users);
for (Iterator<User> it = filteredUsers.iterator(); it.hasNext();) {
if (!it.next().isPlayer())
it.remove();
}
return filteredUsers;
}
}