In MVC architecture (Model-View-Controller), the object responsible for passing and receiving data to and from views, acting as a bridge between the "Model" and the "View".
3
votes
1answer
29 views
Controllers for interacting with a vacation service
I have a controller called VacationController; in this controller, I retrieve a list of vacations which will be displayed in a grid.
In the grid, I have the option to create a new vacation through a ...
1
vote
1answer
23 views
Handling success and failure when retrieving product information
I've got an Angular controller where I have two functions that are repeated inside two functions:
...
1
vote
1answer
48 views
Monkey patch allowing virtual controller methods in PHP MVC application
I'm in the process of building a soon to be opensource CMS. 100% MVC. The basic idea is that a plugin should be able to add pages (read: methods) to a given controller, without needing to instantiate ...
0
votes
0answers
44 views
Laravel 5 Search
Edited my code and put the "search function" seperately. Still I think I could improve this code a lot, especially this part: if($month !== "") {
And ofcourse ...
1
vote
0answers
30 views
Business logic in controller
Led by the recently read premise "Lean controllers and fat models" I've come to the conclusion that my controller might be too fat at the moment.
Basically, what I'm trying to achieve is simple Edit ...
2
votes
2answers
49 views
Controller method to validate and save
I have built RESTful web services. The services endpoints have a similar logic:
If the input validation succeeds, do a database operation and return the result.
If the db operation fails, return the ...
2
votes
1answer
69 views
AngularJS to-do list controller
I am new to Angular. Am I following best practices here? I understand controllers should not do too much. My controller seems to have a lot of logic here. Can I do anything to improve it? It is just a ...
1
vote
1answer
36 views
Selecting orders submitted by a user, segregated by status
I have recently started using Laravel as my chosen framework. It is my first time using a framework. As I have made progress through my project, my controller methods have started to increase in size. ...
0
votes
1answer
117 views
Laravel Controller including sort and search
I am using this code on my own personal website (my personal administration site) so it doesn't need any security and so on. I am not into learning everything about that yet, and although I do know a ...
1
vote
0answers
93 views
Interactive transition between view controllers
I have made an interactive transition controller in Swift in two different ways.
This interactive transition controller is the parent class and I have few child classes which adapt the parent for ...
2
votes
2answers
67 views
Move code from controller to model
I'm working a rails application that has a lot of logic in the controller that should be in the model. In the app/controllers/customers_controller.rb#create there ...
1
vote
2answers
65 views
Replacing an application service class with multiple command handlers
I have a Controller which uses an application service to accomplish its tasks. The service class is starting to grow big and developing multiple dependencies. So I am thinking of replacing the single ...
3
votes
1answer
41 views
Django view and template for a virtual zoo
I have a Django view and template that work together, but I think I probably did things in a crappy way. I basically have many dynamic values that I want to display on the page, and in two different ...
1
vote
1answer
73 views
eCommerce web appliation
I am making an eCommerce web application using the Laravel 5 framework.
I have created a Categories controller for the administrator and with the following actions ...
6
votes
2answers
87 views
Controller for classrooms and students
The actions I'm wondering about are members, add_student, and remove_student. They work ...
0
votes
1answer
31 views
updateBuildChart method with a lot of dependencies
I've some refactoring issue with one method.
This method has a lot of dependencies
...
1
vote
1answer
77 views
Adapting new design pattern with post handler
I'm currently using this pattern in my JavaScript code. Somewhere in my code I use Dnianas.Post.init. init fires and it will ...
5
votes
1answer
57 views
Is my blog controller too “Fat”?
I would like some advice which relates to the "fat model skinny controller" concept in Rails.
See my show action in the Micropost controller
...
5
votes
1answer
130 views
Controller to manage athletes
I would appreciate if you could give me some advice about the code below. I am a student learning PHP programming and programming fundamentals. I have learned a lot from Stack Overflow but there are ...
2
votes
1answer
144 views
Web API controller to get details of a travel plan or a leave request
My web API has 3 controllers for get, post and users CRUD. I named it as DetailsControllor, FormControllor and ...
2
votes
0answers
46 views
Sports statistics controller
Is there too much logic in this controller (should I migrate them to the model)? How else can it be refactored?
...
1
vote
1answer
107 views
Handling callbacks when doing async programming and dealing with scope
I'm using HapiJS to create a little backend for my side-project. In grabbing RSS feeds, I want to loop through my list of website URLs, grab the correct RSS links in the ...
1
vote
0answers
48 views
Persisting database row ID between controller actions on a multi-step “create item” form
I have a form on an anonymous site which has 3 steps. A user submits each step individually, in sequence (1-2-3). BUT, step 1 creates a new table row, while steps 2 and 3 only update the existing row ...
3
votes
1answer
74 views
Using one service ($http) on all the controllers
I have recently started working on angular.js and I like it. I have decided to use a single controller per view. I use the json data from the backend. As my work is progressing, my codes are getting ...
1
vote
1answer
2k views
Shopping cart application in Spring MVC
I am creating a shopping cart application to learn Spring MVC. I want to display a list of all categories and subcategories in more than one page. i.e; Home Page, Products page, and Category page.
In ...
2
votes
1answer
407 views
Controller for repository of members
I tried to implement the Repository pattern for my project:
MemberController.php -- this one is a bit too long and has repetitive code
...
5
votes
1answer
329 views
AngularJS trivia game - separating controller from directive
I am creating a trivia game (purely for learning purposes) using AngularJS, NodeJS and MongoDB. My concern is related to the way I am organising the code in AngularJS. So far the game is functional, ...
1
vote
0answers
49 views
Newsfeed app for allowing custom Reddit feeds
I'm currently working on a newsfeed app (see it live here or its files on GitHub) that lets a user create a custom Reddit feed. The user adds the subreddits they'd like to view, and then can view them ...
7
votes
1answer
78 views
Controller action to process orders and payments
I'm trying to reduce the if statements and simplify this create action.
...
2
votes
0answers
42 views
Is my controller for editing information about videos doing too much?
My project uses Zend Framework 2.
I'm trying to determine if I am doing too much in my controller as a rule for my development. I have built my controllers like this for a while and haven't run into ...
5
votes
2answers
1k views
Rails controller method that conditionally filters results
This code for my blog checks to see if tags are in the params hash. If they are, then only posts that are tagged will be paginated. Otherwise, all of the posts are paginated.
...
3
votes
1answer
10k views
Developing an alert notification in AngularJS
I'm studying Angular and want to develop my own notification alert. This is what I done, I like it and it's working like a charm but I think that it can be improved:
Do I need to use it in ...
2
votes
1answer
106 views
Any improvements for my LoginController class?
This is probably going to be my final question regarding controllers. I feel like I have a good enough understanding of them now and am able to write them cleanly.
I've recently adapted a less error ...
3
votes
1answer
166 views
Controller code using the koa framework
I would like to gather ideas on how to refactor the JavaScript/NodeJS controller code below to be more aesthetic. The code is using the koa framework thus I use ...
13
votes
2answers
409 views
My final sign up controller
I've asked a couple of questions here before regarding my controller, but I think I've finally gotten to understand controllers completely, but I'll never be sure unless I get my code reviewed.
I've ...
4
votes
1answer
66 views
Is this approach correct when testing an Angular controller?
I'd like someone to review these tests to make sure I'm along the right lines in Angular testing.
Note - They do all pass (great) but I feel like I'm struggling to understand the finer points of ...
3
votes
2answers
99 views
Controller: Sign up action clean up
I don't know if it's just me, but I feel like my sign up action method has gotten a bit messy.
I think that perhaps instead of setting error messages in a controller, I should set error codes which I ...
13
votes
2answers
5k views
AngularJS Todo List - too much controller logic?
I am starting an angular app and I was wondering if I am on the right track with this. I worked on my last angular app when I was just a youngun who didn't understand the important of designing the ...
6
votes
1answer
107 views
Uploading file for related entity
I see that my code smells. The first file is a controller, and createAction. But I don't know where to delegate this.
BookController.php - Whole controller class
So this is most 'smelly' code to ...
1
vote
1answer
78 views
.ASP controller code
I've tried to create application with MVC N-layer pattern. I asked my buddy for a shot review, and he said, "You should separate logic from controller".
But my controller only work as a ...
3
votes
2answers
100 views
Xerox Parc MVC implementation
I've been trying to understand the original MVC implementation (the Xerox Parc's one). I'm sure it has flaws, but it's simple code to practice/learn the original MVC.
Working example
View ...
1
vote
1answer
1k views
CodeIgniter maintain data through Controllers
I have a main menu in my application. It loads depending on the role of the user that I validate from a table in my data base, but I have to recreate this menu every time I call a new controller.
...
3
votes
1answer
141 views
What can I do better in this ViewModel Creator?
I'm currently creating a ASP.NET MVC page in C#.
I want to hide everything regarding the creation of our "models" and "viewmodels".
I have seen much of the fancy stuff regarding Dependency ...
0
votes
1answer
96 views
Is it reasonable to have separate controller actions for different user registration paths? Or should I refactor into a fewer number of actions?
I have two registration paths in my app. They are very similar and I am curious if I should simplify 4 associated actions down into two actions that handle the same amount of work.
Here are my ...
2
votes
3answers
624 views
Controller with too many dependencies?
The main impetus for this review is to determine if my ASP.NET Web API controller has too many dependencies. I'm of the opinion that 3-4 is okay, but 6 seems like too many. I have many controllers ...
8
votes
2answers
11k views
Using a BaseController in MVC asp.net to reuse the repository
I have a repository class that impliments a repository Interface.
In my Controllers I want a way to access the repository without creating constructors each time in the controller. So now all my ...
1
vote
1answer
437 views
Inserting using multiple contexts into LocalDB
I've written this ActionResult to model an Order that goes through. I couldn't think of another way to write this without using context ...
0
votes
2answers
551 views
Codeigniter - in the view or in the controller?
Is this correct? Or am I overloading the responsibilities of the view?
...
3
votes
2answers
3k views
Loading content in page via jQuery
I'm doing a web site in CodeIgniter and I'm loading the content page via jQuery, but I don't know if this is a good practice or not. Could I improve it?
jQuery:
// Another question here: how can I ...
0
votes
1answer
2k views
Doing $_POST the right way
I am not sure if I am correctly handling $_POST data in MVC pattern:
Dummy $_POST data
...