Take the 2-minute tour ×
Code Review Stack Exchange is a question and answer site for peer programmer code reviews. It's 100% free, no registration required.

I have a superclass with several subclasses. Each subclass overrides the "solve" method with some a different algorithm for estimating the solution to a particular problem. I'd like to efficiently create an instance of each subclass, store those instances in a list, and then take the sum (or average) of the estimates that the subclasses give:

class Technique():

    def __init__(self):
        self.weight = 1

    def solve(self, problem):
        pass

class Technique1(Technique):

    def __init__(self):
        super()

    def solve(self,problem):
        return 1

class Technique2(Technique):

    def __init__(self):
        super()

    def solve(self,problem):
        return 6

 class Technique3(Technique):

    def __init__(self):
        super()

    def solve(self,problem):
        return -13

testCase = 3
myTechniques = []
t1 = Technique1()
myTechniques.append(t1)
t2 = Technique1()
myTechniques.append(t2)
t3 = Technique1()
myTechniques.append(t3)

print(sum([t.solve(testCase) for t in myTechniques])

The code at the end feels very clunky, particularly as the number of subclasses increases. Is there a way to more efficiently create all of the instances?

share|improve this question

1 Answer 1

up vote 7 down vote accepted

You might try this:

myTechniques = [cls() for cls in Technique.__subclasses__()]

Note that it does not return indirect subclasses, only immediate ones. You might also consider what happens if some subclass of Technique is itself abstract. Speaking of which, you should be using ABCMeta and abstractmethod.

share|improve this answer
    
That's exactly what I was looking for. Thanks! –  Max Rosett Jul 13 at 23:55

Your Answer

 
discard

By posting your answer, you agree to the privacy policy and terms of service.

Not the answer you're looking for? Browse other questions tagged or ask your own question.