This is a commonly used format for our save button for a lot of our pages. I parameterized (to prevent SQL injection) a lot of this. For this page, there's a ton of textboxes and other stuff, so excuse the length.
Can I do this differently? This accounts for the add of a new record or after an edit of an existing one. One other problem, my entryDate
keeps saving as a date with time after it like "10-27-2015 0:00:00" even though I made the field as a Date type in SQL and tried formatting with it below. Why? Important to note that it's a label just informing the user when they entered the record. Normally we use the misc_class
to format dates in a textbox.
One other note: I took out some extra code that involved other tabs and tables so if I'm off a squiggly bracket, I apologize.
protected void SaveData(String addedit)
{
cookie = Request.Cookies["pAuthCookie"];
string empno = cookie["thenum"].ToString();
string thejunk = cookie["email_user"].ToString();
string thelock = thejunk.Trim() + empno.Trim();
string strError = "";
try
{
String ltxtMeetDate = misc_class.format_mmddyyyy(txtMeetDate.Text);
if (ltxtMeetDate == "")
ltxtMeetDate = null;
String ltxtiepstart = misc_class.format_mmddyyyy(txtiepstart.Text);
if (ltxtiepstart == "")
ltxtiepstart = null;
String ltxtiepend = misc_class.format_mmddyyyy(txtiepend.Text);
if (ltxtiepend == "")
ltxtiepend = null;
String ltxtcsetype = txtcsetype.Text;
String ltxtReviewandDisc = txtReviewandDisc.Text;
String ltxtConcerns = txtConcerns.Text;
String lFollowupComments = txtComments.Text;
Boolean lchkAide = chk1Aide1.Checked;
Boolean lchkC2C = chkC2C.Checked;
Boolean lchkPT = chkPT.Checked;
Boolean lchkWC = chkWC.Checked;
Boolean lchkAC = chkAC.Checked;
Boolean lchkHarness = chkHarness.Checked;
Boolean lchkCarseat = chkCarseat.Checked;
Boolean lchkLastOn = chkLastOn.Checked;
Boolean lchkNurse = chkNurse.Checked;
Boolean lchkAide2 = chkAide.Checked;
Boolean lcompleted = chkCompleted.Checked;
Boolean bVerified = chkVerified.Checked;
String strComments = txtComment.Text;
String strHCID = DDLFullName.SelectedValue;
String strDistrict = ddlschool_d.SelectedValue;
Datetime today = Datetime.Today;
String entryDate = today.ToString("d");
//new record insert
if (addedit == "ADD")
{
var connect = ConfigurationManager.ConnectionStrings["theConnectionString"].ToString();
var query = "INSERT INTO tablename (arcfk,meet_date,iep_start,iep_end,school_dfk,cse_type,aide_1to1,curbtocurb,Parent,wheelchair,ac_on_bus,harness,carseat,lastonfirstoff,nurseonbus,pers_aide,num_months,pt_ft,recommendations,parent_concerns,districtsend,eval_req,her_eval,dist_auth,fam_consent,comments,follow_up,evalformby,hep_rep,others_pres,disciplines,empfk,tablelock,IEPDirect,completed,entrydate) VALUES (@arcfk,@meet_date,@iep_start,@iep_end,@school_dfk,@cse_type,@aide_1to1,@curbtocurb,@Parent,@wheelchair,@ac_on_bus,@harness,@carseat,@lastonfirstoff,@nurseonbus,@pers_aide,@num_months,@pt_ft,@recommendations,@parent_concerns,@districtsend,@eval_req,@her_eval,@dist_auth,@fam_consent,@comments,@follow_up,@evalformby,@hep_rep,@others_pres,@disciplines,@empfk,@tablelock,@IEPDirect,@completed,@entrydate)";
using (var conn = new SqlConnection(connect))
{
using (var cmd = new SqlCommand(query, conn))
{
cmd.Parameters.Add("@arcfk", SqlDbType.Int);
cmd.Parameters.Add("@meet_date", SqlDbType.Date);
cmd.Parameters.Add("@iep_start", SqlDbType.Date);
cmd.Parameters.Add("@iep_end", SqlDbType.Date);
cmd.Parameters.Add("@school_dfk", SqlDbType.Int);
cmd.Parameters.Add("@cse_type", SqlDbType.Int);
cmd.Parameters.Add("@aide_1to1", SqlDbType.Bit);
cmd.Parameters.Add("@curbtocurb", SqlDbType.Bit);
cmd.Parameters.Add("@Parent", SqlDbType.Bit);
cmd.Parameters.Add("@wheelchair", SqlDbType.Bit);
cmd.Parameters.Add("@ac_on_bus", SqlDbType.Bit);
cmd.Parameters.Add("@harness", SqlDbType.Bit);
cmd.Parameters.Add("@carseat", SqlDbType.Bit);
cmd.Parameters.Add("@lastonfirstoff", SqlDbType.Bit);
cmd.Parameters.Add("@nurseonbus", SqlDbType.Bit);
cmd.Parameters.Add("@pers_aide", SqlDbType.Bit);
cmd.Parameters.Add("@num_months", SqlDbType.Int);
cmd.Parameters.Add("@pt_ft", SqlDbType.Char);
cmd.Parameters.Add("@recommendations", SqlDbType.VarChar);
cmd.Parameters.Add("@parent_concerns", SqlDbType.VarChar);
cmd.Parameters.Add("@districtsend", SqlDbType.Bit);
cmd.Parameters.Add("@eval_req", SqlDbType.Bit);
cmd.Parameters.Add("@her_eval", SqlDbType.Bit);
cmd.Parameters.Add("@dist_auth", SqlDbType.Bit);
cmd.Parameters.Add("@fam_consent", SqlDbType.Bit);
cmd.Parameters.Add("@comments", SqlDbType.VarChar);
cmd.Parameters.Add("@follow_up", SqlDbType.VarChar);
cmd.Parameters.Add("@IEPDirect", SqlDbType.Date);
cmd.Parameters.Add("@evalformby", SqlDbType.VarChar);
cmd.Parameters.Add("@hep_rep", SqlDbType.VarChar);
cmd.Parameters.Add("@others_pres", SqlDbType.VarChar);
cmd.Parameters.Add("@disciplines", SqlDbType.VarChar);
cmd.Parameters.Add("@empfk", SqlDbType.Int);
cmd.Parameters.Add("@tablelock", SqlDbType.Char);
cmd.Parameters.Add("@completed", SqlDbType.Bit);
cmd.Parameters.Add("@entrydate", SqlDbType.Date);
cmd.Parameters["@arcfk"].Value = Convert.ToInt32(strHCID);
cmd.Parameters["@school_dfk"].Value = Convert.ToInt32(strDistrict);
if (ltxtMeetDate != null)
{
cmd.Parameters["@meet_date"].Value = ltxtMeetDate;
}
else
{
cmd.Parameters["@meet_date"].Value = DBNull.Value;
}
if (ltxtiepstart != null)
{
cmd.Parameters["@iep_start"].Value = ltxtiepstart;
}
else
{
cmd.Parameters["@iep_start"].Value = DBNull.Value;
}
if (ltxtiepend != null)
{
cmd.Parameters["@iep_end"].Value = ltxtiepend;
}
else
{
cmd.Parameters["@iep_end"].Value = DBNull.Value;
}
if (String.IsNullOrEmpty(ltxtcsetype) == false)
cmd.Parameters["@cse_type"].Value = Convert.ToInt32(ltxtcsetype);
else
cmd.Parameters["@cse_type"].Value = DBNull.Value;
cmd.Parameters["@aide_1to1"].Value = lchkAide;
cmd.Parameters["@curbtocurb"].Value = lchkC2C;
cmd.Parameters["@Parent"].Value = lchkPT;
cmd.Parameters["@wheelchair"].Value = lchkWC;
cmd.Parameters["@ac_on_bus"].Value = lchkAC;
cmd.Parameters["@harness"].Value = lchkHarness;
cmd.Parameters["@carseat"].Value = lchkCarseat;
cmd.Parameters["@lastonfirstoff"].Value = lchkLastOn;
cmd.Parameters["@nurseonbus"].Value = lchkNurse;
cmd.Parameters["@pers_aide"].Value = lchkAide2;
cmd.Parameters["@num_months"].Value = Int32.Parse(rblClassification.SelectedValue);
cmd.Parameters["@pt_ft"].Value = rblStatus.SelectedValue;
cmd.Parameters["@recommendations"].Value = ltxtReviewandDisc;
cmd.Parameters["@parent_concerns"].Value = ltxtConcerns;
if (RadioButton1.Checked == true)
cmd.Parameters["@districtsend"].Value = true;
else if (RadioButton2.Checked == true)
cmd.Parameters["@districtsend"].Value = false;
else cmd.Parameters["@districtsend"].Value = DBNull.Value;
if (RadioButton3.Checked == true)
cmd.Parameters["@eval_req"].Value = true;
else if (RadioButton4.Checked == true)
cmd.Parameters["@eval_req"].Value = false;
else cmd.Parameters["@eval_req"].Value = DBNull.Value;
if (RadioButton5.Checked == true)
cmd.Parameters["@her_eval"].Value = true;
else if (RadioButton6.Checked == true)
cmd.Parameters["@her_eval"].Value = false;
else cmd.Parameters["@her_eval"].Value = DBNull.Value;
if (RadioButton7.Checked == true)
cmd.Parameters["@dist_auth"].Value = true;
else if (RadioButton8.Checked == true)
cmd.Parameters["@dist_auth"].Value = false;
else cmd.Parameters["@dist_auth"].Value = DBNull.Value;
if (RadioButton9.Checked == true)
cmd.Parameters["@fam_consent"].Value = true;
else if (RadioButton10.Checked == true)
cmd.Parameters["@fam_consent"].Value = false;
else cmd.Parameters["@fam_consent"].Value = DBNull.Value;
cmd.Parameters["@comments"].Value = strComments;
cmd.Parameters["@follow_up"].Value = lFollowupComments;
String strIEPDirect = misc_class.format_mmddyyyy(txtShareDate.Text);
if (strIEPDirect == "")
strIEPDirect = null;
if (string.IsNullOrEmpty(strIEPDirect) == false)
cmd.Parameters["@IEPDirect"].Value = strIEPDirect;
else
{
cmd.Parameters["@IEPDirect"].Value = DBNull.Value;
}
cmd.Parameters["@evalformby"].Value = txtEvalCompletedBy.Text;
cmd.Parameters["@hep_rep"].Value = txtHEPREPAttending.Text;
cmd.Parameters["@others_pres"].Value = txtOthersAttending.Text;
cmd.Parameters["@disciplines"].Value = txtDiscipline.Text;
cmd.Parameters["@empfk"].Value = empno;
cmd.Parameters["@tablelock"].Value = thelock;
cmd.Parameters["@completed"].Value = lcompleted;
cmd.Parameters["@entrydate"].Value = lentryDate;
conn.Open();
cmd.ExecuteNonQuery();
}
}
}
else
{ /** save on an EDIT*/
Int32 fieppk = Convert.ToInt32(TxtKey.Text);
var connect = ConfigurationManager.ConnectionStrings["theConnectionString"].ToString();
var query = "UPDATE tablename SET [num_months]=@num_months,[pt_ft]=@pt_ft,[meet_date] = @meet_date, [iep_start] = @iep_start, [iep_end] = @iep_end, [cse_type] = @cse_type, [aide_1to1] = @aide_1to1, [curbtocurb] = @curbtocurb, [Parent] = @Parent, [wheelchair] = @wheelchair, [ac_on_bus] = @ac_on_bus, [harness] = @harness, [carseat] = @carseat, [lastonfirstoff] = @lastonfirstoff, [nurseonbus] = @nurseonbus, [pers_aide] = @pers_aide, [recommendations] = @recommendations, [parent_concerns] = @parent_concerns,[districtsend]=@districtsend,[eval_req]=@eval_req,[her_eval]=@her_eval,[dist_auth]=@dist_auth,[fam_consent]=@fam_consent,[comments]=@comments,[follow_up]=@follow_up,[IEPDirect]=@IEPDirect,[evalformby]=@evalformby,[hep_rep]=@hep_rep,[others_pres]=@others_pres,[disciplines]=@disciplines,[empfk]=@empfk,[tablelock]=@tablelock,[completed]=@completed where ieppk=" + fieppk.ToString();
using (var conn = new SqlConnection(connect))
{
using (var cmd3 = new SqlCommand(query, conn))
{
cmd3.Parameters.Add("@num_months", SqlDbType.Int);
cmd3.Parameters.Add("@pt_ft", SqlDbType.Char);
cmd3.Parameters.Add("@meet_date", SqlDbType.Date);
cmd3.Parameters.Add("@iep_start", SqlDbType.Date);
cmd3.Parameters.Add("@iep_end", SqlDbType.Date);
cmd3.Parameters.Add("@school_dfk", SqlDbType.Int);
cmd3.Parameters.Add("@cse_type", SqlDbType.Int);
cmd3.Parameters.Add("@aide_1to1", SqlDbType.Bit);
cmd3.Parameters.Add("@ieppk", SqlDbType.Int);
cmd3.Parameters.Add("@curbtocurb", SqlDbType.Bit);
cmd3.Parameters.Add("@Parent", SqlDbType.Bit);
cmd3.Parameters.Add("@wheelchair", SqlDbType.Bit);
cmd3.Parameters.Add("@ac_on_bus", SqlDbType.Bit);
cmd3.Parameters.Add("@harness", SqlDbType.Bit);
cmd3.Parameters.Add("@carseat", SqlDbType.Bit);
cmd3.Parameters.Add("@lastonfirstoff", SqlDbType.Bit);
cmd3.Parameters.Add("@nurseonbus", SqlDbType.Bit);
cmd3.Parameters.Add("@pers_aide", SqlDbType.Bit);
cmd3.Parameters.Add("@recommendations", SqlDbType.VarChar);
cmd3.Parameters.Add("@parent_concerns", SqlDbType.VarChar);
cmd3.Parameters.Add("@districtsend", SqlDbType.Bit);
cmd3.Parameters.Add("@eval_req", SqlDbType.Bit);
cmd3.Parameters.Add("@her_eval", SqlDbType.Bit);
cmd3.Parameters.Add("@dist_auth", SqlDbType.Bit);
cmd3.Parameters.Add("@fam_consent", SqlDbType.Bit);
cmd3.Parameters.Add("@comments", SqlDbType.VarChar);
cmd3.Parameters.Add("@follow_up", SqlDbType.VarChar);
cmd3.Parameters.Add("@IEPDirect", SqlDbType.Date);
cmd3.Parameters.Add("@evalformby", SqlDbType.VarChar);
cmd3.Parameters.Add("@hep_rep", SqlDbType.VarChar);
cmd3.Parameters.Add("@others_pres", SqlDbType.VarChar);
cmd3.Parameters.Add("@disciplines", SqlDbType.VarChar);
cmd3.Parameters.Add("@empfk", SqlDbType.Int);
cmd3.Parameters.Add("@tablelock", SqlDbType.Char);
cmd3.Parameters.Add("@completed", SqlDbType.Bit);
if (ltxtMeetDate != null)
{
cmd3.Parameters["@meet_date"].Value = ltxtMeetDate;
}
else
{
cmd3.Parameters["@meet_date"].Value = DBNull.Value;
}
if (ltxtiepstart != null)
{
cmd3.Parameters["@iep_start"].Value = ltxtiepstart;
}
else
{
cmd3.Parameters["@iep_start"].Value = DBNull.Value;
}
if (ltxtiepend != null)
{
cmd3.Parameters["@iep_end"].Value = ltxtiepend;
}
else
{
cmd3.Parameters["@iep_end"].Value = DBNull.Value;
}
cmd3.Parameters["@school_dfk"].Value = Convert.ToInt32(strDistrict);
cmd3.Parameters["@num_months"].Value = Int32.Parse(rblClassification.SelectedValue);
cmd3.Parameters["@pt_ft"].Value = rblStatus.SelectedValue;
if (String.IsNullOrEmpty(ltxtcsetype) == false)
cmd3.Parameters["@cse_type"].Value = Convert.ToInt32(ltxtcsetype);
else
cmd3.Parameters["@cse_type"].Value = DBNull.Value;
cmd3.Parameters["@aide_1to1"].Value = lchkAide;
cmd3.Parameters["@ieppk"].Value = fieppk;
cmd3.Parameters["@curbtocurb"].Value = lchkC2C;
cmd3.Parameters["@Parent"].Value = lchkPT;
cmd3.Parameters["@wheelchair"].Value = lchkWC;
cmd3.Parameters["@ac_on_bus"].Value = lchkAC;
cmd3.Parameters["@harness"].Value = lchkHarness;
cmd3.Parameters["@carseat"].Value = lchkCarseat;
cmd3.Parameters["@lastonfirstoff"].Value = lchkLastOn;
cmd3.Parameters["@nurseonbus"].Value = lchkNurse;
cmd3.Parameters["@pers_aide"].Value = lchkAide2;
cmd3.Parameters["@recommendations"].Value = ltxtReviewandDisc;
cmd3.Parameters["@parent_concerns"].Value = ltxtConcerns;
if (RadioButton1.Checked == true)
cmd3.Parameters["@districtsend"].Value = true;
else if (RadioButton2.Checked == true)
cmd3.Parameters["@districtsend"].Value = false;
else cmd3.Parameters["@districtsend"].Value = DBNull.Value;
if (RadioButton3.Checked == true)
cmd3.Parameters["@eval_req"].Value = true;
else if (RadioButton4.Checked == true)
cmd3.Parameters["@eval_req"].Value = false;
else cmd3.Parameters["@eval_req"].Value = DBNull.Value;
if (RadioButton5.Checked == true)
cmd3.Parameters["@her_eval"].Value = true;
else if (RadioButton6.Checked == true)
cmd3.Parameters["@her_eval"].Value = false;
else cmd3.Parameters["@her_eval"].Value = DBNull.Value;
if (RadioButton7.Checked == true)
cmd3.Parameters["@dist_auth"].Value = true;
else if (RadioButton8.Checked == true)
cmd3.Parameters["@dist_auth"].Value = false;
else cmd3.Parameters["@dist_auth"].Value = DBNull.Value;
if (RadioButton9.Checked == true)
cmd3.Parameters["@fam_consent"].Value = true;
else if (RadioButton10.Checked == true)
cmd3.Parameters["@fam_consent"].Value = false;
else cmd3.Parameters["@fam_consent"].Value = DBNull.Value;
cmd3.Parameters["@comments"].Value = txtComment.Text.ToString();
cmd3.Parameters["@follow_up"].Value = txtComments.Text.ToString();
String strIEPDirect = txtShareDate.Text;
if (String.IsNullOrEmpty(strIEPDirect) == false)
cmd3.Parameters["@IEPDirect"].Value = Convert.ToDateTime(strIEPDirect);
else
cmd3.Parameters["@IEPDirect"].Value = DBNull.Value;
cmd3.Parameters["@evalformby"].Value = txtEvalCompletedBy.Text;
cmd3.Parameters["@hep_rep"].Value = txtHEPREPAttending.Text;
cmd3.Parameters["@others_pres"].Value = txtOthersAttending.Text;
cmd3.Parameters["@disciplines"].Value = txtDiscipline.Text;
cmd3.Parameters["@empfk"].Value = empno;
cmd3.Parameters["@tablelock"].Value = thelock;
cmd3.Parameters["@completed"].Value = lcompleted;
conn.Open();
cmd3.ExecuteNonQuery();
}
}
}
Gridview1.DataBind();
}
catch (Exception ex)
{
strError = ex.Message;
}
}