current community

your communities

more stack exchange communities

company blog
Stack Exchange Inbox Reputation and Badges
tour help
stack overflow careers
Sign up ×
Stack Overflow is a question and answer site for professional and enthusiast programmers. It's 100% free.
up vote 1 down vote favorite
3

Im trying to get data in a Json format from a remote WS using Angular and im having some trouble. The data comes from the web service correctly but i cant use it inside the controller. Why is that? Angular Code:

var booksJson;
var app = angular.module('booksInventoryApp',[]);

// get data from the WS
app.run(function ($http) {
    $http.get("https://whispering-woodland-9020.herokuapp.com/getAllBooks").success(function (data) {
        booksJson = data;
        console.log(data);  //Working
    });
});

app.controller('booksCtrl', function ($scope) { 
    $scope.data = booksJson;
    console.log($scope.data); //NOT WORKING
});

HTML:

<section ng-controller="booksCtrl">
<h2 ng-repeat="book in data">{{book.name}}</h2>
</section>
share|improve this question
    
using a run block? why not a .service which returns a promise? then just simply inject that service in your controller(s). – Shehryar Abbasi Jun 3 at 15:59
    
@ShehryarAbbasi Why should i use a service? – VanderVidi Jun 3 at 16:19
1  
@user4440845 You would use a service for many reasons. To name a few, dependency injection, modularity, maintainable, and provides a layer of abstraction. It depends though. If all you are ever going to do is receive a list of all books, then a service is overkill. – Brett Jun 3 at 16:26

3 Answers 3

up vote 1 down vote accepted

You should put your $http.get inside your controller.

Also, the web service returns an object not an array. So your ng-repeat should be something like this: book in data.books

Here is a working example:

var app = angular.module('booksInventoryApp', []);

app.controller('booksCtrl', function($scope, $http) {

  $http.get("https://whispering-woodland-9020.herokuapp.com/getAllBooks")
    .success(function(data) {
      $scope.data = data;          
    });
});
<script src="https://ajax.googleapis.com/ajax/libs/angularjs/1.2.23/angular.min.js"></script>
<article ng-app="booksInventoryApp">
  <section ng-controller="booksCtrl">
    <h2 ng-repeat="book in data.books">{{book.name}}</h2>    
  </section>
</article>

share|improve this answer
1  
Thank you mate. This is perfect. – VanderVidi Jun 3 at 16:17
up vote 0 down vote

Create the bookJSON as array, and push the elements instead of assignment. So

var bookJSON=[];

Inside $http.get do

data.forEach(function(item) { bookJSON.push(item); });

The second console log will show undefined because, the call is async. The assignment happens in future.

The run method does not guarantee, that the code is run before controller loads.

There are other ways too to solve this issue.

Avoid global variable. Look at $routeProvider resolve property.

Or implement a service to get this data as promise.

share|improve this answer
up vote 0 down vote

Instead of using a run block you can use your $http service inside the controller, then attach your data to the scope like normal. Just remember to inject the $http service into your controller.

app.controller('booksCtrl', function ($scope, $http) { 
    $http.get("https://whispering-woodland-9020.herokuapp.com/getAllBooks").success(function (data) {
        $scope.booksJson = data;
    });
});
share|improve this answer

Your Answer

 
discard

By posting your answer, you agree to the privacy policy and terms of service.

Not the answer you're looking for? Browse other questions tagged or ask your own question.