Java spaghetti code [closed]

Question

How to know if my code is spaghetti or not?

Is this is spaghetti code?

btn.setOnClickListener(new View.OnClickListener() {
        @Override
        public void onClick(View v) {

            try {

                ((Core) getActivity()).emailCore();
                ((Core) getActivity()).messengerSharer();

            } catch (NumberFormatException e) {
                e.printStackTrace();

                Toast.makeText(getActivity(),
                        R.string.text_field_toast, Toast.LENGTH_SHORT)
                        .show();

            } catch (Exception e) {
                e.printStackTrace();

                Toast.makeText(getActivity(),
                        R.string.text_field_toast, Toast.LENGTH_SHORT)
                        .show();

            } catch (OutOfMemoryError error) {
                error.printStackTrace();

                Toast.makeText(getActivity(),
                        Html.fromHtml(getString(R.string.html_toast)), Toast.LENGTH_LONG)
                        .show();

            } catch (Error e) {
                e.printStackTrace();

                Toast.makeText(getActivity(),
                        R.string.text_field_toast, Toast.LENGTH_SHORT)
                        .show();

            }
        }
    });

And how to write clean and good java code?

Answer 1

catch (OutOfMemoryError error)
{    
}
catch (Error e)
{
}

Errors should never be caught in Java, only exceptions. An error differs from an exception in the sense that an error is the kind of problem that means something went really wrong and not just something was faulty handled in your application.

Take another look at the first one you catch: OutOfMemoryError. This literally means your app has ran out of memory. By definition, you can't do anything anymore which includes error handling.

Maybe the official documentation speaks for itself here:

An Error is a subclass of Throwable that indicates serious problems that a reasonable application should not try to catch. Most such errors are abnormal conditions. The ThreadDeath error, though a "normal" condition, is also a subclass of Error because most applications should not try to catch it.

Answer 2

How to know if my code is spaghetti or not?

There are GoF Patterns and OOD-Principles (SOLID is an couple of good working principles) agains "Spaghetti-Code".

Is this is spaghetti code?

A little bit.

And how to write clean and good java code?

1. Find OOD-Principles you like to use in parts of your project.
2. Order them by importance
3. Energy Mr. Scott.