Use this tag when examining what is on-topic or off-topic, and why.
-2
votes
2answers
41 views
Is it off-topic to ask for test cases (“use cases”)?
May I ask if you can come up with tests if I have functional code or do I have to develop good tests myself? I did develop a test that works but only with static libraries (which I might consider a ...
1
vote
1answer
34 views
Can I ask questions about where my code went wrong in algorithms and problem solving?
I have recently started solving problems with Python. Many of the programming problems involve complex algorithms and are hard to solve. I need help knowing if the code I've written produces wrong ...
6
votes
2answers
103 views
Non-code formula spreadsheet
From what I can tell this site is mainly (not sure about solely) for the use of reviewing CODE. I am wondering if it will also review code-free spreadsheets for potentially better formulas, or layout ...
16
votes
3answers
333 views
They asked me to write awkward code – how did I do?
Recently, somebody was given a homework assignment with an exercise specification that left much to desire. Yet, they've tried to make the best out of it and managed to write some code that seems to ...
1
vote
0answers
27 views
Are design questions (with actual code) on-topic? [duplicate]
Suppose I'm working on a particular module in my software. I have a proposed design (possibly already implemented or prototyped) that I want feedback on in a tangible format, such as a Java ...
12
votes
2answers
139 views
Rehash “How secure is my X” cryptography questions
This has been discussed before about 2 years ago: “How secure…” questions - Code Review vs. Information Security SE but it doesn't appear to have led to anything very conclusive.
These questions are ...
9
votes
1answer
148 views
Is asking about open source code OK?
Can I ask about open source code if I want to understand why a line of code is present when seemingly it does not affect the program behaviour, but there are good chances that it's there for a reason?
...
14
votes
1answer
184 views
Does a single shell command constitute reviewable code?
A question asks to have a command-line invocation of FFmpeg reviewed. Is that reviewable code?
There is currently no language tag, though shell unix could be added.
Let's not discuss whether a ...
9
votes
2answers
264 views
Can I request that someone look over my legal code?
I wrote two licenses under which I will place my software and art, and I want to make sure they're good enough for what they're intended to do. Is it OK to post them here for review?
11
votes
3answers
129 views
Design review for a compiler question
This question:
'Basic' compiler design for a toy C-like programming language called "Lupe"
Is more of a design review rather than a code review. I have plenty of valid feedback ...
8
votes
1answer
71 views
Where do I ask questions about software structure?
One of the bullet points for this site is that it is not for asking, "Higher-level architecture and design of software systems".
That's exactly what I'm needing answers about. If not here then ...
13
votes
6answers
169 views
What should we do about questions asking to “fix” warnings?
Around the time of writing this post, this question was asked: Extension method to list enum values. The OP is asking how to "fix" their code so a specific warning doesn't pop up (emphasis added):
...
1
vote
2answers
68 views
Should Code Review serve as a refactoring cookbook?
NB. It's not an argument against "keeping the original code intact". I understand the point, I agree with the benefits and I realize the issues that may arise should we digress.
I'd like to hear the ...
6
votes
1answer
74 views
Are answers that discuss design/architecture related aspects of an on-scope question valid? [duplicate]
On IsInternetAvailable, I've written an answer (IsInternetAvailable) that addresses more high-level issues with the code from my perspective.
From what I can tell from the help center, questions that ...
12
votes
1answer
109 views
Disagreement on closure of “Diffee-Hellmen in Javscript”
The question Diffee-Hellmen in Javscript was closed today for being unclear what the OP was asking for.
I disagree with this, however. The very beginning of the post says this:
I need to do the ...
13
votes
6answers
149 views
Is nitpicking worthy of a full answer?
Sometimes, others have already pointed out the obvious flaws in a review. What is left after that are details: naming conventions, style conventions, things that are not bugs that affect results, ...
1
vote
1answer
34 views
Is a review request for a single class on topic for CR?
Before I post another one of those. Is it ok, to post just a single utility class for review here like I did in this question or was I just lucky and I should post such questions on SO?
16
votes
7answers
192 views
One Question Per Question
I voted to close this question as being "Too Broad," on account of the fact that it's actually five, independent questions. At the very least, an answer would have to address all five questions, so ...
22
votes
6answers
214 views
If SO had a standard off-topic reason for code review requests, how should it be worded?
We have long been fighting a battle against Stack Overflow users who vote to close questions with custom reasons like
I'm voting to close this question as off-topic because it belongs on Code ...
0
votes
2answers
65 views
Should minor broken code be reviewed?
Translating array pointer access from C++ to Delphi
I agree that the question should not be deleted for minor problems like that (Should mostly working but a little bit broken code stay or be ...
14
votes
1answer
97 views
Clarification as to why a question was closed as off-topic
An old question that was posted 3 years ago was put "on-hold" as off-topic.
I have not been an active participant on Code Review (I received a notification thanks to a down-vote a couple of days ...
14
votes
2answers
162 views
Do configuration files constitute reviewable code?
A question asks to have a Samba configuration file reviewed. Do we consider a configuration file to be code? It's certainly not a Turing-complete language. Is Turing completeness a defining ...
10
votes
4answers
135 views
Rewriting specific parts of the code
This question got closed. Initial close comment:
I'm voting to close this question as off-topic because it's asking for a feature request, not for a Code Review.
3 counts on that and 2 for ...
15
votes
2answers
207 views
Nothing to review
This question claims to implement the Nothing language.
I'm citing the language specification (emphasis mine):
Note: if the output does not meet the expectation of a "hello world"-program, this ...
13
votes
2answers
168 views
Are Scratch questions okay on Code Review?
I want to post a scratch project on codereview for people to give feedback at, but im worried that it would get downvoted and flagged for being off topic.
So are scratch projects allowed? And if not, ...
6
votes
1answer
69 views
Using example code to demonstrate the use case
Take a look at the code in this recently closed question. It clearly consists of two parts.
The method, which OP wants us to review.
An example (hypothetical?) code, which demonstrates the use case ...
9
votes
2answers
123 views
What is the difference between golfing and reducing code size?
I'm going to be starting a project (a programming challenge) where the compiled source code must be under a certain amount of bytes, and I already know that I am going to be having trouble meeting ...
12
votes
3answers
230 views
Harmless duplicate or are we being taken advantage of?
This question caught my eye because it had accumulated close votes as being a duplicate of another question, which is very rare on CR. The target was a question I reviewed last year by the same user.
...
10
votes
2answers
79 views
Comparing [tag:comparative-review] to a regular review
I think that a comparative review should be 2 questions, and then the user can take the answers from both and do the comparing on their own. then they can decide what is going to work best for ...
5
votes
1answer
86 views
Stack Overflow moderator declined to migrate question asking to shorten code
According to the FAQ, the following topics are wanted on Code Review:
Isn't there a point missing? I see a review of my code not only as an attempt to improve performance, security and structure, ...
10
votes
2answers
66 views
What types of questions are we allowed to ask?
I am new to this community, previously coming from Stack Overflow and having no luck there. My questions always got downvoted and I was restricted from asking questions for days at a time. Then I ...
94
votes
1answer
2k views
A guide to Code Review for Stack Overflow users
You're on Stack Overflow and you've found a question that seems to be about improving code. You are trying to be helpful, and you put a comment in the question:
You should try asking on ...
7
votes
3answers
112 views
Topicality of question “Project Euler #52 - Permuted multiples”
Regarding this question, OP has stated his code works under SpiderMonkey 1.8.5, but not in NodeJS. I've looked at the SpiderMonkey 1.8.5 page and it states that;
Note that version 1.8.5 is ...
6
votes
2answers
76 views
Why is “Random value excluding both limits” considered an off-topic question?
I recently asked this question: Random value excluding both limits
The code to review is as follows:
do {
var random = Math.random();
} while(random === 0);
...
8
votes
4answers
85 views
How do comparative reviews …compare to the rest of CR questions?
I stumbled upon this question in the reopen queue, and looking at it I could find reasons to leave it closed, so I voted [leave closed].
Then I was curious about what made it gather so many reopen ...
7
votes
2answers
60 views
Is this question off-topic because of being a copy/paste of another homework assignment?
For this question:
Circular Queue program
one of the answers noted that the code in the question appears to be copy/pasted from this homework assignment.
Should the question therefore be closed as ...
21
votes
8answers
424 views
How much idle chatter do we tolerate in The 2nd Monitor?
Related but not a duplicate: How far off-topic can we get in 'the 2nd monitor'?
Today was a complicated day in the history of The 2nd Monitor.
On one side there appears to be consensus something ...
2
votes
1answer
59 views
Confusion over posting an acceptable question
My question was closed with a very vague reason. I'm a member on multiple Stack Exchange sites and haven't had issues before with creating a question.
If my question is off-topic I would say the ...
14
votes
1answer
74 views
Are Code Golf King-of-the-Hill controller programs allowed here?
I am in the process of writing a KOTH challenge for Code Golf (it's on the meta sandbox), and like for all KOTH challenges I need to write some code to pit everyone's bot against each other. I've done ...
9
votes
2answers
75 views
Can I post some code that has a small potential bug?
I've written a program that works most of the time. But occasionally it would crash due to a segfault, so I wonder whether it is proper to post such a snippet of code.
Most programs contain bugs; ...
9
votes
2answers
112 views
Why was the question too vague?
I'm reasonably new here but wondered why this question got put on hold?
The OP asks for a review of the code he had provided as the answer to another post on this site. (He includes a link to the ...
6
votes
1answer
70 views
Could I make my design/approach question on-topic?
I just want to discuss my question which was put on hold:
Config data management within a framework
I'm not ranting or arguing. I'm just trying to ascertain why my specific question was not on ...
9
votes
2answers
92 views
Optimizing a Neural Network - on topic?
Backpropagating with Neural Network
The above question asks for help in optimizing a genetic algorithm. At the moment the algorithm takes too long to stabilize.
I have voted to close the question as ...
13
votes
1answer
80 views
Should a warning be displayed when writing a question with no code?
On SO, if I include the words "best practice" in the title of a question, I get a message before I even submit the question warning me that the question appears subjective and may be closed.
Could we ...
2
votes
1answer
47 views
What more can I do for my question to not be off-topic?
Generically calling an overloaded method
My question has been deemed off topic even after editing. What else is needed?
19
votes
5answers
288 views
What IS a Code Review?
So, this site is called "Code Review"...
What we do here is... ask for and write Code Reviews, naturally.
However, I feel that there are a whole bunch of different thoughts floating around about ...
8
votes
2answers
131 views
Are reviews that ask us to DRY their code within the spirit of CR?
This is very closely related to my meta SO question asking Are DRY questions on topic?. Most of the questions over on SO asking for DRY are not suitable for CR and should not be migrated.
In my ...
6
votes
1answer
41 views
Asking questions with UML diagrams instead of code [duplicate]
Can I ask a question with a UML class diagram instead of code? What about instead of some code? The kind of questions I'm interested in asking are about software architecture, not low-level coding ...
25
votes
6answers
658 views
How should we revise the standard off-topic reasons, if we can have up to five?
Note: For chat-like discussions of this subject, let's use this Discuss Close Reasons chat room
Code Review currently has three standard off-topic reasons:
Questions containing broken code or ...
1
vote
6answers
160 views
Should there be evidence for a provided reason when a question is put on hold?
It is easy to say about code that it is written by someone else. It is fine if it is based on concrete facts by providing a link to that code of which they think that it is written by someone else. It ...
