I wanted to know if this code is safe against SQL injection or not?
Also do I need to mysqli_close
if I already did the mysqli_stmt_close
? Other suggestions are always welcome.
if ($stmt = mysqli_prepare($connect, "SELECT subcategories.subcat_name, subsubcategories.subsubcat_name, subcategories.subcat_ID FROM subcategories INNER JOIN subsubcategories ON subcategories.subcat_ID=subsubcategories.subcat_ID WHERE subcategories.cat_ID = ? OR subcategories.extra_cat_ID = ? ORDER BY subcategories.subcat_name, subsubcategories.subsubcat_name ASC")){
mysqli_stmt_bind_param($stmt, "ii", $cat_ID, $cat_ID);
mysqli_stmt_execute($stmt);
mysqli_stmt_bind_result($stmt, $subcat_name, $subsubcat_name, $subcat_ID);
$lastcat = 0;
while (mysqli_stmt_fetch($stmt)){
if($lastcat != $subcat_ID){
$lastcat = $subcat_ID;
echo "<br>";
echo $subcat_name;
echo "<br>";
echo "<br>";
}
echo $subsubcat_name;
echo "<br>";
}
}
mysqli_stmt_close($stmt);
mysqli_close($connect);
echo "<br>";
s away from the database connecting code. \$\endgroup\$ – Alex L Jun 12 '14 at 21:20