In MVC architecture (Model-View-Controller), the object responsible for passing and receiving data to and from views, acting as a bridge between the "Model" and the "View".
4
votes
0answers
36 views
Phishing Project - Refactored Controller Class
Following the last review, I felt that my project was starting to get too complex to continue moving forward as such. So I created a new project and migrated pieces of it over to streamline it's ...
1
vote
1answer
35 views
Laravel controller to update appointment requests
My question/refactor is similar to what is found here:
Laravel controller for form validation skinny
However, I feel that the answer is for 5.0 and not 5.2. This question does not pertain only to one ...
0
votes
0answers
7 views
refactoring controller node js
I would like to refactor two of the controllers in the application, as both of them use the same functionality and therefore code is repeated. This is the approach I decided to use.
Base - controller
...
0
votes
0answers
25 views
Model controller relation
I am creating a PHP app in MVC (no framework). I am having a difficult time understanding how the Model and the Controller communicate in an optimal manner.
User.php
...
5
votes
0answers
44 views
Baseball player statistics controller
I'm somewhat new to JavaScript and Angular and read in Crockford's book that the hoisting function declaration can lead to issues. Any pointers on how to structure my file would be much appreciated.
<...
3
votes
1answer
59 views
Simple PHP MVC framework
I recently wrote this PHP MVC framework. Would like your review.
index.php
...
10
votes
1answer
120 views
ASP controller for tracking equipment
This was originally posted here. I'm hoping Code Review will be a little more helpful in giving me a concrete direction.
I've been working on a project based off of this tutorial.
Unfortunately, ...
1
vote
0answers
21 views
Using session variables to overcome enctype=“multipart/form-data”
I was trying to design a page which will help me upload documents for each case, along with some form data. I then realized request.getParameter() will not work ...
1
vote
1answer
62 views
Rails Grape API Endpoint optional params validation in update
I have the following rails grape api endpoint in the users resource:
...
2
votes
1answer
49 views
Table View Controller for selecting and saving user default preferences in an iOS app
This is the Swift code from one of the view controllers in my app that calculates a one rep maximum weight a person can theoretically lift. This particular view controller presents a list in a ...
3
votes
1answer
26 views
3
votes
1answer
46 views
Redirecting to the appropriate URL for some type of notification
I have a polymorphic notification model with action attribute. When user clicks on a notification he/she should be redirected to given page the notification refers to through notifiable.
What is the ...
5
votes
2answers
86 views
Rails controller to manage EC2 instances
I did a small sample application for an Interview. Since I didn't got accepted I would like your opinion on how to improve it.
The aux methods are private.
I have a ...
2
votes
1answer
27 views
Polymorphic event notification model in Rails
I have a polymorphic notification model. When user gets a notification he can get on the page of the notifiable to check out what happened exactly. For instance ...
3
votes
1answer
56 views
Spring controller code to group information by date
I'm using the Spring Framework in my web application and I'm curious as to whether my controller implementations are good or not.
I've used many Hashmaps to make a object that serves my purpose for ...
1
vote
1answer
132 views
Conversational bot architecture
I am currently building a small conversational bot, and I am struggling with the architecture. I use Facebook Messenger combined with Wit.ai's API and a Shopify store API. My rails app is the ...
2
votes
1answer
38 views
Controller to update a catalogue through an uploaded Excel file
The goal of following MVC controller code is to achieve following workflow:
User exports catalog (either with items of type Spread or of type Consumables) to Excel;
User makes changes in exported ...
1
vote
2answers
85 views
Controller method to manage SMS subscriptions
I have a huge method in my controller that is not DRY and just could use some general TLC. I'm new to ruby and I have not refactored my own code before, only contrived code you find on tutorials. ...
2
votes
1answer
172 views
AngularJS controller to fetch and display employee data from database
This is the code for an AngularJS controller that I've written:
...
5
votes
1answer
106 views
1
vote
1answer
47 views
Updating an auto-generated invoice (future) when current plan changes
I've built-out a mechanism to go and find an auto-generated invoice and update it with new information when a plan is changed or if users are added to the plan for the current billing period. It will ...
2
votes
1answer
87 views
Simple calculator in PHP utilizing MVC
I have been struggling with understanding Model, View, Service, Controller architecture and wrote some code.
Is my Model class the Model part of MVC (did I define ...
3
votes
0answers
47 views
Fat Controller Action - Deep nested filters
I have this really really long controller action and would like someone to help me break it down.
...
0
votes
1answer
98 views
Laravel 5 controller to list appointments by date range and by label
I am starting to get into OOP using PHP and MVC. I just want to know if this code is good practice. Is this how I should be using my controller and model, in its simplest form?
AppointmentsController:...
1
vote
1answer
45 views
Angular Box Color Exercise
I have completed an exercise where there are 4 different color boxes and 1 main box below them that is blank, when you click on one of the colored boxes, the main box changes to the color of the box ...
7
votes
1answer
398 views
Sails.js controller method for an admin to update a user account
I am new to Sails.js, Node.js, and web application development in general. My current understanding is that well-written controllers should be "skinny" meaning they should be as simple as possible, ...
3
votes
2answers
106 views
CakePHP static pages (without entity) but with dynamic content
I have a few pages that is not connected with entities (index page, terms of use page, email page).
Detailed description: In CakePHP, when you want to have a static page (such as index for example), ...
2
votes
0answers
80 views
Controller method to add a product, stored across three database tables
I have some questions on how I can improve this "add" action method in a controller.
Using a single form, the user can upload a product to be displayed on the site. A Product is composed of three ...
4
votes
1answer
89 views
CakePHP change 'miniMap' action and respect template
I have some questions on how I can improve this "action" (method) in "controller":
My template has a navbar with dynamic content (if the user is logged in a special button appears, his name appears ...
1
vote
1answer
138 views
Price calculator for motors and pumps
Note
This question was born in request to post more details from this question on Programmers. Since details may uncover new/different complexity, I'm asking another question here. I also will use ...
3
votes
1answer
40 views
Controllers for interacting with a vacation service
I have a controller called VacationController; in this controller, I retrieve a list of vacations which will be displayed in a grid.
In the grid, I have the option to create a new vacation through a ...
2
votes
1answer
51 views
Handling success and failure when retrieving product information
I've got an Angular controller where I have two functions that are repeated inside two functions:
...
1
vote
1answer
99 views
Monkey patch allowing virtual controller methods in PHP MVC application
I'm in the process of building a soon to be opensource CMS. 100% MVC. The basic idea is that a plugin should be able to add pages (read: methods) to a given controller, without needing to instantiate ...
0
votes
0answers
236 views
Laravel 5 Search
I think I could improve this code a lot, especially this part:
if($month !== "") {
AppointmentsController:
...
2
votes
0answers
77 views
Business logic in controller
Led by the recently read premise "Lean controllers and fat models" I've come to the conclusion that my controller might be too fat at the moment.
Basically, what I'm trying to achieve is simple Edit ...
2
votes
2answers
54 views
Controller method to validate and save
I have built RESTful web services. The services endpoints have a similar logic:
If the input validation succeeds, do a database operation and return the result.
If the db operation fails, return the ...
2
votes
1answer
161 views
AngularJS to-do list controller
I am new to Angular. Am I following best practices here? I understand controllers should not do too much. My controller seems to have a lot of logic here. Can I do anything to improve it? It is just a ...
1
vote
1answer
46 views
Selecting orders submitted by a user, segregated by status
I have recently started using Laravel as my chosen framework. It is my first time using a framework. As I have made progress through my project, my controller methods have started to increase in size. ...
0
votes
1answer
393 views
Laravel Controller including sort and search
I am using this code on my own personal website (my personal administration site) so it doesn't need any security and so on. I am not into learning everything about that yet, and although I do know a ...
2
votes
0answers
250 views
Interactive transition between view controllers
I have made an interactive transition controller in Swift in two different ways.
This interactive transition controller is the parent class and I have few child classes which adapt the parent for ...
2
votes
2answers
91 views
Move code from controller to model
I'm working a rails application that has a lot of logic in the controller that should be in the model. In the app/controllers/customers_controller.rb#create there ...
1
vote
2answers
94 views
Replacing an application service class with multiple command handlers
I have a Controller which uses an application service to accomplish its tasks. The service class is starting to grow big and developing multiple dependencies. So I am thinking of replacing the single ...
3
votes
1answer
46 views
Django view and template for a virtual zoo
I have a Django view and template that work together, but I think I probably did things in a crappy way. I basically have many dynamic values that I want to display on the page, and in two different ...
1
vote
1answer
101 views
eCommerce web appliation
I am making an eCommerce web application using the Laravel 5 framework.
I have created a Categories controller for the administrator and with the following actions ...
6
votes
2answers
110 views
Controller for classrooms and students
The actions I'm wondering about are members, add_student, and remove_student. They work ...
0
votes
1answer
32 views
updateBuildChart method with a lot of dependencies
I've some refactoring issue with one method.
This method has a lot of dependencies
...
1
vote
1answer
85 views
Adapting new design pattern with post handler
I'm currently using this pattern in my JavaScript code. Somewhere in my code I use Dnianas.Post.init. init fires and it will ...
5
votes
1answer
69 views
Is my blog controller too “Fat”?
I would like some advice which relates to the "fat model skinny controller" concept in Rails.
See my show action in the Micropost controller
...
5
votes
1answer
146 views
Controller to manage athletes
I would appreciate if you could give me some advice about the code below. I am a student learning PHP programming and programming fundamentals. I have learned a lot from Stack Overflow but there are ...
2
votes
1answer
303 views
Web API controller to get details of a travel plan or a leave request
My web API has 3 controllers for get, post and users CRUD. I named it as DetailsControllor, FormControllor and ...
