Model-View-Controller for the ASP.NET framework
3
votes
1answer
58 views
An Edit action in ASP.NET MVC, with handling for missing id parameter
I have a standard Edit action in Asp.Net MVC 5 and I want to avoid throwing the unhandled exception when is made a get request without the id like ~/food/edit, so I did this.
...
3
votes
0answers
69 views
Asp.Net MVC Application Controller
I'm developing a webapp in ASP.Net MVC. One of the requirements of the project is that users follow a "workflow". The workflow has a number of steps, and a conditional branch. The workflow is long ...
2
votes
2answers
63 views
Optimize store proc performance being called in c# on array loop
I have a c# application(mvc) that allows a user to upload an excel sheet containing an account number key and amount value to be passed as parameters to a proc that then validates those records, the ...
4
votes
2answers
54 views
Search for variants of keywords using LINQ
First, I'm adding words entered into a search field to an array. Then, I'm getting results from a stored procedure on SQL Server using Database First approach with Entity Framework.
Finally, for ...
0
votes
1answer
56 views
Controller method to update properties of a request
I have a view that displays details of a work order request submitted by a user. As far as security and database querying is concerned, which one of the following options would be better if I'm going ...
5
votes
1answer
50 views
Properly create and customise a web app using visual studio 2015 C# MVC template
I'm new to C# web, I want to know how to properly create a web app using
visual studio 2015 MVC templates, and being able to customise some of its code. I want to both practice C# web and clean code.....
3
votes
1answer
88 views
Entity Framework query optimization
A user can track a show, and mark episodes and seasons of that show as watched. To support this I have the models below:
Models
...
2
votes
1answer
130 views
Dynamic wrappper used to unit test ASP.NET Core MVC Controllers that return anonymous objects
Originally created for this answer on SO, I thought there was still room for improvement on the initial basic idea.
Also thought about using an extension method to make using syntax simpler.
Here is ...
4
votes
1answer
97 views
Reading and displaying an image from a folder
I have a question concerning the correctness of the reading and displaying the image in ASP.NET Core MVC web application.
This is the way I am reading image names from a specific folder (I am using <...
1
vote
3answers
263 views
ASP.NET Product Listing
I am working on a e-shop in ASP.NET MVC, and I just made the listing of product the way I figured out this night. Is it correct? Or should I make it differently? How?
So this is my Product controller,...
10
votes
1answer
123 views
ASP controller for tracking equipment
This was originally posted here. I'm hoping Code Review will be a little more helpful in giving me a concrete direction.
I've been working on a project based off of this tutorial.
Unfortunately, ...
1
vote
1answer
65 views
ASP.NET C# MVC thin controller for file validation with service layer
My name is Matt and I have a fat controller problem.
In truth I have limited experience of MVC and I'm trying to learn how to organise my code better so it's more testable and more maintainable. Here'...
6
votes
2answers
333 views
Expose an IDbSet<> object to overcome a limitation for LINQ's Select()
Before posting this, I have spent the past 4 days tirelessly investigating the Internet and the different Stack Exchange websites on how to correctly implement the Unit of Work pattern and Unit Test ...
1
vote
1answer
25 views
Mapping discussion entries from an SQL-View to objects
In my ASP.NET MVC application, I am loading Discussion Entry records along with User info (who posted the entry), Badges (assigned to the entry), Reactions (made to the entry like Facebook-style ...
0
votes
1answer
62 views
Skip by Id on large list
This is in ASP.NET MVC, but that shouldn't make a difference. I have a large number of rows in my database for Songs.
...
3
votes
0answers
39 views
Multitenant app authorization
Role based security does not work for me well in a multitenant app, as I need to query DB to decide on permission allowance. Here is the solution I came to.
All implementations of this interface will ...
1
vote
1answer
53 views
Authentication terminology
Below comes a Value Object to represent UserId in ASP.NET application. It implements Value Identity, so equality is defined by matching of the state calculated at ...
1
vote
1answer
538 views
Custom HttpClient Wrapper
I need to wrap httpClient because I'm using a custom token provider. I will use this code with asp.net mvc to communicate with our webApi2 server. ( Using webApi2 with directly from ui with angularjs ...
2
votes
1answer
43 views
Controller to update a catalogue through an uploaded Excel file
The goal of following MVC controller code is to achieve following workflow:
User exports catalog (either with items of type Spread or of type Consumables) to Excel;
User makes changes in exported ...
1
vote
0answers
127 views
MVC application internationalization using a database provider and dependency injection
Following Nadeem Afana's article about how to include internationalization into an MVC application, I have introduced i18n into one of my MVC applications.
These ...
0
votes
0answers
39 views
Show products in dropdown from parent to chid
My goal is a list selector like this:
To do this I wrote these methods:
First:
...
2
votes
1answer
92 views
Singleton implementation of Cache Dependency Manager
I am trying to implement a singleton CacheDependencyManager, by combining this CacheDependencyManager from Steve Greatrex with a singleton pattern from Jon Skeet (example 6).
I'd really appreciate ...
1
vote
1answer
132 views
4
votes
3answers
105 views
Allowing internal employees to request supplies
Business rules: This application is for internal employees to request supplies. All requests must be approved my the persons manager. In the database, a manager is an employee, with a self ...
5
votes
1answer
104 views
Paginating blog posts from SQL server using nested LINQ statements
I made an ASP.NET MVC application using Entity Framework for code-first migrations to the SQL Server database. I also use Unity (DI/IoC) for managing the services and repositories.
I made an overview ...
5
votes
1answer
489 views
Recurring tasks in ASP.NET MVC
I have 2 alternatives for executing recurring tasks in ASP.NET MVC.
We just need to add some code in Global.asax
First alternative:
...
3
votes
0answers
591 views
Simple tracking online users in ASP.NET
I wrote simple online users tracking for my ASP.NET MVC project.
In Global.asax I added:
...
1
vote
1answer
36 views
Using [ChildActionOnly] for generating links
I have a view which displays a list of items, in each row I'm going to have a link, a link in each row points to different location So base upon a property called ...
6
votes
1answer
285 views
Embedding an RSS feed into a page after it's already loaded
I'm working on reworking our website from a WYSIWYG editor to MVC. I'm all right with server side code, but complete rubbish when it comes to client side Javascript, so I'd appreciate any/all feedback....
2
votes
1answer
51 views
Validating user access to a function
I was reviewing the following code block and noticed there was validation check at the top. The 3rd line in the function checks if the invoice belongs to the logged in customer.
I am wondering ...
3
votes
1answer
71 views
Generic Object Editing Classes with Controller, ViewModelProvider and DBUpdater
I am beginning to use generics and would like feedback on the following set of classes that will serve as the basis for an app that contains a large number of basic CRUD-y entities.
I have used ...
4
votes
1answer
2k views
Unit testing with dependency injection and MOQ
I'm just learning how dependency injection and mocking work, but I'd like some feedback on how I'm setting up a couple of tests. I can get them to pass, but I'm not sure this is all I need.
This is ...
8
votes
3answers
510 views
Implementing IDisposable
I am developing a class (in a C# MVC 5 project) that originally had a using block within a single method, and it got to be very huge after placing formatting ...
7
votes
1answer
6k views
MVC binding list of values to checkboxlist in an efficient way
I have this code which generates and shows list of selectable items that user can post to controller in order to save into database.
Model looks like this:
...
2
votes
0answers
165 views
Safe implementation for extending authentication cookie with user data
After searching around and reading through articles and answers I came up with this implementation for extending the cookie of Forms Authentication. But I am not 100% sure that I did not introduce any ...
4
votes
2answers
150 views
Keeping data processing out of controllers
I would like to start by mentioning that I am LAMP stack guy who happens to be making my first ever .NET C# web app and I'm seeking general advises for best practices and to see how more experienced ...
2
votes
1answer
138 views
AngularJS: Http API Service - any improvements / remarks?
Could you please review the below AngularJS service. What it does is centralize all (relevant) HTTP action calls.
Do you see any chances for improvement?:
...
5
votes
1answer
237 views
Combating magic strings in a web application
I'm on a quest to combat all the magic strings which tends to pile up in an ASP.NET MVC application.
All reviews will be highly appreciate but please note that:
Some of the classes contains more (...
3
votes
2answers
74 views
View Model Constructor Arguments
I have created a ViewModel for a Product Edit page because it has specific related entities I need to load - the class currently looks like this:
...
0
votes
1answer
657 views
Method GetById and SingleResult
Here is my method that I use to get one entity in an ASP.NET Web API application.
...
4
votes
2answers
1k views
A set of Razor HTML helpers for disabling elements
I am developing a huge form with a lot of elements in it. The purpose of this form is editing one domain entity. Now, I finished developing the whole form and it just shows the bunch of text boxes, ...
2
votes
0answers
78 views
Business logic in controller
Led by the recently read premise "Lean controllers and fat models" I've come to the conclusion that my controller might be too fat at the moment.
Basically, what I'm trying to achieve is simple Edit ...
3
votes
3answers
2k views
Master detail INSERT in Entity Framework 6 Database First MVC 5
I have a DB with a master table called "facturas" and another detail table "facturas_detalle." I would like to insert to them, so this is a "Database-First".
I need some guidance or advise of best ...
1
vote
2answers
98 views
Implementing Search method For a Class
In my web app, I have a view where users can search in receipts and drafts.
I've implemented this ability in search method at my view model, but I'm not sure if this is the best place to put it. So I'...
4
votes
1answer
658 views
Checking locked users using Identity 2.0
I'm writing a theoretical MVC application to aid in learning more about ASP Identity 2. In real terms I'm new to ASP Identity as a whole but thought I'd jump in in this release as
it's the default ...
0
votes
0answers
140 views
Adding a link on page with current URL (including hash) in a querystring
I'm trying to add a link to a page. The link should contain the current URL in a querystring (to be used as a ReturnUrl) and it can contain a hash.
Middle-...
5
votes
2answers
99 views
Writing a thin navigation controller
I'm trying to achieve a thin controller, and I started out with a thin controller but over time as the project has progressed the controller has got more complex. Could you please review the following ...
6
votes
1answer
73 views
Highlight Current Link
I'm using this technique for highlighting current links (e.g. how the "Questions" link is highlighted on this very page you're looking at). I changed the code a little bit and came up with this ...
3
votes
1answer
327 views
Choose the right type for method GetById
I designed my repository class and I need some advice from you. Now I have a method GetByID that returns a generic type:
...
2
votes
1answer
141 views
Method that return related entities using OData
There is method GetFull that should use OData return related entities.
When I call GetFull(12, "entity1,entity2") then I will ...