Editing is a core, fundamental Stack Exchange value; we allow editing by registered and unregistered users (if peer reviewed).
17
votes
2answers
164 views
Can I edit broken code if I'm sure I'm recreating OP's original code?
I know, I know: "Never edit the code, leave it for the review!". But please, hear me out before answering.
What should I do if I encounter a code that doesn't work, but I'm 99.99% sure it's because ...
5
votes
3answers
113 views
Is it okay for OP to edit to include Benchmarking results?
The question is whether it should be allowed for the OP to edit to include timings of answers to a code related to benchmarking. Currently, there is a moderator who doesn't like this for this question....
9
votes
2answers
90 views
Can I edit parts of the code blocks that aren't part of the code itself?
First off, this question is related to several other meta posts, but as far as I can tell none of the questions cover it. First a list of similar questions and why they are different:
Is it ...
7
votes
2answers
154 views
Removing leading white space in question code blocks
I've made a couple of suggested edits to this question. The first one was rejected because it deviated from he original intent / it edited code. When I looked at the suggested edit, it did look like ...
7
votes
0answers
58 views
Would it be possible to have the question closer to the answer field?
I find that when answering a question on Code Review, I'm constantly scrolling to the top of the page, copying some code, scrolling to the bottom, pasting it, then editing it. I do this over and over. ...
1
vote
2answers
77 views
Should Code Review serve as a refactoring cookbook?
NB. It's not an argument against "keeping the original code intact". I understand the point, I agree with the benefits and I realize the issues that may arise should we digress.
I'd like to hear the ...
-1
votes
3answers
104 views
Discouraging gigantic headers in answers?
-~- Your Yearly Airing Of The Grievances -~-
A lot of answers follow the template of:
Avoid X
Description of why X is bad
Do Y
Description of why Y is good and better than what OP ...
4
votes
2answers
36 views
Missing edit-tags rollover
I can't hover over the spot next to the tags for an "edit tags" button anymore:
This used to work before the graduation, but now I have to click on edit and I am too lazy for that.
16
votes
3answers
169 views
What are our answer editing guidelines?
On this site, we have a well-known policy on editing code in questions: Don't. After all, that code is up for review, in all its glorious ugliness and buginess. But clearly, such reasoning cannot ...
12
votes
3answers
91 views
Editing in missing #includes
The off-topic list at meta includes:
Questions containing broken code or asking for advice about code not yet written are off-topic, as the code is not ready for review.
So questions must ...
14
votes
1answer
74 views
Do we want site-specific editing guidance?
With our newly reached "graduated" (I really shouldn't put that in quotes) status, I expect a significant influx of new users, be it through migration or otherwise being drawn in by the thrill of a ...
3
votes
3answers
93 views
Question author updated the code as a diff. Should I have applied the patch?
Project Euler, Challenge #12 in Swift
If editing in the edit keeps the question clear, should we edit the edit into the question instead of leaving it as two separate blocks of code?
It seemed ...
2
votes
0answers
36 views
Can I edit the code of my question if I haven't received any answers and comments yet? [duplicate]
I asked this question two days ago. The question was well-received with 4 upvotes yet I haven't received any answers and no one has commented it.
In the meanwhile, I developed an other entirely ...
9
votes
1answer
34 views
Updating cross-posts, where the author has done so, on a different site
The question I refer to is this one. It has been cross-posted from Stack Overflow, it hasn't received any reviews yet, however, it has been edited on SO, but not on CR. The edits made (indentation ...
5
votes
4answers
97 views
Are minor edits to old meta questions useful?
That's a view from the "active" page on the Code Review meta.
The edits are mostly minor. And some of them are coming from quite old questions, even questions with the status-completed tag.
Like ...
9
votes
3answers
112 views
Is it okay to modify code in a post if we've discovered a bug, before receiving an answer?
Assuming that I have a posted a question with working code, and I've discovered a bug in it without the help of an answer, is it okay to edit the code in the post with a fix?
11
votes
2answers
63 views
Editing closed/on-hold questions
I'm allergic to a number of things:
Bad titles ("please review my code"), tags in title
Wrong tags being used
Typos and grammar issues
Is it ok to edit questions for these reasons?
When wouldn't ...
3
votes
0answers
29 views
Adding someone else's code into the question [duplicate]
Code behind a link is off-topic. Good.
Questions trying it anyway get closed. Good.
But every once in a while I encounter a question which is quite good and where this is the only problem. Now, I ...
8
votes
2answers
122 views
When is an edit considered enough to be acceptable?
A mod edited one of my questions I've made today (For the curious: Class Object to create objects of type Object, in a dynamic way, with magic methods).
The changes are so minimal that I have no idea ...
2
votes
1answer
75 views
Cleaning up the original code in the question
Most of the reviewers/answerers here should be familiar enough with Ctrl+K and Home,Shift+▼,Del keystroke combinations that an edit to provide some readability without losing the original content of ...
8
votes
2answers
119 views
Why SED over sed?
I was browsing edits, and I noticed a change from sed to SED. This came in parallel with a change from awk to AWK. I follow the capitalization of AWK. Not sure that I agree, but AWK is an acronym ...
18
votes
2answers
158 views
Should code be forcibly translated into English?
In Sieve prime generator C++, a user translated some French strings into English, and the edit got approved.
In toBase64 encoder, the author replaced Russian strings and comments with English in ...
11
votes
1answer
95 views
Reviewing a question that doesn't belong
There is currently a question on hold, which really should never have been posted to Code Review, but I think it actually highlights a point that would be worth an answer.
I started to edit the ...
5
votes
1answer
49 views
Blockquotes and formatting
In many, many, many, many or my recent questions, I've [mis]used blockquotes to separate code files.
I always do it like this:
Identifier type of code file
As in
Foo class
and
IFoo ...
9
votes
1answer
75 views
Non-OP edits to change the original question to make it on-topic
I feel that this topic is ambiguous at the current time, and I would like some clarification. When I see a question that is obviously, or at least appears to be off-topic based on how it is worded, my ...
11
votes
2answers
52 views
Is it okay to convert a question code block into a working snippet?
We tend to leave the source code alone as all aspects are valid for code review.
But, questions like these are just asking to be converted to a snippet ( there's a link to JsFiddle even!)
Just wanted ...
14
votes
2answers
102 views
Over-editing my own answer
It looks that I have just over-edited my own (first!) answer and got a comment:
Please try to keep the edits down to a minimal now. Thanks!
I was wondering what has just happened, searched a bit ...
7
votes
1answer
51 views
Ability to edit self-deleted questions
I understand that preventing edits on deleted answers can help defeat FGITW (Fastest Gun In The West) problems on other sites (or here?), but it seems deleted questions cannot be edited either.
This ...
7
votes
2answers
96 views
Is this edit okay?
A struct within a class, and this is the edit history: http://codereview.stackexchange.com/posts/60534/revisions
The original code include this method:
...
9
votes
3answers
123 views
Does the plain-English part of a question even matter?
Does the plain-English part of a question even matter?
I'm not recommending that the plain-English part doesn't help make questions better, but given the approach we've taken towards answers on ...
8
votes
1answer
76 views
Questions containing false statements: Edit or Answer?
http://codereview.stackexchange.com/review/suggested-edits/24111
The asker posts a false statement: "This code runs in time complexity X." Should they be corrected in an answer or in an edit? ... or ...
0
votes
1answer
43 views
Edit a question to add comments to the code?
In this question, an edit to the code (by other than the asker) added this block of comments to the code:
...
6
votes
1answer
117 views
Good question, but OP didn't know how to ask it?
In Calculating Julian dates, the author asks a question that doesn't make sense:
Refactor this code so that I don't have to insert the parameters any time I need to use one of the functions.
[...
2
votes
1answer
36 views
VB comments taking up more than one line unless comment is terminated
In this question, there are comments in the code, other code that was tried before, and the comment showed over multiple lines unless the comment was terminated with another apostrophe, which isn't ...
4
votes
1answer
56 views
Number list formatting followed by code formatting issue
On this question, I found that when I tried to edit the question and add a numbered list format, it sucked in the code formatting that followed, so I had to add ...
4
votes
0answers
89 views
Correct edit rejection
As code edits are reviewed by peers, anyone who has rights to review the edits can approve or reject edits. I suggested this edit and, AFAIK, my edits are correct. But this got rejected.
I know this ...
22
votes
3answers
532 views
Should you edit someone else's code in a question?
I have seen several (suggested) reviews lately, where someone edits the code in the original poster's question. Should such edits be allowed?
The edits in question are mostly minor. Some add spaces ...
6
votes
2answers
188 views
Is it okay to edit part(s) of code not yet reviewed?
In this question of mine, the one answerer so far has only reviewed a part of my code. However, I've made changes on other parts of my code, but I don't want to somehow invalidate that answer.
Would ...
6
votes
2answers
102 views
Advice for reviewing edits
I just became eligible to approve pending edits and would like some advice. At the time of writing, this post has a pending edit:
Best practices in PHP
The edit changes the code posted in an answer ...
4
votes
2answers
77 views
Is it appropriate to edit excessive line breaks from code?
Some questions (2) have quite a few extra lines which are kind of unnecessary. I guess they could be attributed to "style" but in my opinion they make to more lines and less to readable code. For ...
8
votes
2answers
223 views
Increase number of edits before post becomes community wiki
According to this answer on meta.stackoverflow.com:
Posts enter community wiki mode when one of the following happens: [...]
The post has been edited ten (10) times by the original owner.
...
3
votes
1answer
76 views
Two approvals for suggested edits
It seems to me that currently a suggested edit needs two approval (or reject) reviews (as suggested edits on Stack Overflow) while a week ago they required only one approval/reject. Why? What is ...
2
votes
1answer
49 views
Duplicate answers - clean them up?
This question (originially from Stack Overflow has heaps of duplicate answers. Many users suggested the exact same changes to the code, presumably while the question was not yet migrated; most of the ...
7
votes
2answers
236 views
Suggested edit breaks license due to pastebin
I am not a lawyer.
I am reviewing a suggested edit where a user created a jsFiddle from the code in someone elses question. I believe this breaches the CC-BY-SA 3.0 license that the code in the ...
6
votes
1answer
107 views
Is it appropriate to prune code blocks by editing out irrelevant Javadoc comments?
I've just did a compulsive edit on this question, essentially removing @author, @version and ...
10
votes
0answers
86 views
Removing tags in title [duplicate]
I just removed 5 (scheme) tags from 5 questions. Some examples:
Before: (Scheme) [SICP ex. 1.30]
Iterative Sum
After: [SICP ex. 1.30] Iterative
Sum
They were all in the similar format:
Before: (...
2
votes
1answer
60 views
“Approve Edit” info page broken
I edited an answer and got a message saying that the edit needed to be peer reviewed before being posted. This was something new to me, so I went to the priviledges page to see what was up. However, ...