PHP array_rand / Loop / array_push / implode behavior?

Question

Why does this not make two arrays one within 7 numbers and one within 2 numbers in it?

It somehow combines the both into one.

When i echo $arvottuLottoRivi and $lottoLisaNumerot in my HTML page the result is:

$arvottuLottoRivi (1,2,3,4,5,6,7,8,9,10) : $lottoLisaNumerot

all the seven numbers.

I have now tried three different styles but same thing happens in all cases

    // VARAIBLES
    $lottoNumerot = $_POST["lottoNumerot"];
    $mahdollisetNumerot = array("1","2","3","4","5","6","7","8","9","10","11","12","13","14","15","16","17","18","19","20","21","22","23","24","25","26","27","28","29","30","31","32","33","34","35","36","37","38","39");
    $i = 0;
    $l = 0;
    $k = 0;


    //ARRAYS
    $arvottuLottoRivi = array();
    $lottoLisaNumerot = array();
    $tenNumbersArray = array();


    //FUNCTIONS
    $numeroidenRandomointi = array_rand($mahdollisetNumerot, 10);


    // COUNTS ARRAY LENGHT
    $lottoRivinPituus = count($numeroidenRandomointi);;

    // LOOPS
    foreach($numeroidenRandomointi as $randomNumero){
        while($i <= $lottoRivinPituus){
        $i++;
        }
        $randomToArray = array_push($tenNumbersArray, $randomNumero);
    }


    // LOOPIT
    foreach($tenNumbersArray as $randomToSite){
        while($l <= $lottoRivinPituus){
        $l++;
        }
        if($l <= 7){
            array_push($arvottuLottoRivi, $randomToSite);
        }
    }

    foreach($tenNumbersArray as $randomToSiteLisanuimerot){
        while($k <= $lottoRivinPituus){
        $k++;
        }
        if($k >= 7){
            array_push($lottoLisaNumerot, $randomToSiteLisanuimerot);
        }
    }

    $arvottuLottoRivi = implode(' ', $arvottuLottoRivi);
    $lottoLisaNumerot = implode(' ', $lottoLisaNumerot);

Answer 1

When you write:

foreach($tenNumbersArray as $randomToSiteLisanuimerot){
    while($k <= $lottoRivinPituus){
    $k++;
    }
    if($k >= 7){
        array_push($lottoLisaNumerot, $randomToSiteLisanuimerot);
    }
}

the while loop is equivalent to:

    $k = $lottoRivinPituus + 1;

Since $lottoRivinPituus is 10, $k is always 11. Therefore, if($k >= 7) is always true, so all elements of $randomToSiteLisanuumerot are copied to $lottoLisaNumerot. Similarly, in the previous loop, the test if ($l <= 7) is always false, so nothing is copied to $arvottuLottoRivi.

I think you were trying to test the current position in the loop, not the count of all elements in the array. You can do it like this:

foreach($tenNumbersArray as $l => $randomToSite){
    if($l < 7){
        array_push($arvottuLottoRivi, $randomToSite);
    }
}
foreach($tenNumbersArray as $k => $randomToSiteLisanuimerot){
    if($k >= 7){
        array_push($lottoLisaNumerot, $randomToSiteLisanuimerot);
    }
}

But this wastes time iterating over elements it doesn't care about. A better way would be:

$arvotSize = min(7, $lottoRivinPituus);
for ($l = 0; $l < $arvotSize; $l++) {
    array_push($arvottuLottoRivi, $tenNumbersArray[$l]);
}
for ($k = $arvotSize; $k < $lottoRivinPituus; $k++) {
    array_push($lottoLisaNumerot, $tenNumbersArray[$k]);
}

Answer 2

I really didn't get your code.

Why don't use rand function?

$randomNumbers1 = array();
$randomNumbers2 = array();


$i = 0;
while ($i < 7) {
    $aNumber = rand(1, 39);
    if (!in_array($aNumber, $randomNumbers1)) {
        $randomNumbers1[] = $aNumber;
        $i++;
    }
}

$i = 0;
while ($i < 2) {
    $aNumber = rand(1, 39);
    if (!in_array($aNumber, $randomNumbers2)) {
        $randomNumbers2[] = $aNumber;
        $i++;
    }
}

And if the seconds array cannot contains any number within the first one:

$i = 0;
while ($i < 2) {
    $aNumber = rand(1, 39);
    if (!in_array($aNumber, $randomNumbers2) && !in_array($aNumber, $randomNumbers1)) {
        $randomNumbers2[] = $aNumber;
        $i++;
    }
}