Skip to main content
Question Protected by Heslacher
Tweeted twitter.com/#!/StackCodeReview/status/444061192550883328
Please, no "thanks" and signature - show thanks with upvotes after 15 rep
Source Link
Jamal
  • 35.2k
  • 13
  • 134
  • 238

You guys will probably laugh at the way that I implemented this simple task. I know there is a simpler way of doing this, but I just really cantcan't think of it right now. Can you guys please help me out? A fellow member of stack exchange recommended me to the Code Review

Thanks in advance, -Jia

    String sample = "hello world";
    char arraysample[] = sample.toCharArray();
    int length = sample.length();
    
    //count the number of each letter in the string
    int acount = 0;
    int bcount = 0;
    int ccount = 0;
    int dcount = 0;
    int ecount = 0;
    int fcount = 0;
    int gcount = 0;
    int hcount = 0;
    int icount = 0;
    int jcount = 0;
    int kcount = 0;
    int lcount = 0;
    int mcount = 0;
    int ncount = 0;
    int ocount = 0;
    int pcount = 0;
    int qcount = 0;
    int rcount = 0;
    int scount = 0;
    int tcount = 0;
    int ucount = 0;
    int vcount = 0;
    int wcount = 0;
    int xcount = 0;
    int ycount = 0;
    int zcount = 0; 
    
    for(int i = 0; i < length; i++)
    {
        char c = arraysample[i];
        switch (c) 
        {
            case 'a': 
                acount++;
                break;
            case 'b': 
                bcount++;
                break;
            case 'c': 
                ccount++;
                break;
            case 'd': 
                dcount++;
                break;
            case 'e':
                ecount++;
                break;
            case 'f':
                fcount++;
                break;
            case 'g':
                gcount++;
                break;
            case 'h':
                hcount++;
                break;
            case 'i':
                icount++;
                break;
            case 'j':
                jcount++;
                break;
            case 'k':
                kcount++;
                break;
            case 'l':
                lcount++;
                break;
            case 'm':
                mcount++;
                break;
            case 'n':
                ncount++;
                break;
            case 'o':
                ocount++;
                break;
            case 'p':
                pcount++;
                break;
            case 'q':
                qcount++;
                break;
            case 'r':
                rcount++;
                break;
            case 's':
                scount++;
                break;
            case 't':
                tcount++;
                break;
            case 'u':
                ucount++;
                break;
            case 'v':
                vcount++;
                break;
            case 'w':
                wcount++;
                break;
            case 'x':
                xcount++;
                break;
            case 'y':
                ycount++;
                break;
            case 'z':
                zcount++;
                break;
            }
    }
    System.out.println ("There are " +hcount+" h's in here ");
    System.out.println ("There are " +ocount+" o's in here ");

You guys will probably laugh at the way that I implemented this simple task. I know there is a simpler way of doing this but I just really cant think of it right now. Can you guys please help me out? A fellow member of stack exchange recommended me to the Code Review

Thanks in advance, -Jia

    String sample = "hello world";
    char arraysample[] = sample.toCharArray();
    int length = sample.length();
    
    //count the number of each letter in the string
    int acount = 0;
    int bcount = 0;
    int ccount = 0;
    int dcount = 0;
    int ecount = 0;
    int fcount = 0;
    int gcount = 0;
    int hcount = 0;
    int icount = 0;
    int jcount = 0;
    int kcount = 0;
    int lcount = 0;
    int mcount = 0;
    int ncount = 0;
    int ocount = 0;
    int pcount = 0;
    int qcount = 0;
    int rcount = 0;
    int scount = 0;
    int tcount = 0;
    int ucount = 0;
    int vcount = 0;
    int wcount = 0;
    int xcount = 0;
    int ycount = 0;
    int zcount = 0; 
    
    for(int i = 0; i < length; i++)
    {
        char c = arraysample[i];
        switch (c) 
        {
            case 'a': 
                acount++;
                break;
            case 'b': 
                bcount++;
                break;
            case 'c': 
                ccount++;
                break;
            case 'd': 
                dcount++;
                break;
            case 'e':
                ecount++;
                break;
            case 'f':
                fcount++;
                break;
            case 'g':
                gcount++;
                break;
            case 'h':
                hcount++;
                break;
            case 'i':
                icount++;
                break;
            case 'j':
                jcount++;
                break;
            case 'k':
                kcount++;
                break;
            case 'l':
                lcount++;
                break;
            case 'm':
                mcount++;
                break;
            case 'n':
                ncount++;
                break;
            case 'o':
                ocount++;
                break;
            case 'p':
                pcount++;
                break;
            case 'q':
                qcount++;
                break;
            case 'r':
                rcount++;
                break;
            case 's':
                scount++;
                break;
            case 't':
                tcount++;
                break;
            case 'u':
                ucount++;
                break;
            case 'v':
                vcount++;
                break;
            case 'w':
                wcount++;
                break;
            case 'x':
                xcount++;
                break;
            case 'y':
                ycount++;
                break;
            case 'z':
                zcount++;
                break;
            }
    }
    System.out.println ("There are " +hcount+" h's in here ");
    System.out.println ("There are " +ocount+" o's in here ");

I know there is a simpler way of doing this, but I just really can't think of it right now. Can you please help me out?

String sample = "hello world";
char arraysample[] = sample.toCharArray();
int length = sample.length();

//count the number of each letter in the string
int acount = 0;
int bcount = 0;
int ccount = 0;
int dcount = 0;
int ecount = 0;
int fcount = 0;
int gcount = 0;
int hcount = 0;
int icount = 0;
int jcount = 0;
int kcount = 0;
int lcount = 0;
int mcount = 0;
int ncount = 0;
int ocount = 0;
int pcount = 0;
int qcount = 0;
int rcount = 0;
int scount = 0;
int tcount = 0;
int ucount = 0;
int vcount = 0;
int wcount = 0;
int xcount = 0;
int ycount = 0;
int zcount = 0; 

for(int i = 0; i < length; i++)
{
    char c = arraysample[i];
    switch (c) 
    {
        case 'a': 
            acount++;
            break;
        case 'b': 
            bcount++;
            break;
        case 'c': 
            ccount++;
            break;
        case 'd': 
            dcount++;
            break;
        case 'e':
            ecount++;
            break;
        case 'f':
            fcount++;
            break;
        case 'g':
            gcount++;
            break;
        case 'h':
            hcount++;
            break;
        case 'i':
            icount++;
            break;
        case 'j':
            jcount++;
            break;
        case 'k':
            kcount++;
            break;
        case 'l':
            lcount++;
            break;
        case 'm':
            mcount++;
            break;
        case 'n':
            ncount++;
            break;
        case 'o':
            ocount++;
            break;
        case 'p':
            pcount++;
            break;
        case 'q':
            qcount++;
            break;
        case 'r':
            rcount++;
            break;
        case 's':
            scount++;
            break;
        case 't':
            tcount++;
            break;
        case 'u':
            ucount++;
            break;
        case 'v':
            vcount++;
            break;
        case 'w':
            wcount++;
            break;
        case 'x':
            xcount++;
            break;
        case 'y':
            ycount++;
            break;
        case 'z':
            zcount++;
            break;
        }
}
System.out.println ("There are " +hcount+" h's in here ");
System.out.println ("There are " +ocount+" o's in here ");
Source Link
statius
  • 171
  • 1
  • 1
  • 5

Count number of each char in a String

You guys will probably laugh at the way that I implemented this simple task. I know there is a simpler way of doing this but I just really cant think of it right now. Can you guys please help me out? A fellow member of stack exchange recommended me to the Code Review

Thanks in advance, -Jia

    String sample = "hello world";
    char arraysample[] = sample.toCharArray();
    int length = sample.length();
    
    //count the number of each letter in the string
    int acount = 0;
    int bcount = 0;
    int ccount = 0;
    int dcount = 0;
    int ecount = 0;
    int fcount = 0;
    int gcount = 0;
    int hcount = 0;
    int icount = 0;
    int jcount = 0;
    int kcount = 0;
    int lcount = 0;
    int mcount = 0;
    int ncount = 0;
    int ocount = 0;
    int pcount = 0;
    int qcount = 0;
    int rcount = 0;
    int scount = 0;
    int tcount = 0;
    int ucount = 0;
    int vcount = 0;
    int wcount = 0;
    int xcount = 0;
    int ycount = 0;
    int zcount = 0; 
    
    for(int i = 0; i < length; i++)
    {
        char c = arraysample[i];
        switch (c) 
        {
            case 'a': 
                acount++;
                break;
            case 'b': 
                bcount++;
                break;
            case 'c': 
                ccount++;
                break;
            case 'd': 
                dcount++;
                break;
            case 'e':
                ecount++;
                break;
            case 'f':
                fcount++;
                break;
            case 'g':
                gcount++;
                break;
            case 'h':
                hcount++;
                break;
            case 'i':
                icount++;
                break;
            case 'j':
                jcount++;
                break;
            case 'k':
                kcount++;
                break;
            case 'l':
                lcount++;
                break;
            case 'm':
                mcount++;
                break;
            case 'n':
                ncount++;
                break;
            case 'o':
                ocount++;
                break;
            case 'p':
                pcount++;
                break;
            case 'q':
                qcount++;
                break;
            case 'r':
                rcount++;
                break;
            case 's':
                scount++;
                break;
            case 't':
                tcount++;
                break;
            case 'u':
                ucount++;
                break;
            case 'v':
                vcount++;
                break;
            case 'w':
                wcount++;
                break;
            case 'x':
                xcount++;
                break;
            case 'y':
                ycount++;
                break;
            case 'z':
                zcount++;
                break;
            }
    }
    System.out.println ("There are " +hcount+" h's in here ");
    System.out.println ("There are " +ocount+" o's in here ");