Getting substrings from a string c#

Make it regex with named groups:

var matcher = new Regex(@"(?<assesment>.+?),\s*(?<zone>.+)");
var match = matcher.Match("assessment1, Firewall");
var assesment = match.Groups["assesment"].Value;
var zone = match.Groups["zone"].Value;

where

• (?<assesment>.+?) - catches assesment ungreedy ? so that it stops at ,
• ,\s* - the separator is , with an optional white space (zero or more times)
• (?<zone>.+) - catches zone greedy

Sample at regex101.com

I wasn't aware of that but @Vogel612 kindly mentioned that backtracking as I use it in my solution above might be sometimes a problem: Why Using the Greedy .* in Regular Expressions Is Almost Never What You Actually Want and The Explosive Quantifier Trap.

Using the (?<assessment>[^,]+) expression would be much faster and safer here.

That change drops the match you propose from 30 steps until matching to 9, so it saves roughly 60% of execution time.

Another valuable remark by @forsvarir suggests using the statick Regex.IsMatch method over creating a new instance each time. This should be much faster here.

The difference in performance is due to the caching of regular expressions used in static method calls.

There is a lot more to that with pleny of examples on Optimizing Regular Expression Performance, Part I: Working with the Regex Class and Regex Objects [Ron Petrusha]

Just use the Split method

 string[] splittedArray = _view.SelectedAssessment.Split(new[]{','});
 string zone = splittedArray[1].Trim();
 string assessmentName = splittedArray[0].Trim();

Also be careful when doing a manual replace on strings that go into the DB as you might be vulnerable to SQL injection