I've got this method and I realize that an instance of HttpClass is going to be created for each call to it. While working seemingly OK, I'm considering moving it out and placing it as a private property accessible to each call to the method. There might be other methods making use of it in the future as well. I have no information on how often these calls will occur. (There's a try/catch too but it's omitted for brevity's sake.)
[OperationContract]
[WebGet(UriTemplate = "Poof"]
public async Task<String> GetPoof()
{
String url = BaseUrl + "poofy";
using (HttpClient client = new HttpClient())
{
client.DefaultRequestHeaders.TryAddWithoutValidation(
"Authorization", GetAuthorizationSchema());
HttpResponseMessage message = await client.GetAsync(url);
return await message.Content.ReadAsStringAsync();
}
}
What I'm thinking of is something like this:
private HttpClient _Client
private HttpClient Client { get { return _Client ?? GetNewClient(); } }
[OperationContract]
[WebGet(UriTemplate = "Poof"]
public async Task<String> GetPoof()
{
String url = BaseUrl + "poofy";
HttpResponseMessage message = await client.GetAsync(url);
return await message.Content.ReadAsStringAsync();
}
My worry is, though, that the different calls utilizing the same client instance will somehow collide and call huge issues later on, especially if the number of calls per time unit raises beyond a critical level. Should I be worried?
