How to delete item from an array of object using angularjs?

Question

i wanted to delete index from array if rest service response return true , so in below case lets say we have true from rest service i wanted to delete object where id is 'RA_ATTST_LANGUAGE` from array. I tried below code but its not deleting what is missing ?

main.js

MessageAdminNotificationFactory.getAttestationLanValidation().then(function(response){
        var data = response.data;
        console.log('attestation',data);
        if(data){
          angular.forEach($scope.adminDataSource,function(value,$index){
            if(value.id === 'RA_ATTST_LANGUAGE'){
              $scope.adminDataSource.splice($index, 1);
            }
            console.log('dropdown',value.id);
          });
        }
      });

$scope.adminDataSource = [{
    "uid": null,
    "index": 0,
    "selected": null,
    "expanded": null,
    "id": "RA_PLTFRM_NOTIF",
    "text": "Platform Maintenance Notification",
    "parentId": null,
    "items": null
}, {
    "uid": null,
    "index": 0,
    "selected": null,
    "expanded": null,
    "id": "RA_ATTST_LANGUAGE",
    "text": "Attestation Language",
    "parentId": null,
    "items": null
}]

you're modifying an array as you iterate over its index. Not sure if that is the cause but you should never do that. at least break the loop if you do. But you should prob use Array.filter — lonewarrior556
– lonewarrior556, Commented May 18, 2016 at 20:08

lonewarrior556 · Accepted Answer · 2016-05-18 20:24:41Z

0

$scope.adminDataSource = $scope.adminDataSource.filter(
  function(value){
     return value.id !== 'RA_ATTST_LANGUAGE';
})

Array.filter is the way to go. filters out anything that evaluates to false;

edited May 18, 2016 at 20:24

answered May 18, 2016 at 20:14

lonewarrior556

4,5293 gold badges32 silver badges59 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

score 0 · Accepted Answer · 2016-05-18 20:19:08Z

0

Iterate the array from end to start

for(var i=$scope.adminDataSource.length-1;i>=0;i--){
    var value = $scope.adminDataSource[i];
    if(value.id === 'RA_ATTST_LANGUAGE') {
       $scope.adminDataSource.splice(i,1);
    }
}

This way it doesn't matter if the array shrinks while you iterate.

edited May 18, 2016 at 20:19

answered May 18, 2016 at 20:12

user725844

3 Comments

lonewarrior556 Over a year ago

Avoid using let if question is not tagged es6?

user725844 Over a year ago

You're right. Just a typescript habit of mine. TS transpiles let into var.

lonewarrior556 Over a year ago

and now stack overflow has 3 more questions... let? es6? typescript? :)

Collectives™ on Stack Overflow

How to delete item from an array of object using angularjs?

2 Answers 2

Comments

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related