Create your own GitHub profile
Sign up for your own profile on GitHub, the best place to host code, manage projects, and build software alongside 31 million developers.
Sign up
Pinned
5,265 contributions in the last year
Activity overview
Contributed to
angular/material2,
angular/cdk-builds,
angular/material2-moment-adapter-builds
and 5 other
repositories
Contribution activity
March 2019
Created a pull request in angular/material2 that received 3 comments
fix(button-toggle): able to focus disabled button via click
Along the same lines as #15499. Fixes users being able to focus a disabled button toggle by clicking on it. The issue comes from us preserving the …
+20
−4
•
3
comments
- build: don't format api golden files
- fix(sidenav): some internal subjects not being completed
- build: fix error in expansion panel examples
- refactor(badge): rework to account for ivy changes
- refactor(badge): rework to account for ivy changes
- fix(datepicker): don't set aria-haspopup if no datepicker is set
- fix(list): not picking up indirect descendant lines
- refactor(snack-bar): rework to account for ivy (#15536)
- refactor(snack-bar): rework to account for ivy
- refactor(snack-bar): rework to account for ivy
- feat(bottom-sheet): allow for scroll strategy to be configured
- fix(bottom-sheet): unable to reopen same bottom sheet after closing via back button
- feat(stepper): add the ability to control the position of the header in a horizontal stepper
- fix(button-toggle): value cleared when replacing with list that still contains the selected value
- fix(overlay): allow overlay sass variables to be overwritten
- fix(slide-toggle): clear name from host node
- refactor(tree): rework to account for ivy changes
- refactor(tree): rework to account for ivy changes
- fix(slide-toggle): able to receive focus while disabled on click
- docs(dialog): add doc for align attribute
- fix(radio): able to focus disabled radio button via click
- fix(stepper): content not being rendered out initially with ivy
- fix(stepper): content not being rendered out initially with ivy
- chore: update tooltip golden file
- fix(stepper): avoid breaking change in stepControl type
- Some pull requests not shown.
- test(ivy): remove passing snack bar test from blocklist
- test(ivy): remove tree tests from blocklist
- fix(ivy): listeners inherited twice if sub class has own propMetadata
- test(ivy): update root causes for stepper
- fix(ivy): matches nodes in the logical tree in DebugNode.query
- test(ivy): remove chip list tests from blocklist
- fix(ivy): unable to inherit view queries into component from directive
- fix(ivy): unable to inject class and style attributes
- fix(ivy): inherited host listeners called twice
- test(ivy): update root causes for chip list
- test(ivy): update root causes for drag drop
- test(ivy): update root causes for tooltip
- test(ivy): update sidenav root causes
- fix(ivy): attached flag not being reset when view is destroyed
- fix(autofill): use static queries to read values used in ngOnInit
- feat(overlay): add option to provide a custom element container for the…
- fix(schematics): ensure project "style" and "skipTests" options are respected
- chore(typescript): uniformly access all index sigs with index access.
- fix(autofill): use static queries to read values used in ngOnInit
- fix(autofill): use static queries to read values used in ngOnInit
- chore: create separate modules for each demo page
- fix(table): use static queries for examples
- refactor(focus-monitor): adapt demo examples for Ivy
- refactor(focus-monitor): adapt demo examples for Ivy
- refactor: move DOCUMENT import from platform-browser to common
- fix(tooltip): render style values in ngOnInit instead of the constructor
- fix(tooltip): render style values in ngOnInit instead of the constructor
- test(input): make the type validation test to pass in Ivy
- refactor(datepicker): adapt custom header demo for Ivy
- refactor(datepicker): adapt custom header demo for Ivy
- test(input): make the type validation test to pass in Ivy
- refactor(drag-drop): remove manual observers count
- test(table): update static query test
- test(table): update static query test
- fix:(tabs) add call for rechecking tab scroll distance
- fix(form-field): FormField with outline doesn't work well with dir="r…
- docs(chips): add drag and drop sample
- refactor(selection-list): avoid deprecated method
- feat(common): Add dev-mode sanity check for mismatched versions of cdk and material
- Some pull request reviews not shown.