Skip to content

/ jss

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hoisting of new react features #925

Merged
merged 2 commits into from Nov 28, 2018
Merged

Fix hoisting of new react features #925

merged 2 commits into from Nov 28, 2018

Conversation

@eps1lon
Copy link
Contributor

@eps1lon eps1lon commented Nov 28, 2018

What would you like to add/fix?

  • hoisting of new react features

Corresponding issue (if exists):
cssinjs/react-jss#314

hoist-non-react-statics@2.x does not support forwardRef components, contextType static nor getDerivedStateFromError static. The major version bump was due to the added requirement of react >= 0.14 which was dropped in hoist-non-react-statics@3.2.0. Therefore this change should not be breaking.

hoist-non-react-statics changelog
@eps1lon
Fix hoisting of new react features
Loading status checks…
358723d
@HenriBeck
Copy link
Member

@HenriBeck HenriBeck commented Nov 28, 2018 •
edited

Please run yarn build to update the size snapshots.
Otherwise, the PR looks good.

I will merge once the size snapshots are updated.
@eps1lon
Update size-snapshot
Loading status checks…
675b29f
@HenriBeck
HenriBeck approved these changes Nov 28, 2018
View changes
@eps1lon
Copy link
Contributor Author

@eps1lon eps1lon commented Nov 28, 2018

@HenriBeck CI failures look unrelated. Do you want me to push an empty commit to trigger a build or are you taking care of this?
@HenriBeck
Copy link
Member

@HenriBeck HenriBeck commented Nov 28, 2018

@kof kof merged commit 9b87545 into cssinjs:master Nov 28, 2018
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@kof
Copy link
Member

@kof kof commented Nov 28, 2018

Thanks, merged
@eps1lon eps1lon deleted the eps1lon:fix/hoisting-new-react-features branch Nov 28, 2018
HenriBeck added a commit that referenced this pull request Dec 3, 2018
@HenriBeck
Merge remote-tracking branch 'origin/react-jss/jss-context' into reac…
Unverified
This user has not uploaded their public key yet.
GPG key ID: 69AEE0228B2177ED Learn about signing commits
Loading status checks…
5d85697 
…t-jss/jss-context

* origin/react-jss/jss-context:
  Fix hoisting of new react features (#925)
bhupinderbola pushed a commit to bhupinderbola/jss that referenced this pull request Sep 17, 2019
@eps1lon @kof
(split)Fix hoisting of new react features (cssinjs#925)
ab77b8c 
* Fix hoisting of new react features

* Update size-snapshot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HenriBeck HenriBeck

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@eps1lon @HenriBeck @kof
You can’t perform that action at this time.