Skip to content

/ recipes

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[webpack-encore-bundle] - update comments in default recipe for new features #562

Merged
merged 3 commits into from Apr 10, 2019
Merged

[webpack-encore-bundle] - update comments in default recipe for new features #562

merged 3 commits into from Apr 10, 2019

Conversation

@PhilETaylor
Copy link
Contributor

PhilETaylor commented Apr 1, 2019

Q A
License MIT

This PR makes two changes

  1. update documentation for previous feature allowing output_path to be false

  2. update documentation for new feature to set the value fo crossorigin attribute if PR symfony/webpack-encore-bundle#56 is accepted
@symfony-flex-server
symfony-flex-server bot approved these changes Apr 1, 2019
View changes
Copy link
Contributor

symfony-flex-server bot left a comment

Pull request passes validation.
@PhilETaylor PhilETaylor mentioned this pull request Apr 1, 2019
Merged
@PhilETaylor
Copy link
Contributor Author

PhilETaylor commented Apr 1, 2019

ONLY MERGE IF if PR symfony/webpack-encore-bundle#56 is accepted
@PhilETaylor PhilETaylor changed the title webpack - update comments in default recipe for new features [webpack-encore-bundle] - update comments in default recipe for new features Apr 1, 2019
@symfony-flex-server
symfony-flex-server bot approved these changes Apr 1, 2019
View changes
Copy link
Contributor

symfony-flex-server bot left a comment

Pull request passes validation.
@stof
stof reviewed Apr 1, 2019
View changes
symfony/webpack-encore-bundle/1.0/config/packages/webpack_encore.yaml Outdated Show resolved Hide resolved
@symfony-flex-server
symfony-flex-server bot approved these changes Apr 1, 2019
View changes
Copy link
Contributor

symfony-flex-server bot left a comment

Pull request passes validation.
@symfony-flex-server
symfony-flex-server bot approved these changes Apr 2, 2019
View changes
Copy link
Contributor

symfony-flex-server bot left a comment

Pull request passes validation.
@Nyholm Nyholm changed the title [webpack-encore-bundle] - update comments in default recipe for new features WIP: [webpack-encore-bundle] - update comments in default recipe for new features Apr 6, 2019
@symfony-flex-server
symfony-flex-server bot approved these changes Apr 6, 2019
View changes
Copy link
Contributor

symfony-flex-server bot left a comment

Pull request passes validation.
@PhilETaylor
Copy link
Contributor Author

PhilETaylor commented Apr 10, 2019

This can be merged as the upstream change has been merged in symfony/webpack-encore-bundle@2384cfd
@weaverryan
weaverryan approved these changes Apr 10, 2019
View changes
@weaverryan weaverryan changed the title WIP: [webpack-encore-bundle] - update comments in default recipe for new features [webpack-encore-bundle] - update comments in default recipe for new features Apr 10, 2019
@symfony-flex-server
symfony-flex-server bot approved these changes Apr 10, 2019
View changes
Copy link
Contributor

symfony-flex-server bot left a comment

Pull request passes validation.
@chalasr
chalasr approved these changes Apr 10, 2019
View changes
@fabpot
fabpot approved these changes Apr 10, 2019
View changes
@symfony-flex-server
symfony-flex-server bot requested changes Apr 10, 2019
View changes
Copy link
Contributor

symfony-flex-server bot left a comment

Pull request does not pass validation.
@fabpot
Copy link
Member

fabpot commented Apr 10, 2019

@PhilETaylor Can you rebase this PR? It will then be merged automatically. Thank you.
PhilETaylor added 3 commits Apr 1, 2019
@PhilETaylor
webpack - update comments in default recipe for new features
Verified
This commit was signed with a verified signature.
PhilETaylor Phil Taylor
GPG key ID: 8B4DAA1CAC85C9FF Learn about signing commits
8ad644b
@PhilETaylor
remove duplication
Verified
This commit was signed with a verified signature.
PhilETaylor Phil Taylor
GPG key ID: 8B4DAA1CAC85C9FF Learn about signing commits
2adad89
@PhilETaylor
sync comments with upstream PR
Verified
This commit was signed with a verified signature.
PhilETaylor Phil Taylor
GPG key ID: 8B4DAA1CAC85C9FF Learn about signing commits
Loading status checks…
66b2161
@symfony-flex-server
symfony-flex-server bot approved these changes Apr 10, 2019
View changes
Copy link
Contributor

symfony-flex-server bot left a comment

Pull request passes validation.
@symfony-flex-server symfony-flex-server bot merged commit 66b2161 into symfony:master Apr 10, 2019
1 check passed
1 check passed
continuous-integration/symfony/pr Done
Details
symfony-flex-server bot added a commit that referenced this pull request Apr 10, 2019
@symfony-flex-server
Merge pull request #562
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
c466e7a
@PhilETaylor
Copy link
Contributor Author

PhilETaylor commented Apr 10, 2019

Rebased and merged... 🎉
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof

@fabpot fabpot

@weaverryan weaverryan

@chalasr chalasr

@symfony-flex-server symfony-flex-server

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@PhilETaylor @fabpot @weaverryan @stof @chalasr
You can’t perform that action at this time.