Make DataProtection certificate tests assertions stricter about which cert is used in the test#9224
Closed
natemcmaster wants to merge 1 commit intomasterfrom
Closed
Make DataProtection certificate tests assertions stricter about which cert is used in the test#9224natemcmaster wants to merge 1 commit intomasterfrom
natemcmaster wants to merge 1 commit intomasterfrom
Conversation
… cert is used in the test
Contributor
Author
|
/azp run AspNetCore-ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
Ok, nope, that wasn't the right solution for the problem. Will continue to investigate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses aspnet/AspNetCore-Internal#2177
This test only fails on some CI agents. As these tests rely on a certificate store shared by other builds, it's probably that the failures are the result of some other dotnet team adding a cert called 'TestCert' into the X509Store.
This changes the tests to pull from the X509Store the exact cert we want the test to use.