Update reference assemblies WIP#9688
Closed
JunTaoLuo wants to merge 3 commits intorelease/3.0-preview5from
Closed
Conversation
JunTaoLuo
requested review from
BrennanConroy,
SteveSandersonMS,
Tratcher,
analogrelay,
halter73,
jkotalik and
mikaelm12
as code owners
JunTaoLuo
changed the title
Contributor
Author
|
WIP, triggering for tests. Trying to re-execute script on windows since it didn't work on mac. |
JunTaoLuo
commented
Apr 23, 2019
| <TargetFrameworks>netcoreapp3.0</TargetFrameworks> | ||
| </PropertyGroup> | ||
| <ItemGroup Condition="'$(TargetFramework)' == 'netcoreapp3.0'"> | ||
| <ItemGroup Condition=" == netcoreapp3.0"> |
Contributor
Author
There was a problem hiding this comment.
This looks super wrong. Not sure what the script is doing here.
JunTaoLuo
removed request for
BrennanConroy,
SteveSandersonMS,
Tratcher,
analogrelay,
halter73,
jkotalik and
mikaelm12
This reverts commit 8235126.
natemcmaster
approved these changes
Apr 23, 2019
Contributor
|
Huh, this is strange. CodeCheck.ps1 failed on the PR check.
|
Contributor
Author
|
Yea, and it's the exact same error as the original build: https://dnceng.visualstudio.com/public/_build/results?buildId=164916. So code check doesn't like either order?! |
Contributor
|
I think there is a legit bug in GenAPI. Investigating... |
Contributor
|
See dotnet/arcade#2607 (comment). GenAPI produces different results when running on |
Contributor
Author
|
Going to wait for the fix in arcade. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to address: https://github.com/aspnet/AspNetCore-Internal/issues/2372.
Updated reference assemblies. EDIT: seems like running
dotnet msbuild /t:GenerateReferenceSourceon macOS doesn't work.