Typos roundup for Markdown and resources#9657
Merged
cormacpayne merged 298 commits intoAzure:masterfrom Jul 29, 2019
Merged
Conversation
cormacpayne
suggested changes
Jul 17, 2019
Member
cormacpayne
left a comment
cormacpayne
left a comment
There was a problem hiding this comment.
@nschonni Hey Nick, this PR is awesome 😁 Thanks for taking the time to make these changes. I made a few additional comments for things that should be changed whenever you get the chance. The two main things that should be changed:
- It looks like there are some additional commits in your PR that makes changes outside of typos (ResourceGraph, ServiceBus, StorageSync, Websites, to name a few). If you could pull the latest from the master` branch of the Azure fork and ensure that these files aren't a part of this PR, that would be great.
- In order for the changes to be shipped in the next version of their corresponding module, there will need to be a change log update in each of the updated modules. If you could go through and make a add a snippet in each affected modules'
ChangeLog.mdfile under the## Upcoming Releaseheader (with something along the lines of "Fixed miscellaneous typos across module"), that would help to ensure that these updates are sent out with the next release.
src/Compute/Compute/VirtualMachine/Action/StopAzureVMCommand.cs
Outdated
Show resolved
Hide resolved
src/EventHub/EventHub/Cmdlets/NetworkRuleSet/SetAzureEventHubNetworkrule.cs
Outdated
Show resolved
Hide resolved
src/ManagedServiceIdentity/ManagedServiceIdentity/help/Remove-AzUserAssignedIdentity.md
Outdated
Show resolved
Hide resolved
src/ServiceBus/ServiceBus/help/Set-AzServiceBusNetworkRuleSet.md
Outdated
Show resolved
Hide resolved
Member
|
@cormacpayne since you reviewed this, please kisk off the azp runs if the PR looks OK |
cormacpayne
previously approved these changes
Jul 29, 2019
Member
|
/azp run |
Contributor
|
Azure Pipelines successfully started running 3 pipeline(s). |
cormacpayne
previously approved these changes
Jul 29, 2019
nschonni
commented
Jul 29, 2019
Member
|
/azp run |
Contributor
|
Azure Pipelines successfully started running 3 pipeline(s). |
…to typos # Conflicts: # src/Monitor/Monitor/ChangeLog.md # src/RecoveryServices/RecoveryServices/ChangeLog.md
cormacpayne
approved these changes
Jul 29, 2019
Member
|
/azp run |
Contributor
|
Azure Pipelines successfully started running 3 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Had a bunch of individual PRs for typo cleanup, but since they each pull down build resources, it was recommend to combine them. I went ahead an ran cSpell over the Markdown files and did find/replace corrections to some of the source files for similar typos that didn't affect public API stuff.
This doesn't comply with the "small amount of commits", but I can try to split it into recommended batch sizes, or trying to filter branch by folder if that makes more sense.
I haven't updated any of the changelogs pending feedback on removing any changes.
Checklist
CONTRIBUTING.mdplatyPSmodule